Skip to contentSkip to conversation

ndtest: Remove redundant NULL check

PATCH In review Kang Minchul 1 participant 2 messages Nov 13, 2022 libnvdimm: non-volatile memory device

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ndtest: Remove redundant NULL check

This addresses cocci warning as follows:
WARNING: NULL check before some freeing functions is not needed.

---
 tools/testing/nvdimm/test/ndtest.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/testing/nvdimm/test/ndtest.c +1 -2
index 01ceb98c15a0..de4bc34bc47b 100644
@@ -370,8 +370,7 @@ static void *ndtest_alloc_resource(struct ndtest_priv *p, size_t size,
 buf_err:
 	if (__dma && size >= DIMM_SIZE)
 		gen_pool_free(ndtest_pool, __dma, size);
-	if (buf)
-		vfree(buf);
+	vfree(buf);
 	kfree(res);
 
 	return NULL;
Signature · 1 line
2.34.1
#1 lore raw

2022년 11월 13일 (일) 오후 8:26, Kang Minchul <[email protected]>님이 작성:

Quoted 24 lines

This addresses cocci warning as follows:
WARNING: NULL check before some freeing functions is not needed.

---
 tools/testing/nvdimm/test/ndtest.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
tools/testing/nvdimm/test/ndtest.c +1 -3
index 01ceb98c15a0..de4bc34bc47b 100644
@@ -370,8 +370,7 @@ static void *ndtest_alloc_resource(struct ndtest_priv *p, size_t size,
 buf_err:
        if (__dma && size >= DIMM_SIZE)
                gen_pool_free(ndtest_pool, __dma, size);
-       if (buf)
-               vfree(buf);
+       vfree(buf);
        kfree(res);
 
        return NULL;
--
Quoted 2 lines

2.34.1

I just found an earlier discussion about the same patch as mine. Please ignore this patch.

Thanks.

Kang Minchul