genirq/msi: Treewide cleanup of pointless linux/msi.h includes
Subsystems (19)
cover genirq/msi: Treewide cleanup of pointless linux/msi.h includes
While working on per device MSI domains I noticed that quite some files include linux/msi.h just because.
The top level comment in the header file clearly says:
Regular device drivers have no business with any of these functions....
and actually none of the drivers needs anything from msi.h.
The series is not depending on anything so the individual patches can be picked up by the relevant maintainers. I'll mop up the leftovers close to the merge window.
Thanks,
tglx
PATCH 1/10 mfd: timberdale: Remove linux/msi.h include
Nothing in this file needs anything from linux/msi.h
--- drivers/mfd/timberdale.c | 1 - 1 file changed, 1 deletion(-)
drivers/mfd/timberdale.c +0 -1
@@ -11,7 +11,6 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/pci.h> -#include <linux/msi.h> #include <linux/mfd/core.h> #include <linux/slab.h>
Re: [patch 01/10] mfd: timberdale: Remove linux/msi.h include
Quoted 7 lines · Thomas Gleixner
Nothing in this file needs anything from
linux/msi.hSigned-off-by Thomas Gleixner <[email protected]>Cc Lee Jones <[email protected]>--- drivers/mfd/timberdale.c | 1 - 1 file changed, 1 deletion(-)
Applied, thanks.
Signature · 1 line
Lee Jones [李琼斯]
PATCH 2/10 ata: ahci: Remove linux/msi.h include
In reply to Thomas GleixnerNothing in this file needs anything from linux/msi.h
--- drivers/ata/ahci.c | 1 - 1 file changed, 1 deletion(-)
drivers/ata/ahci.c +0 -1
@@ -26,7 +26,6 @@#include <linux/device.h> #include <linux/dmi.h> #include <linux/gfp.h> -#include <linux/msi.h> #include <scsi/scsi_host.h> #include <scsi/scsi_cmnd.h> #include <linux/libata.h>
Damien Le Moal
AppliedRe: [patch 02/10] ata: ahci: Remove linux/msi.h include
Quoted 13 lines · Thomas Gleixner
Nothing in this file needs anything from
linux/msi.hSigned-off-by Thomas Gleixner <[email protected]>Cc Damien Le Moal <[email protected]>--- drivers/ata/ahci.c | 1 - 1 file changed, 1 deletion(-)
drivers/ata/ahci.c line 31
Quoted 7 lines
drivers/ata/ahci.c +0
-1@@ -26,7 +26,6 @@#include <linux/device.h> #include <linux/dmi.h> #include <linux/gfp.h> -#include <linux/msi.h> #include <scsi/scsi_host.h> #include <scsi/scsi_cmnd.h> #include <linux/libata.h>
Applied to ata tree for-6.2 branch. Thanks !
Signature · 2 lines
Damien Le Moal Western Digital Research
PATCH 3/10 scsi: lpfc: Remove linux/msi.h include
In reply to Thomas GleixnerNothing in this file needs anything from linux/msi.h
--- drivers/scsi/lpfc/lpfc_init.c | 1 - 1 file changed, 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c +0 -1
@@ -36,7 +36,6 @@#include <linux/firmware.h> #include <linux/miscdevice.h> #include <linux/percpu.h> -#include <linux/msi.h> #include <linux/irq.h> #include <linux/bitops.h> #include <linux/crash_dump.h>
Re: [patch 03/10] scsi: lpfc: Remove linux/msi.h include
Quoted 16 lines · Thomas Gleixner
Nothing in this file needs anything from
linux/msi.hSigned-off-by Thomas Gleixner <[email protected]>Cc James Smart <[email protected]>Cc Dick Kennedy <[email protected]>Cc "James E.J. Bottomley" <[email protected]>Cc "Martin K. Petersen" <[email protected]>--- drivers/scsi/lpfc/lpfc_init.c | 1 - 1 file changed, 1 deletion(-)
drivers/scsi/lpfc/lpfc_init.c line 41
Quoted 7 lines
drivers/scsi/lpfc/lpfc_init.c +0
-1@@ -36,7 +36,6 @@#include <linux/firmware.h> #include <linux/miscdevice.h> #include <linux/percpu.h> -#include <linux/msi.h> #include <linux/irq.h> #include <linux/bitops.h> #include <linux/crash_dump.h>
yep - agree.
-- james
Martin K. Petersen
AppliedRe: [patch 03/10] scsi: lpfc: Remove linux/msi.h include
In reply to Thomas GleixnerThomas,
Quoted 1 line
Nothing in this file needs anything from
linux/msi.h
Applied to 6.2/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
PATCH 4/10 bus: fsl-mc: Remove linux/msi.h includes
In reply to Thomas GleixnerNeither dprc-driver.c nor fsl-mc-bus.c need anything from linux/msi.h.
--- drivers/bus/fsl-mc/dprc-driver.c | 1 - drivers/bus/fsl-mc/fsl-mc-bus.c | 1 - 2 files changed, 2 deletions(-)
drivers/bus/fsl-mc/dprc-driver.c +0 -1
@@ -11,7 +11,6 @@#include <linux/module.h> #include <linux/slab.h> #include <linux/interrupt.h> -#include <linux/msi.h> #include <linux/fsl/mc.h> #include "fsl-mc-private.h"
drivers/bus/fsl-mc/fsl-mc-bus.c +0 -1
@@ -17,7 +17,6 @@#include <linux/slab.h> #include <linux/limits.h> #include <linux/bitops.h> -#include <linux/msi.h> #include <linux/dma-mapping.h> #include <linux/acpi.h> #include <linux/iommu.h>
[tip: irq/core] bus: fsl-mc: Remove linux/msi.h includes
The following commit has been merged into the irq/core branch of tip:
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 9d4c8175b8298a361d0ea91f435b1b4ed2ea06e3 Gitweb: https://git.kernel.org/tip/9d4c8175b8298a361d0ea91f435b1b4ed2ea06e3 Author: Thomas Gleixner <[email protected]> AuthorDate: Sun, 13 Nov 2022 21:34:00 +01:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Wed, 23 Nov 2022 23:07:37 +01:00
bus: fsl-mc: Remove linux/msi.h includes
Neither dprc-driver.c nor fsl-mc-bus.c need anything from linux/msi.h.
--- drivers/bus/fsl-mc/dprc-driver.c | 1 - drivers/bus/fsl-mc/fsl-mc-bus.c | 1 - 2 files changed, 2 deletions(-)
drivers/bus/fsl-mc/dprc-driver.c +0 -1
@@ -11,7 +11,6 @@#include <linux/module.h> #include <linux/slab.h> #include <linux/interrupt.h> -#include <linux/msi.h> #include <linux/fsl/mc.h> #include "fsl-mc-private.h"
drivers/bus/fsl-mc/fsl-mc-bus.c +0 -1
@@ -17,7 +17,6 @@#include <linux/slab.h> #include <linux/limits.h> #include <linux/bitops.h> -#include <linux/msi.h> #include <linux/dma-mapping.h> #include <linux/acpi.h> #include <linux/iommu.h>
PATCH 5/10 dmaengine: idxd: Remove linux/msi.h include
In reply to Thomas GleixnerNothing in this file needs anything from linux/msi.h
--- drivers/dma/idxd/device.c | 1 - 1 file changed, 1 deletion(-)
drivers/dma/idxd/device.c +0 -1
@@ -7,7 +7,6 @@#include <linux/io-64-nonatomic-lo-hi.h> #include <linux/dmaengine.h> #include <linux/irq.h> -#include <linux/msi.h> #include <uapi/linux/idxd.h> #include "../dmaengine.h" #include "idxd.h"
Re: [patch 05/10] dmaengine: idxd: Remove linux/msi.h include
Quoted 1 line · Thomas Gleixner
Nothing in this file needs anything from
linux/msi.h
Applied, thanks
Signature · 1 line
~Vinod
PATCH 6/10 net: dpaa2: Remove linux/msi.h includes
In reply to Thomas GleixnerNothing in these file needs anything from linux/msi.h
--- drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 1 - drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 1 - drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c | 1 - 3 files changed, 3 deletions(-)
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c +0 -1
@@ -8,7 +8,6 @@#include <linux/etherdevice.h> #include <linux/of_net.h> #include <linux/interrupt.h> -#include <linux/msi.h> #include <linux/kthread.h> #include <linux/iommu.h> #include <linux/fsl/mc.h>
drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c +0 -1
@@ -8,7 +8,6 @@#include <linux/module.h> #include <linux/of.h> #include <linux/of_address.h> -#include <linux/msi.h> #include <linux/fsl/mc.h> #include "dpaa2-ptp.h"
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch.c +0 -1
@@ -10,7 +10,6 @@#include <linux/module.h> #include <linux/interrupt.h> -#include <linux/msi.h> #include <linux/kthread.h> #include <linux/workqueue.h> #include <linux/iommu.h>
PATCH 7/10 net: nfp: Remove linux/msi.h includes
In reply to Thomas GleixnerNothing in these files needs anything from linux/msi.h
--- drivers/net/ethernet/netronome/nfp/nfp_main.h | 1 - drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 - drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 1 - 3 files changed, 3 deletions(-)
drivers/net/ethernet/netronome/nfp/nfp_main.h +0 -1
@@ -12,7 +12,6 @@#include <linux/ethtool.h> #include <linux/list.h> #include <linux/types.h> -#include <linux/msi.h> #include <linux/pci.h> #include <linux/workqueue.h> #include <net/devlink.h>
drivers/net/ethernet/netronome/nfp/nfp_net_common.c +0 -1
@@ -27,7 +27,6 @@#include <linux/page_ref.h> #include <linux/pci.h> #include <linux/pci_regs.h> -#include <linux/msi.h> #include <linux/ethtool.h> #include <linux/log2.h> #include <linux/if_vlan.h>
drivers/net/ethernet/netronome/nfp/nfp_net_main.c +0 -1
@@ -16,7 +16,6 @@#include <linux/lockdep.h> #include <linux/pci.h> #include <linux/pci_regs.h> -#include <linux/msi.h> #include <linux/random.h> #include <linux/rtnetlink.h>
Re: [patch 07/10] net: nfp: Remove linux/msi.h includes
Quoted 4 lines · Thomas Gleixner
[Some people who received this message don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
Nothing in these files needs anything from
linux/msi.h
Quoted 8 lines
Signed-off-by Thomas Gleixner <[email protected]>Cc Simon Horman <[email protected]>Cc Jakub Kicinski <[email protected]>Cc "David S. Miller" <[email protected]>Cc Eric Dumazet <[email protected]>Cc Paolo Abeni <[email protected]>
Quoted 37 lines
--- drivers/net/ethernet/netronome/nfp/nfp_main.h | 1 - drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 1 - drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 1 - 3 files changed, 3 deletions(-)drivers/net/ethernet/netronome/nfp/nfp_main.h +0
-1@@ -12,7 +12,6 @@#include <linux/ethtool.h> #include <linux/list.h> #include <linux/types.h> -#include <linux/msi.h> #include <linux/pci.h> #include <linux/workqueue.h> #include <net/devlink.h> drivers/net/ethernet/netronome/nfp/nfp_net_common.c +0
-1@@ -27,7 +27,6 @@#include <linux/page_ref.h> #include <linux/pci.h> #include <linux/pci_regs.h> -#include <linux/msi.h> #include <linux/ethtool.h> #include <linux/log2.h> #include <linux/if_vlan.h> drivers/net/ethernet/netronome/nfp/nfp_net_main.c +0
-1@@ -16,7 +16,6 @@#include <linux/lockdep.h> #include <linux/pci.h> #include <linux/pci_regs.h> -#include <linux/msi.h> #include <linux/random.h> #include <linux/rtnetlink.h>
PATCH 8/10 soc: fsl: dpio: Remove linux/msi.h include
In reply to Thomas GleixnerNothing in this file needs anything from linux/msi.h
--- drivers/soc/fsl/dpio/dpio-driver.c | 1 - 1 file changed, 1 deletion(-)
drivers/soc/fsl/dpio/dpio-driver.c +0 -1
@@ -10,7 +10,6 @@#include <linux/module.h> #include <linux/platform_device.h> #include <linux/interrupt.h> -#include <linux/msi.h> #include <linux/dma-mapping.h> #include <linux/delay.h> #include <linux/io.h>
[tip: irq/core] soc: fsl: dpio: Remove linux/msi.h include
The following commit has been merged into the irq/core branch of tip:
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 20e2e09c0998ef0c325edeb00560a8ff67b35913 Gitweb: https://git.kernel.org/tip/20e2e09c0998ef0c325edeb00560a8ff67b35913 Author: Thomas Gleixner <[email protected]> AuthorDate: Sun, 13 Nov 2022 21:34:07 +01:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Wed, 23 Nov 2022 23:07:37 +01:00
soc: fsl: dpio: Remove linux/msi.h include
Nothing in this file needs anything from linux/msi.h
--- drivers/soc/fsl/dpio/dpio-driver.c | 1 - 1 file changed, 1 deletion(-)
drivers/soc/fsl/dpio/dpio-driver.c +0 -1
@@ -10,7 +10,6 @@#include <linux/module.h> #include <linux/platform_device.h> #include <linux/interrupt.h> -#include <linux/msi.h> #include <linux/dma-mapping.h> #include <linux/delay.h> #include <linux/io.h>
PATCH 9/10 vfio/fsl-mc: Remove linux/msi.h include
In reply to Thomas GleixnerNothing in this file needs anything from linux/msi.h
--- drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 - 1 file changed, 1 deletion(-)
drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c +0 -1
@@ -8,7 +8,6 @@#include <linux/slab.h> #include <linux/types.h> #include <linux/eventfd.h> -#include <linux/msi.h> #include "linux/fsl/mc.h" #include "vfio_fsl_mc_private.h"
Re: [patch 09/10] vfio/fsl-mc: Remove linux/msi.h include
Quoted 10 lines · Thomas Gleixner
Nothing in this file needs anything from
linux/msi.hSigned-off-by Thomas Gleixner <[email protected]>Cc Diana Craciun <[email protected]>Cc Alex Williamson <[email protected]>Cc Cornelia Huck <[email protected]>--- drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 - 1 file changed, 1 deletion(-)
Jason
Re: [patch 09/10] vfio/fsl-mc: Remove linux/msi.h include
In reply to Thomas GleixnerQuoted 15 lines · On Sun, 13 Nov 2022 21:34:08 +0100 (CET) Thomas Gleixner <[email protected]>…
Nothing in this file needs anything from
linux/msi.hSigned-off-by Thomas Gleixner <[email protected]>Cc Diana Craciun <[email protected]>Cc Alex Williamson <[email protected]>Cc Cornelia Huck <[email protected]>--- drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 - 1 file changed, 1 deletion(-)
drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c line 13
Quoted 7 lines
drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c +0
-1@@ -8,7 +8,6 @@#include <linux/slab.h> #include <linux/types.h> #include <linux/eventfd.h> -#include <linux/msi.h> #include "linux/fsl/mc.h" #include "vfio_fsl_mc_private.h"
[tip: irq/core] vfio/fsl-mc: Remove linux/msi.h include
In reply to Thomas GleixnerThe following commit has been merged into the irq/core branch of tip:
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 616eb7bf325fbf25df2b5046536b50fe896d4ab6 Gitweb: https://git.kernel.org/tip/616eb7bf325fbf25df2b5046536b50fe896d4ab6 Author: Thomas Gleixner <[email protected]> AuthorDate: Sun, 13 Nov 2022 21:34:08 +01:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Wed, 23 Nov 2022 23:07:38 +01:00
vfio/fsl-mc: Remove linux/msi.h include
Nothing in this file needs anything from linux/msi.h
--- drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c | 1 - 1 file changed, 1 deletion(-)
drivers/vfio/fsl-mc/vfio_fsl_mc_intr.c +0 -1
@@ -8,7 +8,6 @@#include <linux/slab.h> #include <linux/types.h> #include <linux/eventfd.h> -#include <linux/msi.h> #include "linux/fsl/mc.h" #include "vfio_fsl_mc_private.h"
PATCH 10/10 iommu/of: Remove linux/msi.h include
In reply to Thomas GleixnerNothing in this file needs anything from linux/msi.h
--- drivers/iommu/of_iommu.c | 1 - 1 file changed, 1 deletion(-)
drivers/iommu/of_iommu.c +0 -1
@@ -9,7 +9,6 @@#include <linux/iommu.h> #include <linux/limits.h> #include <linux/module.h> -#include <linux/msi.h> #include <linux/of.h> #include <linux/of_iommu.h> #include <linux/of_pci.h>
Re: [patch 10/10] iommu/of: Remove linux/msi.h include
Quoted 1 line · Thomas Gleixner
Nothing in this file needs anything from
linux/msi.h
Indeed, looks like it was part of a mechanical conversion and never actually needed.
Quoted 20 lines
Signed-off-by Thomas Gleixner <[email protected]>Cc Joerg Roedel <[email protected]>Cc Will Deacon <[email protected]>Cc Robin Murphy <[email protected]>--- drivers/iommu/of_iommu.c | 1 - 1 file changed, 1 deletion(-)drivers/iommu/of_iommu.c +0
-1@@ -9,7 +9,6 @@#include <linux/iommu.h> #include <linux/limits.h> #include <linux/module.h> -#include <linux/msi.h> #include <linux/of.h> #include <linux/of_iommu.h> #include <linux/of_pci.h>
[tip: irq/core] iommu/of: Remove linux/msi.h include
In reply to Thomas GleixnerThe following commit has been merged into the irq/core branch of tip:
The following commit has been merged into the irq/core branch of tip:
Commit-ID: d9dcb63677fcdf0a5a8cd3c138ab174cf1e9b871 Gitweb: https://git.kernel.org/tip/d9dcb63677fcdf0a5a8cd3c138ab174cf1e9b871 Author: Thomas Gleixner <[email protected]> AuthorDate: Sun, 13 Nov 2022 21:34:10 +01:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Wed, 23 Nov 2022 23:07:38 +01:00
iommu/of: Remove linux/msi.h include
Nothing in this file needs anything from linux/msi.h
--- drivers/iommu/of_iommu.c | 1 - 1 file changed, 1 deletion(-)
drivers/iommu/of_iommu.c +0 -1
@@ -9,7 +9,6 @@#include <linux/iommu.h> #include <linux/limits.h> #include <linux/module.h> -#include <linux/msi.h> #include <linux/of.h> #include <linux/of_iommu.h> #include <linux/of_pci.h>
This series was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (master) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Sun, 13 Nov 2022 21:33:54 +0100 (CET) you wrote:
While working on per device MSI domains I noticed that quite some files include
linux/msi.hjust because.The top level comment in the header file clearly says:
Regular device drivers have no business with any of these functions....
[...]
Here is the summary with links:
- [06/10] net: dpaa2: Remove linux/msi.h includes
https://git.kernel.org/netdev/net-next/c/515e5fb6a95e - [07/10] net: nfp: Remove linux/msi.h includes https://git.kernel.org/netdev/net-next/c/5fd66a0b3bb4
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Martin K. Petersen
AppliedQuoted 8 lines · Thomas Gleixner
While working on per device MSI domains I noticed that quite some files include
linux/msi.hjust because.The top level comment in the header file clearly says:
Regular device drivers have no business with any of these functions....
[...]
Applied to 6.2/scsi-queue, thanks!
[03/10] scsi: lpfc: Remove linux/msi.h include
https://git.kernel.org/mkp/scsi/c/cdd9344e00b4
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering