xen/platform-pci: use define instead of literal number
Juergen Gross
maintainerPATCH 1/1 xen/platform-pci: use define instead of literal number
Instead of "0x01" use the HVM_PARAM_CALLBACK_TYPE_PCI_INTX define from the interface header in get_callback_via().
Signed-off-by Juergen Gross <[email protected]>
--- drivers/xen/platform-pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/xen/platform-pci.c +2 -1
@@ -54,7 +54,8 @@ static uint64_t get_callback_via(struct pci_dev *pdev) pin = pdev->pin;/* We don't know the GSI. Specify the PCI INTx line instead. */ -return ((uint64_t )0x01 <<HVM_CALLBACK_VIA_TYPE_SHIFT ) |/* PCI INTx identifier */ +return ((uint64_t )HVM_PARAM_CALLBACK_TYPE_PCI_INTX << +HVM_CALLBACK_VIA_TYPE_SHIFT ) | ((uint64_t )pci_domain_nr (pdev->bus) <<32 ) | ((uint64_t )pdev->bus->number <<16 ) | ((uint64_t)(pdev->devfn & 0xff) << 8) |
Signature · 1 line
2.35.3
Quoted 4 lines · Juergen Gross
Instead of "
0x01" use theHVM_PARAM_CALLBACK_TYPE_PCI_INTXdefine from the interface header inget_callback_via().Signed-off-by Juergen Gross <[email protected]>
Quoted 21 lines
--- drivers/xen/platform-pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/xen/platform-pci.c +2
-1@@ -54,7 +54,8 @@ static uint64_t get_callback_via(struct pci_dev *pdev) pin = pdev->pin;/* We don't know the GSI. Specify the PCI INTx line instead. */ -return ((uint64_t )0x01 <<HVM_CALLBACK_VIA_TYPE_SHIFT ) |/* PCI INTx identifier */ +return ((uint64_t )HVM_PARAM_CALLBACK_TYPE_PCI_INTX << +HVM_CALLBACK_VIA_TYPE_SHIFT ) | ((uint64_t )pci_domain_nr (pdev->bus) <<32 ) | ((uint64_t )pdev->bus->number <<16 ) | ((uint64_t)(pdev->devfn & 0xff) << 8) |Signature · 1 line
2.35.3