Skip to contentSkip to conversation

package/sbc: add config option to control tools build

PATCH Applied John Keeping 2 participants 2 messages Oct 20, 2022 – Nov 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/sbc: add config option to control tools build

libsndfile is only needed by the sbctester utility and the library can be built without this dependency.

Add a config option to cover not just sbctester but the command-line utilities as well. While the utilities may be useful for debugging, normal usage will only need libsbc and these applications can be omitted.

---
v2:
- Fix autocomplete error in select BR2_PACKAGE_LIBSNDFILE

 package/sbc/Config.in | 8 +++++++-
 package/sbc/sbc.mk    | 9 ++++++++-
 2 files changed, 15 insertions(+), 2 deletions(-)
package/sbc/Config.in +7 -1
index f1dbc0ec2c..565e3e6596 100644
@@ -1,8 +1,14 @@
 config BR2_PACKAGE_SBC
 	bool "sbc"
-	select BR2_PACKAGE_LIBSNDFILE
 	help
 	  An audio codec to connect bluetooth high quality audio
 	  devices like headphones or loudspeakers.
 
 	  http://www.bluez.org/
+
+config BR2_PACKAGE_SBC_TOOLS
+	bool "tools"
+	depends on BR2_PACKAGE_SBC
+	select BR2_PACKAGE_LIBSNDFILE
+	help
+	  Build the command-line SBC tools as well as the library.
package/sbc/sbc.mk +8 -1
index 744ce5f895..245ff11ced 100644
@@ -8,8 +8,15 @@ SBC_VERSION = 2.0
 SBC_SOURCE = sbc-$(SBC_VERSION).tar.xz
 SBC_SITE = $(BR2_KERNEL_MIRROR)/linux/bluetooth
 SBC_INSTALL_STAGING = YES
-SBC_DEPENDENCIES = libsndfile host-pkgconf
+SBC_DEPENDENCIES = host-pkgconf
 SBC_LICENSE = GPL-2.0+ (programs), LGPL-2.1+ (library)
 SBC_LICENSE_FILES = COPYING COPYING.LIB
 
+ifeq ($(BR2_PACKAGE_SBC_TOOLS),y)
+SBC_DEPENDENCIES += libsndfile
+SBC_CONF_OPTS += --enable-tools --enable-tester
+else
+SBC_CONF_OPTS += --disable-tools --disable-tester
+endif
+
 $(eval $(autotools-package))
Signature · 6 lines
2.38.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 8 lines · On Thu, 20 Oct 2022 13:15:21 +0100 John Keeping <[email protected]> wrote:

libsndfile is only needed by the sbctester utility and the library can be built without this dependency.

Add a config option to cover not just sbctester but the command-line utilities as well. While the utilities may be useful for debugging, normal usage will only need libsbc and these applications can be omitted.

Quoted 4 lines

---
v2:
- Fix autocomplete error in select BR2_PACKAGE_LIBSNDFILE

I've applied to next after:

- Moving the option inside a if BR2_PACKAGE_SBC..endif block instead of using a depends on BR2_PACKAGE_SBC

- Adjusting SBC_LICENSE so that it only contains LGPL-2.1+ by default, and then has GPL-2.0+ in addition when the tools are built.

Thanks!

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot