mempool: add object usage counts for the telemetry api
PATCH 1/1 mempool: add object usage counts for the telemetry api
rte_mempool_dump() already returns the number of objects available and in the cache. This information is missing from the telemetry API. Add it albeit with less granularity for cached counts (only report the total_cache_count).
--- lib/mempool/rte_mempool.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
lib/mempool/rte_mempool.c +13 -0
@@ -1495,6 +1495,7 @@ mempool_info_cb(struct rte_mempool *mp, void *arg) {struct mempool_info_cb_arg *info = (struct mempool_info_cb_arg *)arg;const struct rte_memzone *mz; +uint64_t cache_count, common_count;if (strncmp (mp->name, info->pool_name,RTE_MEMZONE_NAMESIZE ))return ;
@@ -1513,6 +1514,18 @@ mempool_info_cb(struct rte_mempool *mp, void *arg)rte_tel_data_add_dict_int (info->d,"ops_index" , mp->ops_index);rte_tel_data_add_dict_int (info->d,"populated_size" , mp->populated_size); + cache_count =0 ; +if (mp->cache_size >0 ) { +int lcore_id; +for (lcore_id =0 ; lcore_id <RTE_MAX_LCORE ; lcore_id++) + cache_count += mp->local_cache[lcore_id].len; + } + common_count =rte_mempool_ops_get_count (mp); +if ((cache_count + common_count) > mp->size) + common_count = mp->size - cache_count; + +rte_tel_data_add_dict_u64 (info->d,"total_cache_count" , cache_count); +rte_tel_data_add_dict_u64 (info->d,"common_pool_count" , common_count); mz = mp->mz;rte_tel_data_add_dict_string (info->d,"mz_name" , mz->name);
Signature · 1 line
2.38.1
+CC mempool maintainers
Quoted 11 lines
From: Robin Jarry [mailto:[email protected]]
Sent: Tuesday, 15 November 2022 16.36
rte_mempool_dump()already returns the number of objects available and in the cache. This information is missing from the telemetry API. Add it
albeit with less granularity for cached counts (only report thetotal_cache_count).Signed-off-by Robin Jarry <[email protected]>---
Please consider that the individual per-lcore cache lengths could be informative for some applications too.
Anyway, they could be provided in a later patch.
15/11/2022 17:28, Morten Brørup:
Quoted 11 lines
+CC mempool maintainers
Quoted 9 lines
From: Robin Jarry [mailto:[email protected]]
Sent: Tuesday, 15 November 2022 16.36
rte_mempool_dump()already returns the number of objects available and in the cache. This information is missing from the telemetry API. Add it
albeit with less granularity for cached counts (only report thetotal_cache_count).
Quoted 8 lines
Quoted 2 lines
Signed-off-by Robin Jarry <[email protected]>---
Please consider that the individual per-lcore cache lengths could be informative for some applications too.
Anyway, they could be provided in a later patch.
Acked-by Morten Brørup <[email protected]>
Rebased and applied, thanks.