Skip to contentSkip to conversation

soc: loongson: Fix an IS_ERR() vs NULL bug in loongson2_guts_probe()

PATCH New Peng Wu 1 participant 1 message Nov 16, 2022

Subsystems (2)
lore
Share & tools
lore

Peng Wu

author
#0 lore raw

PATCH 1/1 soc: loongson: Fix an IS_ERR() vs NULL bug in loongson2_guts_probe()

The ioremap() function returns NULL on error, it doesn't return error pointers.

Fixes b82621ac8450 ("soc: loongson: add GUTS driver for loongson-2 platforms")
---
 drivers/soc/loongson/loongson2_guts.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/soc/loongson/loongson2_guts.c +2 -2
index bace4bc8e03b..52c222b1e6ef 100644
@@ -108,8 +108,8 @@ static int loongson2_guts_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	guts->regs = ioremap(res->start, res->end - res->start + 1);
-	if (IS_ERR(guts->regs))
-		return PTR_ERR(guts->regs);
+	if (!guts->regs)
+		return -ENOMEM;
 
 	/* Register soc device */
 	root = of_find_node_by_path("/");
Signature · 1 line
2.17.1