Skip to contentSkip to conversation

infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro

PATCH Applied Maurizio Lombardi 4 participants 4 messages Nov 16, 2022 – Nov 21, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 infiniband: use the ISCSI_LOGIN_CURRENT_STAGE macro

Use the proper macro to get the current_stage value.

---
 drivers/infiniband/ulp/isert/ib_isert.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/infiniband/ulp/isert/ib_isert.c +2 -3
index b360a1527cd1..75404885cf98 100644
@@ -993,9 +993,8 @@ isert_rx_login_req(struct isert_conn *isert_conn)
 		 * login request PDU.
 		 */
 		login->leading_connection = (!login_req->tsih) ? 1 : 0;
-		login->current_stage =
-			(login_req->flags & ISCSI_FLAG_LOGIN_CURRENT_STAGE_MASK)
-			 >> 2;
+		login->current_stage = ISCSI_LOGIN_CURRENT_STAGE(
+				login_req->flags);
 		login->version_min	= login_req->min_version;
 		login->version_max	= login_req->max_version;
 		memcpy(login->isid, login_req->isid, 6);
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Maurizio Lombardi

Use the proper macro to get the current_stage value.

---
 drivers/infiniband/ulp/isert/ib_isert.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/infiniband/ulp/isert/ib_isert.c +0 -0
index b360a1527cd1..75404885cf98 100644
@@ -993,9 +993,8 @@ isert_rx_login_req(struct isert_conn *isert_conn)
 		 * login request PDU.

drivers/infiniband/ulp/isert/ib_isert.c isert_rx_login_req(struct isert_conn *isert_conn) · line 1000

Quoted 10 lines
drivers/infiniband/ulp/isert/ib_isert.c +2 -3
 		 */
 		login->leading_connection = (!login_req->tsih) ? 1 : 0;
-		login->current_stage =
-			(login_req->flags & ISCSI_FLAG_LOGIN_CURRENT_STAGE_MASK)
-			 >> 2;
+		login->current_stage = ISCSI_LOGIN_CURRENT_STAGE(
+				login_req->flags);
 		login->version_min	= login_req->min_version;
 		login->version_max	= login_req->max_version;
 		memcpy(login->isid, login_req->isid, 6);
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Maurizio Lombardi

title prefix should be:
iser-target: use the...

Quoted 13 lines

Use the proper macro to get the current_stage value.

---
  drivers/infiniband/ulp/isert/ib_isert.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)
drivers/infiniband/ulp/isert/ib_isert.c +0 -0
index b360a1527cd1..75404885cf98 100644
@@ -993,9 +993,8 @@ isert_rx_login_req(struct isert_conn *isert_conn)
  		 * login request PDU.

drivers/infiniband/ulp/isert/ib_isert.c isert_rx_login_req(struct isert_conn *isert_conn) · line 1000

Quoted 10 lines
drivers/infiniband/ulp/isert/ib_isert.c +2 -3
  		 */
  		login->leading_connection = (!login_req->tsih) ? 1 : 0;
-		login->current_stage =
-			(login_req->flags & ISCSI_FLAG_LOGIN_CURRENT_STAGE_MASK)
-			 >> 2;
+		login->current_stage = ISCSI_LOGIN_CURRENT_STAGE(
+				login_req->flags);
  		login->version_min	= login_req->min_version;
  		login->version_max	= login_req->max_version;
  		memcpy(login->isid, login_req->isid, 6);