arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation

PATCH Applied Johan Hovold 5 participants 7 messages Nov 16, 2022 – Dec 6, 2022

Subsystems (4)

Device tree bindings Arm Qualcomm mailing list Arm Qualcomm support Voltage and current regulator framework

lore

Share & tools

lore

Johan Hovold

author

2022-11-16 10:22 UTC #0 lore raw

cover arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation

When reviewing a new devicetree for sa8540p-ride I noticed that the indentation for the 'regulator-allowed-modes' properties was off and realised that this had been copied from the recent patches adding the missing modes properties.

Let's clean up the binding example and current devicetree sources to avoid this pattern being reproduced further.

Note that the patches adding the missing properties have not yet made it into 6.1-rc.

Johan

Johan Hovold (2):
regulator: dt-bindings: qcom,rpmh: clean up example indentation
arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation

 .../regulator/qcom,rpmh-regulator.yaml        | 10 ++++------
 arch/arm64/boot/dts/qcom/sa8155p-adp.dts      | 20 ++++++++-----------
 arch/arm64/boot/dts/qcom/sa8295p-adp.dts      | 20 ++++++++-----------
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 10 ++++------
 .../qcom/sm6350-sony-xperia-lena-pdx213.dts   | 10 ++++------
 .../boot/dts/qcom/sm7225-fairphone-fp4.dts    | 10 ++++------
 .../dts/qcom/sm8150-sony-xperia-kumano.dtsi   | 10 ++++------
 .../boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 10 ++++------
 arch/arm64/boot/dts/qcom/sm8350-hdk.dts       | 20 ++++++++-----------
 9 files changed, 48 insertions(+), 72 deletions(-)

Signature · 1 line

2.37.4

Johan Hovold

author

2022-11-16 10:22 UTC #1 lore raw

PATCH 1/2 regulator: dt-bindings: qcom,rpmh: clean up example indentation

Remove a line break and increase indentation of the continuation line to avoid having the 'regulator-allowed-modes' example be reproduced verbatim with four-spaces indentation (instead of a tab, which is still too little) in devicetree sources.

Signed-off-by Johan Hovold <[email protected]>

---
 .../bindings/regulator/qcom,rpmh-regulator.yaml        | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml +4 -6

index 90c3bda31c23..7ff51b558702 100644
@@ -412,9 +412,8 @@ examples:
             regulator-min-microvolt = <1800000>;
             regulator-max-microvolt = <1800000>;
             regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
-            regulator-allowed-modes =
-                <RPMH_REGULATOR_MODE_LPM
-                 RPMH_REGULATOR_MODE_HPM>;
+            regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+                                       RPMH_REGULATOR_MODE_HPM>;
             regulator-allow-set-load;
         };

@@ -431,9 +430,8 @@ examples:
         bob {
             regulator-min-microvolt = <3312000>;
             regulator-max-microvolt = <3600000>;
-            regulator-allowed-modes =
-                <RPMH_REGULATOR_MODE_AUTO
-                 RPMH_REGULATOR_MODE_HPM>;
+            regulator-allowed-modes = <RPMH_REGULATOR_MODE_AUTO
+                                       RPMH_REGULATOR_MODE_HPM>;
             regulator-initial-mode = <RPMH_REGULATOR_MODE_AUTO>;
         };
     };

Signature · 1 line

2.37.4

Krzysztof Kozlowski

Acked-by on v1 1/2

2022-11-16 12:39 UTC #2 lore raw

Re: [PATCH 1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation

Quoted 7 lines · Johan Hovold

Remove a line break and increase indentation of the continuation line to avoid having the 'regulator-allowed-modes' example be reproduced verbatim with four-spaces indentation (instead of a tab, which is still too little) in devicetree sources.
Signed-off-by Johan Hovold <[email protected]>
---

Acked-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Johan Hovold

author

2022-11-16 10:22 UTC #3 lore raw

PATCH 2/2 arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation

In reply to Johan Hovold

When recently adding the missing 'regulator-allowed-modes' properties it appears that the binding example with its four-spaces indentation (corresponding to a single tab, which is still to little) was copied verbatim.

Drop the unnecessary first line break after 'regulator-allowed-modes' properties and indent the single remaining continuation line properly.

Signed-off-by Johan Hovold <[email protected]>

---
 arch/arm64/boot/dts/qcom/sa8155p-adp.dts      | 20 ++++++++-----------
 arch/arm64/boot/dts/qcom/sa8295p-adp.dts      | 20 ++++++++-----------
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 10 ++++------
 .../qcom/sm6350-sony-xperia-lena-pdx213.dts   | 10 ++++------
 .../boot/dts/qcom/sm7225-fairphone-fp4.dts    | 10 ++++------
 .../dts/qcom/sm8150-sony-xperia-kumano.dtsi   | 10 ++++------
 .../boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 10 ++++------
 arch/arm64/boot/dts/qcom/sm8350-hdk.dts       | 20 ++++++++-----------
 8 files changed, 44 insertions(+), 66 deletions(-)

arch/arm64/boot/dts/qcom/sa8155p-adp.dts +8 ~~-12~~

index 01ac460d910e..952acfc04adc 100644
@@ -136,9 +136,8 @@ vreg_l5a_0p88: ldo5 {
 			regulator-max-microvolt = <880000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l7a_1p8: ldo7 {

@@ -154,9 +153,8 @@ vreg_l10a_2p96: ldo10 {
 			regulator-max-microvolt = <2960000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l11a_0p8: ldo11 {

@@ -263,9 +261,8 @@ vreg_l5c_1p2: ldo5 {
 			regulator-max-microvolt = <1200000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l7c_1p8: ldo7 {

@@ -281,9 +278,8 @@ vreg_l8c_1p2: ldo8 {
 			regulator-max-microvolt = <1200000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l10c_3p3: ldo10 {

arch/arm64/boot/dts/qcom/sa8295p-adp.dts +8 ~~-12~~

index 6c29d7d757e0..51805106f542 100644
@@ -90,9 +90,8 @@ vreg_l3c: ldo3 {
 			regulator-max-microvolt = <1200000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l4c: ldo4 {

@@ -108,9 +107,8 @@ vreg_l6c: ldo6 {
 			regulator-max-microvolt = <1200000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l7c: ldo7 {

@@ -126,9 +124,8 @@ vreg_l10c: ldo10 {
 			regulator-max-microvolt = <2504000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l17c: ldo17 {

@@ -137,9 +134,8 @@ vreg_l17c: ldo17 {
 			regulator-max-microvolt = <2504000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 	};

arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +4 -6

index f09810e3d956..551768f97729 100644
@@ -170,9 +170,8 @@ vreg_l7c: ldo7 {
 			regulator-max-microvolt = <2504000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l13c: ldo13 {

@@ -195,9 +194,8 @@ vreg_l3d: ldo3 {
 			regulator-max-microvolt = <1200000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l4d: ldo4 {

arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts +4 -6

index 20f35623d1ef..94f77d376662 100644
@@ -231,9 +231,8 @@ pm6150l_l6: ldo6 {
 			regulator-max-microvolt = <2950000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 
 		};

@@ -254,9 +253,8 @@ pm6150l_l9: ldo9 {
 			regulator-max-microvolt = <2960000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 
 		};

arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts +4 -6

index 1cb14051ab1b..c456e9594ea5 100644
@@ -282,9 +282,8 @@ vreg_l6e: ldo6 {
 			regulator-max-microvolt = <2950000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-				<RPMH_REGULATOR_MODE_LPM
-				 RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l7e: ldo7 {

@@ -304,9 +303,8 @@ vreg_l9e: ldo9 {
 			regulator-max-microvolt = <2960000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-				<RPMH_REGULATOR_MODE_LPM
-				 RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l10e: ldo10 {

arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi +4 -6

index fb6e5a140c9f..c958a8b16730 100644
@@ -348,9 +348,8 @@ vreg_l6c_2p9: ldo6 {
 			regulator-max-microvolt = <2960000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l7c_3p0: ldo7 {

@@ -370,9 +369,8 @@ vreg_l9c_2p9: ldo9 {
 			regulator-max-microvolt = <2960000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l10c_3p3: ldo10 {

arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi +4 -6

index 2a223ed50102..38746f248969 100644
@@ -317,9 +317,8 @@ vreg_l6c_2p9: ldo6 {
 			regulator-max-microvolt = <2960000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l7c_2p85: ldo7 {

@@ -342,9 +341,8 @@ vreg_l9c_2p9: ldo9 {
 			regulator-max-microvolt = <2960000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l10c_3p3: ldo10 {

arch/arm64/boot/dts/qcom/sm8350-hdk.dts +8 ~~-12~~

index 69ae6503c2f6..26a608144886 100644
@@ -107,9 +107,8 @@ vreg_l5b_0p88: ldo5 {
 			regulator-max-microvolt = <888000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l6b_1p2: ldo6 {

@@ -118,9 +117,8 @@ vreg_l6b_1p2: ldo6 {
 			regulator-max-microvolt = <1208000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l7b_2p96: ldo7 {

@@ -129,9 +127,8 @@ vreg_l7b_2p96: ldo7 {
 			regulator-max-microvolt = <2504000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 
 		vreg_l9b_1p2: ldo9 {

@@ -140,9 +137,8 @@ vreg_l9b_1p2: ldo9 {
 			regulator-max-microvolt = <1200000>;
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 		};
 	};

Signature · 1 line

2.37.4

Konrad Dybcio

Reviewed-by on v1 2/2

2022-11-16 10:55 UTC #4 lore raw

Quoted 10 lines · Johan Hovold

When recently adding the missing 'regulator-allowed-modes' properties it appears that the binding example with its four-spaces indentation (corresponding to a single tab, which is still to little) was copied verbatim.
Drop the unnecessary first line break after 'regulator-allowed-modes' properties and indent the single remaining continuation line properly.
Signed-off-by Johan Hovold <[email protected]>
---

Reviewed-by Konrad Dybcio <[email protected]>

Konrad

Quoted 306 lines

  arch/arm64/boot/dts/qcom/sa8155p-adp.dts      | 20 ++++++++-----------
  arch/arm64/boot/dts/qcom/sa8295p-adp.dts      | 20 ++++++++-----------
  arch/arm64/boot/dts/qcom/sc8280xp-crd.dts     | 10 ++++------
  .../qcom/sm6350-sony-xperia-lena-pdx213.dts   | 10 ++++------
  .../boot/dts/qcom/sm7225-fairphone-fp4.dts    | 10 ++++------
  .../dts/qcom/sm8150-sony-xperia-kumano.dtsi   | 10 ++++------
  .../boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 10 ++++------
  arch/arm64/boot/dts/qcom/sm8350-hdk.dts       | 20 ++++++++-----------
  8 files changed, 44 insertions(+), 66 deletions(-)

arch/arm64/boot/dts/qcom/sa8155p-adp.dts +8 ~~-12~~

index 01ac460d910e..952acfc04adc 100644
@@ -136,9 +136,8 @@ vreg_l5a_0p88: ldo5 {
  			regulator-max-microvolt = <880000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l7a_1p8: ldo7 {

@@ -154,9 +153,8 @@ vreg_l10a_2p96: ldo10 {
  			regulator-max-microvolt = <2960000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l11a_0p8: ldo11 {

@@ -263,9 +261,8 @@ vreg_l5c_1p2: ldo5 {
  			regulator-max-microvolt = <1200000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l7c_1p8: ldo7 {

@@ -281,9 +278,8 @@ vreg_l8c_1p2: ldo8 {
  			regulator-max-microvolt = <1200000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l10c_3p3: ldo10 {

arch/arm64/boot/dts/qcom/sa8295p-adp.dts +8 ~~-12~~

index 6c29d7d757e0..51805106f542 100644
@@ -90,9 +90,8 @@ vreg_l3c: ldo3 {
  			regulator-max-microvolt = <1200000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l4c: ldo4 {

@@ -108,9 +107,8 @@ vreg_l6c: ldo6 {
  			regulator-max-microvolt = <1200000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l7c: ldo7 {

@@ -126,9 +124,8 @@ vreg_l10c: ldo10 {
  			regulator-max-microvolt = <2504000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l17c: ldo17 {

@@ -137,9 +134,8 @@ vreg_l17c: ldo17 {
  			regulator-max-microvolt = <2504000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
  	};

arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +4 -6

index f09810e3d956..551768f97729 100644
@@ -170,9 +170,8 @@ vreg_l7c: ldo7 {
  			regulator-max-microvolt = <2504000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l13c: ldo13 {

@@ -195,9 +194,8 @@ vreg_l3d: ldo3 {
  			regulator-max-microvolt = <1200000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l4d: ldo4 {

arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts +4 -6

index 20f35623d1ef..94f77d376662 100644
@@ -231,9 +231,8 @@ pm6150l_l6: ldo6 {
  			regulator-max-microvolt = <2950000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 
  		};

@@ -254,9 +253,8 @@ pm6150l_l9: ldo9 {
  			regulator-max-microvolt = <2960000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
 
  		};

arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts +4 -6

index 1cb14051ab1b..c456e9594ea5 100644
@@ -282,9 +282,8 @@ vreg_l6e: ldo6 {
  			regulator-max-microvolt = <2950000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-				<RPMH_REGULATOR_MODE_LPM
-				 RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l7e: ldo7 {

@@ -304,9 +303,8 @@ vreg_l9e: ldo9 {
  			regulator-max-microvolt = <2960000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-				<RPMH_REGULATOR_MODE_LPM
-				 RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l10e: ldo10 {

arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano.dtsi +4 -6

index fb6e5a140c9f..c958a8b16730 100644
@@ -348,9 +348,8 @@ vreg_l6c_2p9: ldo6 {
  			regulator-max-microvolt = <2960000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l7c_3p0: ldo7 {

@@ -370,9 +369,8 @@ vreg_l9c_2p9: ldo9 {
  			regulator-max-microvolt = <2960000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l10c_3p3: ldo10 {

arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi +4 -6

index 2a223ed50102..38746f248969 100644
@@ -317,9 +317,8 @@ vreg_l6c_2p9: ldo6 {
  			regulator-max-microvolt = <2960000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l7c_2p85: ldo7 {

@@ -342,9 +341,8 @@ vreg_l9c_2p9: ldo9 {
  			regulator-max-microvolt = <2960000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l10c_3p3: ldo10 {

arch/arm64/boot/dts/qcom/sm8350-hdk.dts +8 ~~-12~~

index 69ae6503c2f6..26a608144886 100644
@@ -107,9 +107,8 @@ vreg_l5b_0p88: ldo5 {
  			regulator-max-microvolt = <888000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l6b_1p2: ldo6 {

@@ -118,9 +117,8 @@ vreg_l6b_1p2: ldo6 {
  			regulator-max-microvolt = <1208000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l7b_2p96: ldo7 {

@@ -129,9 +127,8 @@ vreg_l7b_2p96: ldo7 {
  			regulator-max-microvolt = <2504000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
 
  		vreg_l9b_1p2: ldo9 {

@@ -140,9 +137,8 @@ vreg_l9b_1p2: ldo9 {
  			regulator-max-microvolt = <1200000>;
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  			regulator-allow-set-load;
-			regulator-allowed-modes =
-			    <RPMH_REGULATOR_MODE_LPM
-			     RPMH_REGULATOR_MODE_HPM>;
+			regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
+						   RPMH_REGULATOR_MODE_HPM>;
  		};
  	};

Mark Brown

maintainer

2022-11-16 15:01 UTC #5 lore raw

Re: (subset) [PATCH 0/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation

In reply to Johan Hovold

Quoted 9 lines · Johan Hovold

When reviewing a new devicetree for sa8540p-ride I noticed that the indentation for the 'regulator-allowed-modes' properties was off and realised that this had been copied from the recent patches adding the missing modes properties.
Let's clean up the binding example and current devicetree sources to avoid this pattern being reproduced further.
[...]

Applied to

broonie/regulator.git for-next

Thanks!

[1/2] regulator: dt-bindings: qcom,rpmh: clean up example indentation

      commit: b8dfb3bed5524589052dafa0e4d6c4e25ae11544

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Bjorn Andersson

maintainer Applied

2022-12-06 18:20 UTC #6 lore raw

Re: (subset) [PATCH 0/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation

In reply to Johan Hovold

Quoted 9 lines · Johan Hovold

When reviewing a new devicetree for sa8540p-ride I noticed that the indentation for the 'regulator-allowed-modes' properties was off and realised that this had been copied from the recent patches adding the missing modes properties.
Let's clean up the binding example and current devicetree sources to avoid this pattern being reproduced further.
[...]

Applied, thanks!

[2/2] arm64: dts: qcom: clean up 'regulator-allowed-modes' indentation

      commit: 25f08f02f47d0f83f39308359bad06719ad9a55c

Best regards,

Signature · 1 line

Bjorn Andersson <[email protected]>