Skip to contentSkip to conversation

drm/tests: client: Remove extra blank lines

PATCH In review Maxime Ripard 2 participants 5 messages Nov 16, 2022 – Nov 18, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/tests: client: Remove extra blank lines

Some extra blank lines slipped through, remove them.

Fixes 8fc0380f6ba7 ("drm/client: Add some tests for drm_connector_pick_cmdline_mode()")
---
 drivers/gpu/drm/tests/drm_client_modeset_test.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/tests/drm_client_modeset_test.c +0 -2
index 558c098b0384..362a5fbd82f5 100644
@@ -53,7 +53,6 @@ static int drm_client_modeset_test_init(struct kunit *test)
 	drm_connector_helper_add(&priv->connector, &drm_client_modeset_connector_helper_funcs);
 
 	return 0;
-
 }
 
 static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)
@@ -85,7 +84,6 @@ static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)
 	KUNIT_EXPECT_TRUE(test, drm_mode_equal(expected_mode, mode));
 }
 
-
 static struct kunit_case drm_test_pick_cmdline_tests[] = {
 	KUNIT_CASE(drm_test_pick_cmdline_res_1920_1080_60),
 	{}
Signature · 1 line
2.38.1
#1 lore raw

PATCH 2/2 drm/tests: helpers: Add SPDX header

The SPDX header is missing, let's add it and fix the corresponding checkpatch warning.

Fixes 44a3928324e9 ("drm/tests: Add Kunit Helpers")
---
 drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/tests/drm_kunit_helpers.c +2 -0
index eea450de7de8..f1662091f250 100644
@@ -1,3 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0
+
 #include <drm/drm_drv.h>
 #include <drm/drm_managed.h>
 
Signature · 1 line
2.38.1
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] drm/tests: helpers: Add SPDX header

Hi Maxime,

Quoted 6 lines · Maxime Ripard

The SPDX header is missing, let's add it and fix the corresponding checkpatch warning.

Fixes 44a3928324e9 ("drm/tests: Add Kunit Helpers")

Could you add the SPDX-License-Identifier tag on the header file as well? With the SPDX header on both files, this is:

Best Regards,
- Maíra Canal

Quoted 14 lines
---
 drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/tests/drm_kunit_helpers.c +2 -0
index eea450de7de8..f1662091f250 100644
@@ -1,3 +1,5 @@
+// SPDX-License-Identifier: GPL-2.0
+
 #include <drm/drm_drv.h>
 #include <drm/drm_managed.h>
 
#3 lore raw

Re: [PATCH 2/2] drm/tests: helpers: Add SPDX header

Hi Maira,

Quoted 6 lines · Maíra Canal

Hi Maxime,

Quoted 3 lines · Maxime Ripard

The SPDX header is missing, let's add it and fix the corresponding checkpatch warning.

Quoted 8 lines
Quoted 3 lines
Fixes 44a3928324e9 ("drm/tests: Add Kunit Helpers")

Could you add the SPDX-License-Identifier tag on the header file as well? With the SPDX header on both files, this is:

I applied those patches yesterday, with the fix you suggested

Thanks!
Maxime

Reviewed-by on v1 1/2
#4 lore raw
In reply to Maxime Ripard
Quoted 4 lines · Maxime Ripard

Some extra blank lines slipped through, remove them.

Fixes 8fc0380f6ba7 ("drm/client: Add some tests for drm_connector_pick_cmdline_mode()")

Best Regards,
- Maíra Canal

Quoted 24 lines
---
 drivers/gpu/drm/tests/drm_client_modeset_test.c | 2 --
 1 file changed, 2 deletions(-)
drivers/gpu/drm/tests/drm_client_modeset_test.c +0 -2
index 558c098b0384..362a5fbd82f5 100644
@@ -53,7 +53,6 @@ static int drm_client_modeset_test_init(struct kunit *test)
 	drm_connector_helper_add(&priv->connector, &drm_client_modeset_connector_helper_funcs);
 
 	return 0;
-
 }
 
 static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)
@@ -85,7 +84,6 @@ static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)
 	KUNIT_EXPECT_TRUE(test, drm_mode_equal(expected_mode, mode));
 }
 
-
 static struct kunit_case drm_test_pick_cmdline_tests[] = {
 	KUNIT_CASE(drm_test_pick_cmdline_res_1920_1080_60),
 	{}