drm/tests: client: Remove extra blank lines
Subsystems (2)
PATCH 1/2 drm/tests: client: Remove extra blank lines
Some extra blank lines slipped through, remove them.
--- drivers/gpu/drm/tests/drm_client_modeset_test.c | 2 -- 1 file changed, 2 deletions(-)
drivers/gpu/drm/tests/drm_client_modeset_test.c +0 -2
@@ -53,7 +53,6 @@ static int drm_client_modeset_test_init(struct kunit *test)drm_connector_helper_add (&priv->connector, &drm_client_modeset_connector_helper_funcs);return 0 ; - }static void drm_test_pick_cmdline_res_1920_1080_60 (struct kunit *test)
@@ -85,7 +84,6 @@ static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)KUNIT_EXPECT_TRUE (test,drm_mode_equal (expected_mode, mode)); } -static struct kunit_case drm_test_pick_cmdline_tests[] = {KUNIT_CASE (drm_test_pick_cmdline_res_1920_1080_60), {}
Signature · 1 line
2.38.1
PATCH 2/2 drm/tests: helpers: Add SPDX header
The SPDX header is missing, let's add it and fix the corresponding checkpatch warning.
--- drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/tests/drm_kunit_helpers.c +2 -0
@@ -1,3 +1,5 @@ +// SPDX-License-Identifier: GPL-2.0 +#include <drm/drm_drv.h> #include <drm/drm_managed.h>
Signature · 1 line
2.38.1
Re: [PATCH 2/2] drm/tests: helpers: Add SPDX header
Hi Maxime,
Quoted 6 lines · Maxime Ripard
The SPDX header is missing, let's add it and fix the corresponding checkpatch warning.
Suggested-by Maíra Canal <[email protected]>Fixes 44a3928324e9 ("drm/tests: Add Kunit Helpers")Signed-off-by Maxime Ripard <[email protected]>
Could you add the SPDX-License-Identifier tag on the header file as well? With the SPDX header on both files, this is:
Best Regards,
- Maíra Canal
Quoted 14 lines
--- drivers/gpu/drm/tests/drm_kunit_helpers.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/tests/drm_kunit_helpers.c +2
-0@@ -1,3 +1,5 @@ +// SPDX-License-Identifier: GPL-2.0 +#include <drm/drm_drv.h> #include <drm/drm_managed.h>
Re: [PATCH 2/2] drm/tests: helpers: Add SPDX header
Hi Maira,
Quoted 6 lines · Maíra Canal
Hi Maxime,
Quoted 3 lines · Maxime Ripard
The SPDX header is missing, let's add it and fix the corresponding checkpatch warning.
Quoted 8 lines
Quoted 3 lines
Suggested-by Maíra Canal <[email protected]>Fixes 44a3928324e9 ("drm/tests: Add Kunit Helpers")Signed-off-by Maxime Ripard <[email protected]>Could you add the SPDX-License-Identifier tag on the header file as well? With the SPDX header on both files, this is:
Reviewed-by Maíra Canal <[email protected]>
I applied those patches yesterday, with the fix you suggested
Thanks!
Maxime
Quoted 4 lines · Maxime Ripard
Some extra blank lines slipped through, remove them.
Fixes 8fc0380f6ba7 ("drm/client: Add some tests for drm_connector_pick_cmdline_mode()")Signed-off-by Maxime Ripard <[email protected]>
Best Regards,
- Maíra Canal
Quoted 24 lines
--- drivers/gpu/drm/tests/drm_client_modeset_test.c | 2 -- 1 file changed, 2 deletions(-)drivers/gpu/drm/tests/drm_client_modeset_test.c +0
-2@@ -53,7 +53,6 @@ static int drm_client_modeset_test_init(struct kunit *test)drm_connector_helper_add (&priv->connector, &drm_client_modeset_connector_helper_funcs);return 0 ; - }static void drm_test_pick_cmdline_res_1920_1080_60 (struct kunit *test)@@ -85,7 +84,6 @@ static void drm_test_pick_cmdline_res_1920_1080_60(struct kunit *test)KUNIT_EXPECT_TRUE (test,drm_mode_equal (expected_mode, mode)); } -static struct kunit_case drm_test_pick_cmdline_tests[] = {KUNIT_CASE (drm_test_pick_cmdline_res_1920_1080_60), {}