Skip to contentSkip to conversation

speakup: remove usage of non-standard u_char

PATCH In review Yureka Lilian 2 participants 2 messages Nov 17, 2022 Speakup console speech driver

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 speakup: remove usage of non-standard u_char

This code is included in the build tools makemapdata and genmap, and it expects that libc exposes a definition of u_char. But u_char is not defined in either C or POSIX standards, and some systems don't have it. Namely this breaks the build on hosts using musl libc, because musl only exposes u_char if _GNU_SOURCE is defined.

---
Content is unchanged compared to v1, but hopefully the patch is not corrupted this time and I added a cc: stable

---
 drivers/accessibility/speakup/utils.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/accessibility/speakup/utils.h +1 -1
index 4bf2ee8ac246..4ce9a12f7664 100644
@@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
 
 static inline struct st_key *hash_name(char *name)
 {
-	u_char *pn = (u_char *)name;
+	unsigned char *pn = (unsigned char *)name;
 	int hash = 0;
 
 	while (*pn) {
Signature · 1 line
2.38.1
maintainer Reviewed-by on v2 1/1
#1 lore raw

Yureka Lilian, le jeu. 17 nov. 2022 01:12:44 +0100, a ecrit:

Quoted 8 lines

This code is included in the build tools makemapdata and genmap, and it expects that libc exposes a definition of u_char. But u_char is not defined in either C or POSIX standards, and some systems don't have it. Namely this breaks the build on hosts using musl libc, because musl only exposes u_char if _GNU_SOURCE is defined.

thanks!

Quoted 23 lines

---
Content is unchanged compared to v1, but hopefully the patch is not corrupted this time and I added a cc: stable

---
 drivers/accessibility/speakup/utils.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/accessibility/speakup/utils.h +1 -1
index 4bf2ee8ac246..4ce9a12f7664 100644
@@ -54,7 +54,7 @@ static inline int oops(const char *msg, const char *info)
 
 static inline struct st_key *hash_name(char *name)
 {
-	u_char *pn = (u_char *)name;
+	unsigned char *pn = (unsigned char *)name;
 	int hash = 0;
 
 	while (*pn) {
Signature · 1 line
2.38.1
Signature · 4 lines
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.