padata: Fix list iterator in padata_do_serial()
Subsystems (2)
Daniel Jordan
maintainerPATCH 1/1 padata: Fix list iterator in padata_do_serial()
list_for_each_entry_reverse() assumes that the iterated list is nonempty and that every list_head is embedded in the same type, but its use in padata_do_serial() breaks both rules.
This doesn't cause any issues now because padata_priv and padata_list happen to have their list fields at the same offset, but we really shouldn't be relying on that.
--- kernel/padata.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
kernel/padata.c +5 -2
@@ -390,13 +390,16 @@ void padata_do_serial(struct padata_priv *padata)int hashed_cpu =padata_cpu_hash (pd, padata->seq_nr);struct padata_list *reorder =per_cpu_ptr (pd->reorder_list, hashed_cpu);struct padata_priv *cur; +struct list_head *pos;spin_lock (&reorder->lock);/* Sort in ascending order of sequence number. */ -list_for_each_entry_reverse (cur, &reorder->list, list) +list_for_each_prev (pos, &reorder->list) { + cur = list_entry(pos, struct padata_priv, list);if (cur->seq_nr < padata->seq_nr)break ; -list_add (&padata->list, &cur->list); + } +list_add (&padata->list, pos);spin_unlock (&reorder->lock);/*
Signature · 1 line
2.38.1
Herbert Xu
maintainerQuoted 8 lines · Daniel Jordan
list_for_each_entry_reverse()assumes that the iterated list is nonempty and that everylist_headis embedded in the same type, but its use inpadata_do_serial()breaks both rules.This doesn't cause any issues now because
padata_privandpadata_listhappen to have their list fields at the same offset, but we really shouldn't be relying on that.
Quoted 5 lines
Fixes bfde23ce200e ("padata: unbind parallel jobs from specific CPUs")Signed-off-by Daniel Jordan <[email protected]>--- kernel/padata.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt