HID: hid-sensor-custom: set fixed size for custom attributes
Subsystems (3)
PATCH v2 1/1 HID: hid-sensor-custom: set fixed size for custom attributes
This is no bugfix (so no Fixes: tag is necessary) as it is taken care of in hid_sensor_custom_add_attributes().
The motivation for this patch is that:
hid_sensor_custom_field.attr_name and hid_sensor_custom_field.attrs
has the size of HID_CUSTOM_TOTAL_ATTRS and used in same context.
We compare against HID_CUSTOM_TOTAL_ATTRS when
looping through hid_custom_attrs.
We will silent the smatch error:hid_sensor_custom_add_attributes() error: buffer overflow 'hid_custom_attrs' 8 <= 10
--- drivers/hid/hid-sensor-custom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-sensor-custom.c +1 -1
@@ -62,7 +62,7 @@ struct hid_sensor_sample {u32 raw_len; } __packed; -static struct attribute hid_custom_attrs[] = { +static struct attribute hid_custom_attrs[HID_CUSTOM_TOTAL_ATTRS ] = { {.name ="name" , .mode =S_IRUGO }, {.name ="units" , .mode =S_IRUGO }, {.name ="unit-expo" , .mode =S_IRUGO },
Signature · 1 line
2.38.1
Quoted 11 lines · Marcus Folkesson
This is no bugfix (so no Fixes: tag is necessary) as it is taken care of in
hid_sensor_custom_add_attributes().The motivation for this patch is that:
hid_sensor_custom_field.attr_name and hid_sensor_custom_field.attrs
has the size ofHID_CUSTOM_TOTAL_ATTRSand used in same context.We compare against
HID_CUSTOM_TOTAL_ATTRSwhen
looping throughhid_custom_attrs.
Quoted 7 lines
We will silent the smatch error:
hid_sensor_custom_add_attributes()error: buffer overflow 'hid_custom_attrs' 8 <= 10Signed-off-by Marcus Folkesson <[email protected]>Acked-by Jonathan Cameron <[email protected]>---
v2:
- add acked-by tag
Quoted 19 lines
drivers/hid/hid-sensor-custom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hid/hid-sensor-custom.c +1
-1@@ -62,7 +62,7 @@ struct hid_sensor_sample {u32 raw_len; } __packed; -static struct attribute hid_custom_attrs[] = { +static struct attribute hid_custom_attrs[HID_CUSTOM_TOTAL_ATTRS ] = { {.name ="name" , .mode =S_IRUGO }, {.name ="units" , .mode =S_IRUGO }, {.name ="unit-expo" , .mode =S_IRUGO },Signature · 1 line
2.38.1
Quoted 11 lines · Marcus Folkesson
This is no bugfix (so no Fixes: tag is necessary) as it is taken care of in
hid_sensor_custom_add_attributes().The motivation for this patch is that:
hid_sensor_custom_field.attr_name and hid_sensor_custom_field.attrs
has the size ofHID_CUSTOM_TOTAL_ATTRSand used in same context.We compare against
HID_CUSTOM_TOTAL_ATTRSwhen
looping throughhid_custom_attrs.
Quoted 6 lines
We will silent the smatch error:
hid_sensor_custom_add_attributes()error: buffer overflow 'hid_custom_attrs' 8 <= 10Signed-off-by Marcus Folkesson <[email protected]>Acked-by Jonathan Cameron <[email protected]>
Applied to hid.git#for-6.2/sensor. Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs