Skip to contentSkip to conversation

pwm: core: Remove S_IFREG from debugfs_create_file()

PATCH In review Andy Shevchenko 2 participants 2 messages Nov 17, 2022 – Nov 18, 2022 PWM

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 pwm: core: Remove S_IFREG from debugfs_create_file()

The debugfs_create_file() already has a check and adds S_IFREG automatically. Remove unneeded flag.

---
v3: resent as a standalone patch (Uwe)

 drivers/pwm/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/pwm/core.c +1 -2
index 855abd0a776f..8f5cb665940f 100644
@@ -1179,8 +1179,7 @@ DEFINE_SEQ_ATTRIBUTE(pwm_debugfs);
 
 static int __init pwm_debugfs_init(void)
 {
-	debugfs_create_file("pwm", S_IFREG | 0444, NULL, NULL,
-			    &pwm_debugfs_fops);
+	debugfs_create_file("pwm", 0444, NULL, NULL, &pwm_debugfs_fops);
 
 	return 0;
 }
Signature · 1 line
2.35.1
Acked-by on v3 1/1
#1 lore raw

Hello,

Quoted 6 lines · Andy Shevchenko

The debugfs_create_file() already has a check and adds S_IFREG automatically. Remove unneeded flag.

---
v3: resent as a standalone patch (Uwe)

My idea was that Thierry picks v2 from the initial series, my intention wasn't to make you resend it alone. Anyhow:

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |