clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets
PATCH 1/4 clk: imx: imxrt1050: fix IMXRT1050_CLK_LCDIF_APB offsets
Fix IMXRT1050_CLK_LCDIF_APB offsets.
---V1->V2:
* nothing doneV2->V3:
* added commit log and not only subject as suggested by Jesse Taube V3->V4:
* added Fixes: as suggested by Fabio Estevam
--- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/imx/clk-imxrt1050.c +1 -1
@@ -140,7 +140,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev) hws[IMXRT1050_CLK_USDHC1 ] =imx_clk_hw_gate2 ("usdhc1" ,"usdhc1_podf" , ccm_base +0x80 ,2 ); hws[IMXRT1050_CLK_USDHC2 ] =imx_clk_hw_gate2 ("usdhc2" ,"usdhc2_podf" , ccm_base +0x80 ,4 ); hws[IMXRT1050_CLK_LPUART1 ] =imx_clk_hw_gate2 ("lpuart1" ,"lpuart_podf" , ccm_base +0x7c ,24 ); - hws[IMXRT1050_CLK_LCDIF_APB ] =imx_clk_hw_gate2 ("lcdif" ,"lcdif_podf" , ccm_base +0x74 ,10 ); + hws[IMXRT1050_CLK_LCDIF_APB ] =imx_clk_hw_gate2 ("lcdif" ,"lcdif_podf" , ccm_base +0x70 ,28 ); hws[IMXRT1050_CLK_DMA ] =imx_clk_hw_gate ("dma" ,"ipg" , ccm_base +0x7C ,6 ); hws[IMXRT1050_CLK_DMA_MUX ] =imx_clk_hw_gate ("dmamux0" ,"ipg" , ccm_base +0x7C ,7 );imx_check_clk_hws (hws,IMXRT1050_CLK_END );
Signature · 1 line
2.34.1
PATCH 2/4 clk: imx: imxrt1050: add IMXRT1050_CLK_LCDIF_PIX clock gate
Add IMXRT1050_CLK_LCDIF_PIX clock gate.
---V1->V2:
* nothing doneV2->V3:
* added commit log and not only subject as suggested by Jesse Taube
* added Jesse Taube's Acked-by:V3->V4:
* nothing done
--- drivers/clk/imx/clk-imxrt1050.c | 1 + 1 file changed, 1 insertion(+)
drivers/clk/imx/clk-imxrt1050.c +1 -0
@@ -141,6 +141,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev) hws[IMXRT1050_CLK_USDHC2 ] =imx_clk_hw_gate2 ("usdhc2" ,"usdhc2_podf" , ccm_base +0x80 ,4 ); hws[IMXRT1050_CLK_LPUART1 ] =imx_clk_hw_gate2 ("lpuart1" ,"lpuart_podf" , ccm_base +0x7c ,24 ); hws[IMXRT1050_CLK_LCDIF_APB ] =imx_clk_hw_gate2 ("lcdif" ,"lcdif_podf" , ccm_base +0x70 ,28 ); + hws[IMXRT1050_CLK_LCDIF_PIX ] =imx_clk_hw_gate2 ("lcdif_pix" ,"lcdif" , ccm_base +0x74 ,10 ); hws[IMXRT1050_CLK_DMA ] =imx_clk_hw_gate ("dma" ,"ipg" , ccm_base +0x7C ,6 ); hws[IMXRT1050_CLK_DMA_MUX ] =imx_clk_hw_gate ("dmamux0" ,"ipg" , ccm_base +0x7C ,7 );imx_check_clk_hws (hws,IMXRT1050_CLK_END );
Signature · 1 line
2.34.1
PATCH 3/4 ARM: dts: imxrt1050: increase mmc max-frequency property
In reply to Giulio BenettiAccording to i.MXRT1050 Datasheet usdhc supports up to 200Mhz clock so let's increase max-frequency property to 200Mhz.
---V1->V2:
* set max-frequency to 200Mhz instead of removing it as suggested by Bough ChenV2->V3:
* added Jesse Taube's Acked-by:V3->V4:
* nothing done
--- arch/arm/boot/dts/imxrt1050.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imxrt1050.dtsi +1 -1
@@ -93,7 +93,7 @@ usdhc1: mmc@402c0000 { bus-width = <4>; fsl,wp-controller; no-1-8-v; - max-frequency = <4000000>; + max-frequency = <200000000>; fsl,tuning-start-tap = <20>; fsl,tuning-step = <2>; status = "disabled";
Signature · 1 line
2.34.1
PATCH 4/4 ARM: dts: imx: prepend a 0 in the memory address to make it clear it's 32MB
In reply to Giulio BenettiPrepend a 0 in the memory address to make it clear it's 32MB
---V1->V2:
* nothing doneV2->V3:
* added commit log and not only subject as suggested by Jesse Taube
* added Jesse Taube's Acked-by:V3->V4:
* nothing done
--- arch/arm/boot/dts/imxrt1050-evk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imxrt1050-evk.dts +1 -1
@@ -28,7 +28,7 @@ aliases { memory@80000000 { device_type = "memory"; - reg = <0x80000000 0x2000000>; + reg = <0x80000000 0x02000000>; }; panel {
Signature · 1 line
2.34.1
Quoted 5 lines · Giulio Benetti
Fix
IMXRT1050_CLK_LCDIF_APBoffsets.Fixes 7154b046d8f3 ("clk: imx: Add initial support for i.MXRT1050 clock driver")Cc Jesse Taube <[email protected]>Signed-off-by Giulio Benetti <[email protected]>
You dropped the patch version from the subject line.
Other than that:
Quoted 27 lines
---
V1->V2:
* nothing doneV2->V3:
* added commit log and not only subject as suggested by Jesse TaubeV3->V4:
* added Fixes: as suggested by Fabio Estevam--- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/imx/clk-imxrt1050.c +1
-1@@ -140,7 +140,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev) hws[IMXRT1050_CLK_USDHC1 ] =imx_clk_hw_gate2 ("usdhc1" ,"usdhc1_podf" , ccm_base +0x80 ,2 ); hws[IMXRT1050_CLK_USDHC2 ] =imx_clk_hw_gate2 ("usdhc2" ,"usdhc2_podf" , ccm_base +0x80 ,4 ); hws[IMXRT1050_CLK_LPUART1 ] =imx_clk_hw_gate2 ("lpuart1" ,"lpuart_podf" , ccm_base +0x7c ,24 ); - hws[IMXRT1050_CLK_LCDIF_APB ] =imx_clk_hw_gate2 ("lcdif" ,"lcdif_podf" , ccm_base +0x74 ,10 ); + hws[IMXRT1050_CLK_LCDIF_APB ] =imx_clk_hw_gate2 ("lcdif" ,"lcdif_podf" , ccm_base +0x70 ,28 ); hws[IMXRT1050_CLK_DMA ] =imx_clk_hw_gate ("dma" ,"ipg" , ccm_base +0x7C ,6 ); hws[IMXRT1050_CLK_DMA_MUX ] =imx_clk_hw_gate ("dmamux0" ,"ipg" , ccm_base +0x7C ,7 );imx_check_clk_hws (hws,IMXRT1050_CLK_END );Signature · 1 line
2.34.1
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 1 line · Giulio Benetti
....
Please, no HTML formatting. Plain text email only.
So I guess I'll just apply this version then.
Thanks,
Abel
Quoted 4 lines · Abel Vesa
Quoted 1 line · Giulio Benetti
....
Please, no HTML formatting. Plain text email only.
Oh, I was on my mobile, sorry!
Signature · 2 lines
Giulio Benetti CEO/CTO@Benetti Engineering sas
Quoted 4 lines
So I guess I'll just apply this version then.
Thanks,
Abel
Abel Vesa
AppliedQuoted 5 lines · Giulio Benetti
Fix
IMXRT1050_CLK_LCDIF_APBoffsets.Fixes 7154b046d8f3 ("clk: imx: Add initial support for i.MXRT1050 clock driver")Cc Jesse Taube <[email protected]>Signed-off-by Giulio Benetti <[email protected]>
Applied patches #1 and #2. Thanks.
As a suggestion, next time, please send two separate patchsets, since there are two different subsystems involved (and the patches #3 and #4 are not related to #1 and #2).
Quoted 27 lines
---
V1->V2:
* nothing doneV2->V3:
* added commit log and not only subject as suggested by Jesse TaubeV3->V4:
* added Fixes: as suggested by Fabio Estevam--- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/imx/clk-imxrt1050.c +1
-1@@ -140,7 +140,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev) hws[IMXRT1050_CLK_USDHC1 ] =imx_clk_hw_gate2 ("usdhc1" ,"usdhc1_podf" , ccm_base +0x80 ,2 ); hws[IMXRT1050_CLK_USDHC2 ] =imx_clk_hw_gate2 ("usdhc2" ,"usdhc2_podf" , ccm_base +0x80 ,4 ); hws[IMXRT1050_CLK_LPUART1 ] =imx_clk_hw_gate2 ("lpuart1" ,"lpuart_podf" , ccm_base +0x7c ,24 ); - hws[IMXRT1050_CLK_LCDIF_APB ] =imx_clk_hw_gate2 ("lcdif" ,"lcdif_podf" , ccm_base +0x74 ,10 ); + hws[IMXRT1050_CLK_LCDIF_APB ] =imx_clk_hw_gate2 ("lcdif" ,"lcdif_podf" , ccm_base +0x70 ,28 ); hws[IMXRT1050_CLK_DMA ] =imx_clk_hw_gate ("dma" ,"ipg" , ccm_base +0x7C ,6 ); hws[IMXRT1050_CLK_DMA_MUX ] =imx_clk_hw_gate ("dmamux0" ,"ipg" , ccm_base +0x7C ,7 );imx_check_clk_hws (hws,IMXRT1050_CLK_END );Signature · 1 line
2.34.1
Quoted 7 lines · Abel Vesa
Quoted 5 lines · Giulio Benetti
Fix
IMXRT1050_CLK_LCDIF_APBoffsets.Fixes 7154b046d8f3 ("clk: imx: Add initial support for i.MXRT1050 clock driver")Cc Jesse Taube <[email protected]>Signed-off-by Giulio Benetti <[email protected]>
Quoted 5 lines
Applied patches #1 and #2. Thanks.
As a suggestion, next time, please send two separate patchsets, since there are two different subsystems involved (and the patches #3 and #4 are not related to #1 and #2).
Ok, thank you for pointing. Next time I will do like that.
Signature · 2 lines
Giulio Benetti CEO/CTO@Benetti Engineering sas
Quoted 27 lines
Quoted 27 lines
---
V1->V2:
* nothing doneV2->V3:
* added commit log and not only subject as suggested by Jesse TaubeV3->V4:
* added Fixes: as suggested by Fabio Estevam--- drivers/clk/imx/clk-imxrt1050.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/clk/imx/clk-imxrt1050.c +1
-1@@ -140,7 +140,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev) hws[IMXRT1050_CLK_USDHC1 ] =imx_clk_hw_gate2 ("usdhc1" ,"usdhc1_podf" , ccm_base +0x80 ,2 ); hws[IMXRT1050_CLK_USDHC2 ] =imx_clk_hw_gate2 ("usdhc2" ,"usdhc2_podf" , ccm_base +0x80 ,4 ); hws[IMXRT1050_CLK_LPUART1 ] =imx_clk_hw_gate2 ("lpuart1" ,"lpuart_podf" , ccm_base +0x7c ,24 ); - hws[IMXRT1050_CLK_LCDIF_APB ] =imx_clk_hw_gate2 ("lcdif" ,"lcdif_podf" , ccm_base +0x74 ,10 ); + hws[IMXRT1050_CLK_LCDIF_APB ] =imx_clk_hw_gate2 ("lcdif" ,"lcdif_podf" , ccm_base +0x70 ,28 ); hws[IMXRT1050_CLK_DMA ] =imx_clk_hw_gate ("dma" ,"ipg" , ccm_base +0x7C ,6 ); hws[IMXRT1050_CLK_DMA_MUX ] =imx_clk_hw_gate ("dmamux0" ,"ipg" , ccm_base +0x7C ,7 );imx_check_clk_hws (hws,IMXRT1050_CLK_END );Signature · 1 line
2.34.1