Skip to contentSkip to conversation

pmbus core: Add power good support

PATCH Applied Naresh Solanki 2 participants 2 messages Nov 17, 2022 – Nov 20, 2022 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pmbus core: Add power good support

From: Patrick Rudolph <[email protected]>

Update error flags with regulation out if regulator is on & power good status bit is set

---
 drivers/hwmon/pmbus/pmbus_core.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/hwmon/pmbus/pmbus_core.c +6 -2
index 7ec04934747e..20ca26e19db7 100644
@@ -2827,9 +2827,13 @@ static int pmbus_regulator_get_error_flags(struct regulator_dev *rdev, unsigned
 	if (status < 0)
 		return status;
 
-	if (pmbus_regulator_is_enabled(rdev) && (status & PB_STATUS_OFF))
-		*flags |= REGULATOR_ERROR_FAIL;
+	if (pmbus_regulator_is_enabled(rdev)) {
+		if (status & PB_STATUS_OFF)
+			*flags |= REGULATOR_ERROR_FAIL;
 
+		if (status & PB_STATUS_POWER_GOOD_N)
+			*flags |= REGULATOR_ERROR_REGULATION_OUT;
+	}
 	/*
 	 * Unlike most other status bits, PB_STATUS_{IOUT_OC,VOUT_OV} are
 	 * defined strictly as fault indicators (not warnings).

base-commit: 27fea302952d8c90cafbdbee96bafeca03544401

Signature · 1 line
2.37.3