dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL
Subsystems (2)
PATCH v3 1/1 dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL
When the k3 socinfo driver is built as a module, there is a possibility that it will probe after the k3 udma driver and the later returns -ENODEV. By deferring the k3 udma probe we allow the k3 socinfo to probe and register the soc_device_attribute structure needed by the k3 udma driver. Removed the dev_err() message as well as it's deferring and not failing.
---v1->v2:
Extracted this patch from the following series:
https://lore.kernel.org/all/[email protected]/
v2->v3:
Removed the dev_err() message
drivers/dma/ti/k3-udma.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/dma/ti/k3-udma.c +4 -4
@@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev) ud->match_data = match->data; soc =soc_device_match (k3_soc_devices); -if (!soc) { -dev_err (dev,"No compatible SoC found\n" ); -return -ENODEV ; - } + +if (!soc) +return -EPROBE_DEFER ; + ud->soc_data = soc->data; ret =udma_get_mmrs (pdev, ud);
Signature · 1 line
2.25.1
Quoted 7 lines · Nicolas Frayer
When the k3 socinfo driver is built as a module, there is a possibility that it will probe after the k3 udma driver and the later returns
-ENODEV. By deferring the k3 udma probe we allow the k3 socinfo to probe and register thesoc_device_attributestructure needed by the k3 udma driver. Removed thedev_err()message as well as it's deferring and not failing.Signed-off-by Nicolas Frayer <[email protected]>
Vinod Koul
maintainerQuoted 5 lines · Nicolas Frayer
When the k3 socinfo driver is built as a module, there is a possibility that it will probe after the k3 udma driver and the later returns
-ENODEV. By deferring the k3 udma probe we allow the k3 socinfo to probe and register thesoc_device_attributestructure needed by the k3 udma driver. Removed thedev_err()message as well as it's deferring and not failing.
lgtm, but need rebase as I already picked commit 3f58e10615f3 dmaengine: ti:
k3-udma: Add support for BCDMA CSI RX
Quoted 34 lines
Signed-off-by Nicolas Frayer <[email protected]>---
v1->v2:
Extracted this patch from the following series:
https://lore.kernel.org/all/[email protected]/
v2->v3:
Removed thedev_err()messagedrivers/dma/ti/k3-udma.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/dma/ti/k3-udma.c +4
-4@@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev) ud->match_data = match->data; soc =soc_device_match (k3_soc_devices); -if (!soc) { -dev_err (dev,"No compatible SoC found\n" ); -return -ENODEV ; - } + +if (!soc) +return -EPROBE_DEFER ; + ud->soc_data = soc->data; ret =udma_get_mmrs (pdev, ud);Signature · 1 line
2.25.1
Signature · 1 line
~Vinod
Quoted 9 lines · Vinod Koul
Quoted 5 lines · Nicolas Frayer
When the k3 socinfo driver is built as a module, there is a possibility that it will probe after the k3 udma driver and the later returns
-ENODEV. By deferring the k3 udma probe we allow the k3 socinfo to probe and register thesoc_device_attributestructure needed by the k3 udma driver. Removed thedev_err()message as well as it's deferring and not failing.lgtm, but need rebase as I already picked commit
3f58e10615f3dmaengine: ti:
k3-udma: Add support for BCDMA CSI RX
Is this path needed at all? afaik the k3 socinfo is not going to be module built.
Quoted 36 lines
Quoted 35 lines
Signed-off-by Nicolas Frayer <[email protected]>---
v1->v2:
Extracted this patch from the following series:
https://lore.kernel.org/all/[email protected]/
v2->v3:
Removed thedev_err()messagedrivers/dma/ti/k3-udma.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/dma/ti/k3-udma.c +4
-4@@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev) ud->match_data = match->data; soc =soc_device_match (k3_soc_devices); -if (!soc) { -dev_err (dev,"No compatible SoC found\n" ); -return -ENODEV ; - } + +if (!soc) +return -EPROBE_DEFER ; + ud->soc_data = soc->data; ret =udma_get_mmrs (pdev, ud);Signature · 1 line
2.25.1
Signature · 1 line
Péter
Quoted 49 lines · Péter Ujfalusi
Quoted 9 lines · Vinod Koul
Quoted 5 lines · Nicolas Frayer
When the k3 socinfo driver is built as a module, there is a possibility that it will probe after the k3 udma driver and the later returns
-ENODEV. By deferring the k3 udma probe we allow the k3 socinfo to probe and register thesoc_device_attributestructure needed by the k3 udma driver. Removed thedev_err()message as well as it's deferring and not failing.lgtm, but need rebase as I already picked commit
3f58e10615f3dmaengine: ti:
k3-udma: Add support for BCDMA CSI RXIs this path needed at all? afaik the k3 socinfo is not going to be module built.
Quoted 32 lines
Quoted 32 lines
Signed-off-by Nicolas Frayer <[email protected]>---
v1->v2:
Extracted this patch from the following series:
https://lore.kernel.org/all/[email protected]/
v2->v3:
Removed thedev_err()messagedrivers/dma/ti/k3-udma.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/dma/ti/k3-udma.c +4
-4@@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev) ud->match_data = match->data; soc =soc_device_match (k3_soc_devices); -if (!soc) { -dev_err (dev,"No compatible SoC found\n" ); -return -ENODEV ; - } + +if (!soc) +return -EPROBE_DEFER ; + ud->soc_data = soc->data;
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
drivers/dma/ti/k3-udma.c +0
-1ret =udma_get_mmrs (pdev, ud); --2.25.1
--
Péter
Hi Vinod, Péter,
This patch needs to be dropped as the k3 socinfo patch has been dropped.
Thanks,
Nicolas