Skip to contentSkip to conversation

dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL

PATCH In review Nicolas Frayer 4 participants 5 messages Nov 17, 2022 – Dec 29, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 dmaengine: ti: k3-udma: Deferring probe when soc_device_match() returns NULL

When the k3 socinfo driver is built as a module, there is a possibility that it will probe after the k3 udma driver and the later returns -ENODEV. By deferring the k3 udma probe we allow the k3 socinfo to probe and register the soc_device_attribute structure needed by the k3 udma driver. Removed the dev_err() message as well as it's deferring and not failing.

---
v1->v2:
Extracted this patch from the following series:
https://lore.kernel.org/all/[email protected]/

v2->v3:
Removed the dev_err() message

 drivers/dma/ti/k3-udma.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/dma/ti/k3-udma.c +4 -4
index ce8b80bb34d7..ca1512eb9910 100644
@@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev)
 	ud->match_data = match->data;
 
 	soc = soc_device_match(k3_soc_devices);
-	if (!soc) {
-		dev_err(dev, "No compatible SoC found\n");
-		return -ENODEV;
-	}
+
+	if (!soc)
+		return -EPROBE_DEFER;
+
 	ud->soc_data = soc->data;
 
 	ret = udma_get_mmrs(pdev, ud);
Signature · 1 line
2.25.1
Reviewed-by on v3 1/1
#1 lore raw
Quoted 7 lines · Nicolas Frayer

When the k3 socinfo driver is built as a module, there is a possibility that it will probe after the k3 udma driver and the later returns -ENODEV. By deferring the k3 udma probe we allow the k3 socinfo to probe and register the soc_device_attribute structure needed by the k3 udma driver. Removed the dev_err() message as well as it's deferring and not failing.

maintainer
#2 lore raw
In reply to Nicolas Frayer
Quoted 5 lines · Nicolas Frayer

When the k3 socinfo driver is built as a module, there is a possibility that it will probe after the k3 udma driver and the later returns -ENODEV. By deferring the k3 udma probe we allow the k3 socinfo to probe and register the soc_device_attribute structure needed by the k3 udma driver. Removed the dev_err() message as well as it's deferring and not failing.

lgtm, but need rebase as I already picked commit 3f58e10615f3 dmaengine: ti:
k3-udma: Add support for BCDMA CSI RX

Quoted 34 lines

---
v1->v2:
Extracted this patch from the following series:
https://lore.kernel.org/all/[email protected]/

v2->v3:
Removed the dev_err() message

 drivers/dma/ti/k3-udma.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/dma/ti/k3-udma.c +4 -4
index ce8b80bb34d7..ca1512eb9910 100644
@@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev)
 	ud->match_data = match->data;
 
 	soc = soc_device_match(k3_soc_devices);
-	if (!soc) {
-		dev_err(dev, "No compatible SoC found\n");
-		return -ENODEV;
-	}
+
+	if (!soc)
+		return -EPROBE_DEFER;
+
 	ud->soc_data = soc->data;
 
 	ret = udma_get_mmrs(pdev, ud);
Signature · 1 line
2.25.1
Signature · 1 line
~Vinod
#3 lore raw
Quoted 9 lines · Vinod Koul
Quoted 5 lines · Nicolas Frayer

When the k3 socinfo driver is built as a module, there is a possibility that it will probe after the k3 udma driver and the later returns -ENODEV. By deferring the k3 udma probe we allow the k3 socinfo to probe and register the soc_device_attribute structure needed by the k3 udma driver. Removed the dev_err() message as well as it's deferring and not failing.

lgtm, but need rebase as I already picked commit 3f58e10615f3 dmaengine: ti:
k3-udma: Add support for BCDMA CSI RX

Is this path needed at all? afaik the k3 socinfo is not going to be module built.

Quoted 36 lines
Quoted 35 lines

---
v1->v2:
Extracted this patch from the following series:
https://lore.kernel.org/all/[email protected]/

v2->v3:
Removed the dev_err() message

  drivers/dma/ti/k3-udma.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/dma/ti/k3-udma.c +4 -4
index ce8b80bb34d7..ca1512eb9910 100644
@@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev)
  	ud->match_data = match->data;
 
  	soc = soc_device_match(k3_soc_devices);
-	if (!soc) {
-		dev_err(dev, "No compatible SoC found\n");
-		return -ENODEV;
-	}
+
+	if (!soc)
+		return -EPROBE_DEFER;
+
  	ud->soc_data = soc->data;
 
  	ret = udma_get_mmrs(pdev, ud);
Signature · 1 line
2.25.1
Signature · 1 line
Péter
#4 lore raw
Quoted 49 lines · Péter Ujfalusi
Quoted 9 lines · Vinod Koul
Quoted 5 lines · Nicolas Frayer

When the k3 socinfo driver is built as a module, there is a possibility that it will probe after the k3 udma driver and the later returns -ENODEV. By deferring the k3 udma probe we allow the k3 socinfo to probe and register the soc_device_attribute structure needed by the k3 udma driver. Removed the dev_err() message as well as it's deferring and not failing.

lgtm, but need rebase as I already picked commit 3f58e10615f3 dmaengine: ti:
k3-udma: Add support for BCDMA CSI RX

Is this path needed at all? afaik the k3 socinfo is not going to be module built.

Quoted 32 lines
Quoted 32 lines

---
v1->v2:
Extracted this patch from the following series:
https://lore.kernel.org/all/[email protected]/

v2->v3:
Removed the dev_err() message

  drivers/dma/ti/k3-udma.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/dma/ti/k3-udma.c +4 -4
index ce8b80bb34d7..ca1512eb9910 100644
@@ -5271,10 +5271,10 @@ static int udma_probe(struct platform_device *pdev)
     ud->match_data = match->data;
 
     soc = soc_device_match(k3_soc_devices);
-    if (!soc) {
-            dev_err(dev, "No compatible SoC found\n");
-            return -ENODEV;
-    }
+
+    if (!soc)
+            return -EPROBE_DEFER;
+
     ud->soc_data = soc->data;
 
Quoted 7 lines
Quoted 4 lines
Quoted 3 lines
drivers/dma/ti/k3-udma.c +0 -1
     ret = udma_get_mmrs(pdev, ud);
--

2.25.1

--
Péter

Hi Vinod, Péter,

This patch needs to be dropped as the k3 socinfo patch has been dropped.

Thanks,
Nicolas