Skip to contentSkip to conversation

tools/intel_gtt: stop confusing GTT and BAR sizes

PATCH In review Daniil Tatianin 3 participants 7 messages Nov 17, 2022 – Nov 29, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/intel_gtt: stop confusing GTT and BAR sizes

The GTT iteration loop would erroneously check "< gtt_size" as an indicator for when it should stop, which would make it exit the loop right after dumping 2-8 mib of address space depending on the GPU generation.

Calculate the actual size of GTT in 'gtt_max_addr', and rewrite the iteration loop to use it. While at it, also make virtual addresses 64-bit so that they don't wrap around at the 4GiB mark.

---
 tools/intel_gtt.c | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)
tools/intel_gtt.c +18 -14
index 311694ba..c0f3d16a 100644
@@ -96,6 +96,11 @@ static uint64_t get_phys(uint32_t pt_offset)
 	return (phys | pae) & ~0xfff;
 }
 
+static int get_pte_size(void)
+{
+	return intel_gen(devid) < 8 ? 4 : 8;
+}
+
 static void pte_dump(int size, uint32_t offset) {
 	int pte_size;
 	int entries;
@@ -105,11 +110,7 @@ static void pte_dump(int size, uint32_t offset) {
 	if (size % 16)
 		size = (size + 16) & ~0xffff;
 
-	if (intel_gen(devid) < 8)
-		pte_size = 4;
-	else
-		pte_size = 8;
-
+	pte_size = get_pte_size();
 	entries = size / pte_size;
 
 	printf("GTT offset   |                 %d PTEs (%d MB)\n", entries,
@@ -139,7 +140,8 @@ static void pte_dump(int size, uint32_t offset) {
 int main(int argc, char **argv)
 {
 	struct pci_device *pci_dev;
-	unsigned int start, gtt_size;
+	unsigned gtt_size;
+	uint64_t start, gtt_max_addr;
 	int flag[] = {
 		PCI_DEV_MAP_FLAG_WRITE_COMBINE,
 		PCI_DEV_MAP_FLAG_WRITABLE,
@@ -190,14 +192,15 @@ int main(int argc, char **argv)
 		return 0;
 	}
 
-	for (start = 0; start < gtt_size; start += KB(4)) {
-		uint64_t start_phys = get_phys(start);
-		uint32_t end;
+	gtt_max_addr = (gtt_size / get_pte_size()) * KB(4ull);
+
+	for (start = 0; start < gtt_max_addr; start += KB(4)) {
+		uint64_t end, start_phys = get_phys(start);
 		int constant_length = 0;
 		int linear_length = 0;
 
 		/* Check if it's a linear sequence */
-		for (end = start + KB(4); end < gtt_size; end += KB(4)) {
+		for (end = start + KB(4); end < gtt_max_addr; end += KB(4)) {
 			uint64_t end_phys = get_phys(end);
 			if (end_phys == start_phys + (end - start))
 				linear_length++;
@@ -205,7 +208,7 @@ int main(int argc, char **argv)
 				break;
 		}
 		if (linear_length > 0) {
-			printf("0x%08x - 0x%08x: linear from "
+			printf("0x%08" PRIx64 "- 0x%08" PRIx64 ": linear from "
 			       "0x%" PRIx64 " to 0x%" PRIx64 "\n",
 			       start, end - KB(4),
 			       start_phys, start_phys + (end - start) - KB(4));
@@ -214,7 +217,7 @@ int main(int argc, char **argv)
 		}
 
 		/* Check if it's a constant sequence */
-		for (end = start + KB(4); end < gtt_size; end += KB(4)) {
+		for (end = start + KB(4); end < gtt_max_addr; end += KB(4)) {
 			uint64_t end_phys = get_phys(end);
 			if (end_phys == start_phys)
 				constant_length++;
@@ -222,13 +225,14 @@ int main(int argc, char **argv)
 				break;
 		}
 		if (constant_length > 0) {
-			printf("0x%08x - 0x%08x: constant 0x%" PRIx64 "\n",
+			printf("0x%08" PRIx64 " - 0x%08" PRIx64
+				": constant 0x%" PRIx64 "\n",
 			       start, end - KB(4), start_phys);
 			start = end - KB(4);
 			continue;
 		}
 
-		printf("0x%08x: 0x%" PRIx64 "\n", start, start_phys);
+		printf("0x%08" PRIx64 ": 0x%" PRIx64 "\n", start, start_phys);
 	}
 
 	return 0;

--
2.36.1.windows.1

#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tools/intel_gtt: stop confusing GTT and BAR sizes

== Series Details ==

== Series Details ==

Series: tools/intel_gtt: stop confusing GTT and BAR sizes
URL : https://patchwork.freedesktop.org/series/111058/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12398 -> IGTPW_8128
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/index.html

Participating hosts (41 -> 37)
------------------------------

Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-bdw-samus bat-dg1-6

Known issues
------------

Here are the changes found in IGTPW_8128 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_lmem_swapping@basic:
- fi-apl-guc: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613]) +3 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/fi-apl-guc/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [PASS][2] -> [INCOMPLETE][3] ([i915#4983])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-apl-guc: NOTRUN -> [SKIP][4] ([fdo#109271] / [fdo#111827])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/fi-apl-guc/igt@[email protected]

#### Possible fixes ####

* igt@core_hotunplug@unbind-rebind:
- fi-apl-guc: [INCOMPLETE][5] ([i915#7073]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/fi-apl-guc/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/fi-apl-guc/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][7] ([i915#6298]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7073]: https://gitlab.freedesktop.org/drm/intel/issues/7073
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7068 -> IGTPW_8128

CI-20190529: 20190529
CI_DRM_12398: 6ff9396457d55a1915566b11121e8fe6f9068b1c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8128: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/index.html
IGT_7068: 5c0ec905b6bbecfb8df8b8f3315d0470539e6ae3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/index.html

#2 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tools/intel_gtt: stop confusing GTT and BAR sizes

In reply to Daniil Tatianin
== Series Details ==

== Series Details ==

Series: tools/intel_gtt: stop confusing GTT and BAR sizes
URL : https://patchwork.freedesktop.org/series/111058/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_12398_full -> IGTPW_8128_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/index.html

Participating hosts (9 -> 8)
------------------------------

Additional (2): shard-rkl shard-dg1
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_8128_full:

### IGT changes ###

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* {igt@i915_pm_backlight@fade-with-suspend}:
- {shard-rkl}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-rkl-5/igt@[email protected]
- {shard-dg1}: NOTRUN -> [SKIP][2] +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-dg1-17/igt@[email protected]

* igt@kms_cursor_legacy@torture-move@all-pipes:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-rkl-5/igt@kms_cursor_legacy@[email protected]

Known issues
------------

Here are the changes found in IGTPW_8128_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ccs@block-copy-inplace:
- shard-tglb: NOTRUN -> [SKIP][4] ([i915#3555] / [i915#5325])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb5/igt@[email protected]

* igt@gem_ctx_persistence@hostile:
- shard-snb: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1099])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-snb2/igt@[email protected]

* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: NOTRUN -> [FAIL][6] ([i915#2410])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb3/igt@[email protected]

* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#4525])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb5/igt@[email protected]

* igt@gem_exec_capture@capture-invisible@smem0:
- shard-iclb: NOTRUN -> [SKIP][9] ([i915#6334])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb1/igt@gem_exec_capture@[email protected]
- shard-tglb: NOTRUN -> [SKIP][10] ([i915#6334])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb7/igt@gem_exec_capture@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-tglb6/igt@gem_exec_fair@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-glk: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-glk3/igt@gem_exec_fair@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk1/igt@gem_exec_fair@[email protected]

* igt@gem_lmem_swapping@parallel-random:
- shard-tglb: NOTRUN -> [SKIP][15] ([i915#4613]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb6/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- shard-iclb: NOTRUN -> [SKIP][16] ([i915#4613])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb1/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4613])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl8/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4613])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk5/igt@[email protected]

* igt@gem_pxp@create-protected-buffer:
- shard-iclb: NOTRUN -> [SKIP][19] ([i915#4270])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb5/igt@[email protected]

* igt@gem_pxp@protected-encrypted-src-copy-not-readible:
- shard-tglb: NOTRUN -> [SKIP][20] ([i915#4270]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb3/igt@[email protected]

* igt@gem_render_copy@yf-tiled-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][21] ([i915#768])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb8/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-tglb: NOTRUN -> [SKIP][22] ([i915#3297])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][23] ([i915#3297])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb5/igt@[email protected]

* igt@gen3_mixed_blits:
- shard-tglb: NOTRUN -> [SKIP][24] ([fdo#109289])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb7/igt@gen3_mixed_blits.html

* igt@gen9_exec_parse@shadow-peek:
- shard-tglb: NOTRUN -> [SKIP][25] ([i915#2527] / [i915#2856]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][26] ([i915#2856])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb1/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][27] -> [SKIP][28] ([fdo#109271])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-apl3/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl1/igt@[email protected]

* igt@i915_pm_rpm@system-suspend-devices:
- shard-snb: NOTRUN -> [SKIP][29] ([fdo#109271]) +125 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-snb4/igt@[email protected]

* igt@i915_pm_rps@engine-order:
- shard-apl: NOTRUN -> [FAIL][30] ([i915#6537])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl3/igt@[email protected]

* igt@i915_query@test-query-geometry-subslices:
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#5723])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb8/igt@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [PASS][32] -> [DMESG-FAIL][33] ([i915#5334])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-apl7/igt@i915_selftest@live@gt_heartbeat.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl3/igt@i915_selftest@live@gt_heartbeat.html

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][34] ([i915#5286]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#5286]) +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb6/igt@[email protected]

* igt@kms_big_fb@linear-8bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#111614])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#110725] / [fdo#111614])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb5/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#111615]) +4 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb7/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#110723])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb6/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html

* igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][40] ([i915#6095]) +4 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb7/igt@kms_ccs@pipe-a-bad-pixel-format-4_tiled_dg2_mc_ccs.html

* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109278] / [i915#3886]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb7/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][42] ([i915#3689] / [i915#3886])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb3/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs:
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271]) +80 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl1/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs.html
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#3689] / [i915#6095]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs.html

* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109278]) +13 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-4_tiled_dg2_mc_ccs.html

* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3886]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl7/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
- shard-glk: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3886]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk8/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-d-crc-sprite-planes-basic-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#111615] / [i915#3689]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb3/igt@kms_ccs@pipe-d-crc-sprite-planes-basic-yf_tiled_ccs.html

* igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#3689]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb3/igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium@dp-hpd-for-each-pipe:
- shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk2/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-tglb: NOTRUN -> [SKIP][51] ([fdo#109284] / [fdo#111827]) +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109284] / [fdo#111827]) +3 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb8/igt@[email protected]

* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl7/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-snb5/igt@[email protected]

* igt@kms_content_protection@srm:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#7118])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb7/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb@atomic:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#109274]) +11 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb5/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb@varying-size:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#109274] / [fdo#111825]) +5 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb8/igt@kms_cursor_legacy@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [PASS][58] -> [FAIL][59] ([i915#2346]) +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-glk5/igt@kms_cursor_legacy@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk2/igt@kms_cursor_legacy@[email protected]

* igt@kms_display_modes@extended-mode-basic:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109274])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb2/igt@[email protected]

* igt@kms_dsc@dsc-with-bpc:
- shard-iclb: NOTRUN -> [SKIP][61] ([i915#3840])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb1/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#109274] / [fdo#111825] / [i915#3637]) +6 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb2/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a2:
- shard-glk: [PASS][63] -> [FAIL][64] ([i915#79]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-glk8/igt@kms_flip@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk2/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][65] -> [DMESG-WARN][66] ([i915#180])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-apl6/igt@kms_flip@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl8/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][67] -> [SKIP][68] ([i915#3555])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][69] ([i915#6375])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][70] ([i915#2587] / [i915#2672]) +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][71] ([i915#2672]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-glk: NOTRUN -> [SKIP][72] ([fdo#109271]) +64 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk9/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-upscaling@pipe-a-valid-mode.html

* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#2587] / [i915#2672]) +5 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-pwrite:
- shard-glk: [PASS][74] -> [FAIL][75] ([i915#2546])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-pwrite.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#6497]) +4 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt:
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109280]) +11 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#109280] / [fdo#111825]) +18 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb5/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-pwrite.html

* igt@kms_hdr@bpc-switch-dpms:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#3555]) +3 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb7/igt@[email protected]

* igt@kms_hdr@static-toggle-suspend:
- shard-iclb: NOTRUN -> [SKIP][80] ([i915#3555]) +5 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb6/igt@[email protected]

* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-tglb: NOTRUN -> [SKIP][81] ([i915#1839])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb3/igt@[email protected]

* igt@kms_plane_lowres@tiling-none@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [SKIP][82] ([i915#3536]) +3 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb6/igt@kms_plane_lowres@[email protected]

* igt@kms_plane_lowres@tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#112054] / [i915#5288])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb2/igt@[email protected]

* igt@kms_plane_lowres@tiling-yf@pipe-b-edp-1:
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#3536]) +5 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb6/igt@kms_plane_lowres@[email protected]

* igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-a-edp-1:
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#5176]) +5 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb6/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-scaler-with-rotation-unity-scaling@pipe-b-edp-1:
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#5176]) +11 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb8/igt@kms_plane_scaling@[email protected]

* igt@kms_prime@d3hot:
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#6524])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb8/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#6524])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb6/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-iclb: NOTRUN -> [SKIP][89] ([i915#2920])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#2920])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb6/igt@[email protected]

* igt@kms_psr2_su@page_flip-nv12:
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#7037])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb7/igt@kms_psr2_su@page_flip-nv12.html
- shard-glk: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#658]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk5/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109642] / [fdo#111068] / [i915#658]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb7/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_psr@psr2_primary_render:
- shard-iclb: [PASS][95] -> [SKIP][96] ([fdo#109441])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb2/igt@kms_psr@psr2_primary_render.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb3/igt@kms_psr@psr2_primary_render.html

* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-tglb: NOTRUN -> [FAIL][97] ([i915#132] / [i915#3467]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb1/igt@kms_psr@psr2_sprite_mmap_cpu.html
- shard-iclb: NOTRUN -> [SKIP][98] ([fdo#109441]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_cpu.html

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#111615] / [i915#5289])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb2/igt@[email protected]

* igt@perf_pmu@event-wait@rcs0:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#112283])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb6/igt@perf_pmu@[email protected]
- shard-tglb: NOTRUN -> [SKIP][101] ([fdo#112283])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb2/igt@perf_pmu@[email protected]

* igt@prime_udl:
- shard-tglb: NOTRUN -> [SKIP][102] ([fdo#109291])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb8/igt@prime_udl.html

* igt@sysfs_clients@fair-0:
- shard-apl: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#2994])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][104] ([i915#2994]) +2 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb8/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#2994])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][106] ([i915#2994])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb6/igt@[email protected]

#### Possible fixes ####

* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][107] ([i915#658]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb3/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@[email protected]

* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][109] ([i915#4525]) -> [PASS][110] +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb3/igt@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [FAIL][111] ([i915#2842]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-glk3/igt@gem_exec_fair@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][113] ([i915#2842]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-apl3/igt@gem_exec_fair@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl6/igt@gem_exec_fair@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [FAIL][115] ([i915#3989] / [i915#454]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb3/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][117] ([i915#3555]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling@pipe-a-default-mode.html

* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [SKIP][119] ([i915#5176]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html

* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][121] ([i915#5235]) -> [PASS][122] +2 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html

* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][123] ([fdo#109441]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb8/igt@kms_psr@psr2_sprite_render.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@kms_psr@psr2_sprite_render.html

* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- shard-tglb: [SKIP][125] ([i915#5519]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-tglb7/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb3/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-snb: [SKIP][127] ([fdo#109271]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-snb5/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-snb7/igt@[email protected]

#### Warnings ####

* igt@gem_pwrite@basic-exhaustion:
- shard-tglb: [WARN][129] ([i915#2658]) -> [INCOMPLETE][130] ([i915#7248])
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-tglb2/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-tglb3/igt@[email protected]
- shard-glk: [WARN][131] ([i915#2658]) -> [INCOMPLETE][132] ([i915#7248])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-glk8/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-glk8/igt@[email protected]

* igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1:
- shard-apl: [DMESG-FAIL][133] ([IGT#6]) -> [FAIL][134] ([i915#4573]) +1 similar issue
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-apl3/igt@kms_plane_alpha_blend@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl7/igt@kms_plane_alpha_blend@[email protected]

* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][135] ([fdo#111068] / [i915#658]) -> [SKIP][136] ([i915#2920])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb8/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-iclb: [SKIP][137] ([i915#2920]) -> [SKIP][138] ([fdo#111068] / [i915#658]) +1 similar issue
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-iclb2/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-iclb3/igt@[email protected]

* igt@runner@aborted:
- shard-apl: ([FAIL][139], [FAIL][140]) ([i915#3002] / [i915#4312]) -> ([FAIL][141], [FAIL][142], [FAIL][143]) ([i915#180] / [i915#3002] / [i915#4312])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-apl3/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12398/shard-apl8/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl3/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl3/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/shard-apl8/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6375]: https://gitlab.freedesktop.org/drm/intel/issues/6375
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7468]: https://gitlab.freedesktop.org/drm/intel/issues/7468
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7068 -> IGTPW_8128
* Piglit: piglit_4509 -> None

CI-20190529: 20190529
CI_DRM_12398: 6ff9396457d55a1915566b11121e8fe6f9068b1c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8128: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/index.html
IGT_7068: 5c0ec905b6bbecfb8df8b8f3315d0470539e6ae3 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8128/index.html

Reviewed-by on v1 1/1
#3 lore raw
In reply to Daniil Tatianin

Hi Daniil,

Quoted 10 lines · Daniil Tatianin

The GTT iteration loop would erroneously check "< gtt_size" as an indicator for when it should stop, which would make it exit the loop right after dumping 2-8 mib of address space depending on the GPU generation.

Calculate the actual size of GTT in 'gtt_max_addr', and rewrite the iteration loop to use it. While at it, also make virtual addresses 64-bit so that they don't wrap around at the 4GiB mark.

There is only one concern - this programm assumes 4KB page size and uses unsigned instead of unsigned int (or uint64_t).

Quoted 101 lines
---
 tools/intel_gtt.c | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)
tools/intel_gtt.c +18 -15
index 311694ba..c0f3d16a 100644
@@ -96,6 +96,11 @@ static uint64_t get_phys(uint32_t pt_offset)
 	return (phys | pae) & ~0xfff;
 }
 
+static int get_pte_size(void)
+{
+	return intel_gen(devid) < 8 ? 4 : 8;
+}
+
 static void pte_dump(int size, uint32_t offset) {
 	int pte_size;
 	int entries;
@@ -105,11 +110,7 @@ static void pte_dump(int size, uint32_t offset) {
 	if (size % 16)
 		size = (size + 16) & ~0xffff;
 
-	if (intel_gen(devid) < 8)
-		pte_size = 4;
-	else
-		pte_size = 8;
-
+	pte_size = get_pte_size();
 	entries = size / pte_size;
 
 	printf("GTT offset   |                 %d PTEs (%d MB)\n", entries,
@@ -139,7 +140,8 @@ static void pte_dump(int size, uint32_t offset) {
 int main(int argc, char **argv)
 {
 	struct pci_device *pci_dev;
-	unsigned int start, gtt_size;
+	unsigned gtt_size;
+	uint64_t start, gtt_max_addr;
 	int flag[] = {
 		PCI_DEV_MAP_FLAG_WRITE_COMBINE,
 		PCI_DEV_MAP_FLAG_WRITABLE,
@@ -190,14 +192,15 @@ int main(int argc, char **argv)
 		return 0;
 	}
 
-	for (start = 0; start < gtt_size; start += KB(4)) {
-		uint64_t start_phys = get_phys(start);
-		uint32_t end;
+	gtt_max_addr = (gtt_size / get_pte_size()) * KB(4ull);
+
+	for (start = 0; start < gtt_max_addr; start += KB(4)) {
+		uint64_t end, start_phys = get_phys(start);
 		int constant_length = 0;
 		int linear_length = 0;
 
 		/* Check if it's a linear sequence */
-		for (end = start + KB(4); end < gtt_size; end += KB(4)) {
+		for (end = start + KB(4); end < gtt_max_addr; end += KB(4)) {
 			uint64_t end_phys = get_phys(end);
 			if (end_phys == start_phys + (end - start))
 				linear_length++;
@@ -205,7 +208,7 @@ int main(int argc, char **argv)
 				break;
 		}
 		if (linear_length > 0) {
-			printf("0x%08x - 0x%08x: linear from "
+			printf("0x%08" PRIx64 "- 0x%08" PRIx64 ": linear from "
 			       "0x%" PRIx64 " to 0x%" PRIx64 "\n",
 			       start, end - KB(4),
 			       start_phys, start_phys + (end - start) - KB(4));
@@ -214,7 +217,7 @@ int main(int argc, char **argv)
 		}
 
 		/* Check if it's a constant sequence */
-		for (end = start + KB(4); end < gtt_size; end += KB(4)) {
+		for (end = start + KB(4); end < gtt_max_addr; end += KB(4)) {
 			uint64_t end_phys = get_phys(end);
 			if (end_phys == start_phys)
 				constant_length++;
@@ -222,13 +225,14 @@ int main(int argc, char **argv)
 				break;
 		}
 		if (constant_length > 0) {
-			printf("0x%08x - 0x%08x: constant 0x%" PRIx64 "\n",
+			printf("0x%08" PRIx64 " - 0x%08" PRIx64
+				": constant 0x%" PRIx64 "\n",
 			       start, end - KB(4), start_phys);
 			start = end - KB(4);
 			continue;
 		}
 
-		printf("0x%08x: 0x%" PRIx64 "\n", start, start_phys);
+		printf("0x%08" PRIx64 ": 0x%" PRIx64 "\n", start, start_phys);
 	}
 
 	return 0;
--

2.36.1.windows.1

#4 lore raw
Quoted 8 lines · Kamil Konieczny

Hi Daniil,

Quoted 5 lines · Daniil Tatianin

The GTT iteration loop would erroneously check "< gtt_size" as an indicator for when it should stop, which would make it exit the loop right after dumping 2-8 mib of address space depending on the GPU generation.

Quoted 8 lines
Quoted 5 lines

Calculate the actual size of GTT in 'gtt_max_addr', and rewrite the iteration loop to use it. While at it, also make virtual addresses 64-bit so that they don't wrap around at the 4GiB mark.

There is only one concern - this programm assumes 4KB page size

Right, I think this entire utility assumes 4KB page size. Is that not always the case?
I think that it should be a separate patch if we're going to get rid of that assumption, as
it basically has that constant all over the place.

Quoted 2 lines

and uses unsigned instead of unsigned int (or uint64_t).

Oops, my bad

Quoted 99 lines
Quoted 50 lines
---
 tools/intel_gtt.c | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)
tools/intel_gtt.c +8 -9
index 311694ba..c0f3d16a 100644
@@ -96,6 +96,11 @@ static uint64_t get_phys(uint32_t pt_offset)
      return (phys | pae) & ~0xfff;
 }
 
+static int get_pte_size(void)
+{
+     return intel_gen(devid) < 8 ? 4 : 8;
+}
+
 static void pte_dump(int size, uint32_t offset) {
      int pte_size;
      int entries;
@@ -105,11 +110,7 @@ static void pte_dump(int size, uint32_t offset) {
      if (size % 16)
              size = (size + 16) & ~0xffff;
 
-     if (intel_gen(devid) < 8)
-             pte_size = 4;
-     else
-             pte_size = 8;
-
+     pte_size = get_pte_size();
      entries = size / pte_size;
 
      printf("GTT offset   |                 %d PTEs (%d MB)\n", entries,
@@ -139,7 +140,8 @@ static void pte_dump(int size, uint32_t offset) {
 int main(int argc, char **argv)
 {
      struct pci_device *pci_dev;
-     unsigned int start, gtt_size;
+     unsigned gtt_size;
+     uint64_t start, gtt_max_addr;
      int flag[] = {
              PCI_DEV_MAP_FLAG_WRITE_COMBINE,
              PCI_DEV_MAP_FLAG_WRITABLE,
@@ -190,14 +192,15 @@ int main(int argc, char **argv)
              return 0;
      }
 
-     for (start = 0; start < gtt_size; start += KB(4)) {
-             uint64_t start_phys = get_phys(start);
-             uint32_t end;

tools/intel_gtt.c int main(int argc, char **argv) · line 203

Quoted 10 lines
tools/intel_gtt.c +5 -1
+     gtt_max_addr = (gtt_size / get_pte_size()) * KB(4ull);
+
+     for (start = 0; start < gtt_max_addr; start += KB(4)) {
+             uint64_t end, start_phys = get_phys(start);
              int constant_length = 0;
              int linear_length = 0;
 
              /* Check if it's a linear sequence */
-             for (end = start + KB(4); end < gtt_size; end += KB(4)) {
+             for (end = start + KB(4); end < gtt_max_addr; end +=

KB(4)) {

tools/intel_gtt.c int main(int argc, char **argv) · line 211

Quoted 9 lines
tools/intel_gtt.c +1 -1
                      uint64_t end_phys = get_phys(end);
                      if (end_phys == start_phys + (end - start))
                              linear_length++;
@@ -205,7 +208,7 @@ int main(int argc, char **argv)
                              break;
              }
              if (linear_length > 0) {
-                     printf("0x%08x - 0x%08x: linear from "
+                     printf("0x%08" PRIx64 "- 0x%08" PRIx64 ": linear

from "

tools/intel_gtt.c int main(int argc, char **argv)

Quoted 3 lines
tools/intel_gtt.c +0 -0
                             "0x%" PRIx64 " to 0x%" PRIx64 "\n",
                             start, end - KB(4),
                             start_phys, start_phys + (end - start) -

KB(4));

tools/intel_gtt.c int main(int argc, char **argv) · line 220

Quoted 6 lines
tools/intel_gtt.c +1 -1
@@ -214,7 +217,7 @@ int main(int argc, char **argv)
              }
 
              /* Check if it's a constant sequence */
-             for (end = start + KB(4); end < gtt_size; end += KB(4)) {
+             for (end = start + KB(4); end < gtt_max_addr; end +=

KB(4)) {

Quoted 15 lines
tools/intel_gtt.c +2 -1
                      uint64_t end_phys = get_phys(end);
                      if (end_phys == start_phys)
                              constant_length++;
@@ -222,13 +225,14 @@ int main(int argc, char **argv)
                              break;
              }
              if (constant_length > 0) {
-                     printf("0x%08x - 0x%08x: constant 0x%" PRIx64 "\n",
+                     printf("0x%08" PRIx64 " - 0x%08" PRIx64
+                             ": constant 0x%" PRIx64 "\n",
                             start, end - KB(4), start_phys);
                      start = end - KB(4);
                      continue;
              }
 
Quoted 9 lines

tools/intel_gtt.c int main(int argc, char **argv) · line 235

Quoted 2 lines
tools/intel_gtt.c +1 -1
-             printf("0x%08x: 0x%" PRIx64 "\n", start, start_phys);
+             printf("0x%08" PRIx64 ": 0x%" PRIx64 "\n", start,

start_phys);

Quoted 6 lines
tools/intel_gtt.c +0 -1
      }
 
      return 0;
--

2.36.1.windows.1

Thanks!

#5 lore raw

ping

Quoted 145 lines · Daniel Tatianin
Quoted 8 lines · Kamil Konieczny

Hi Daniil,

Quoted 5 lines · Daniil Tatianin

The GTT iteration loop would erroneously check "< gtt_size" as an indicator for when it should stop, which would make it exit the loop right after dumping 2-8 mib of address space depending on the GPU generation.

Quoted 8 lines
Quoted 5 lines

Calculate the actual size of GTT in 'gtt_max_addr', and rewrite the iteration loop to use it. While at it, also make virtual addresses 64-bit so that they don't wrap around at the 4GiB mark.

There is only one concern - this programm assumes 4KB page size

Right, I think this entire utility assumes 4KB page size. Is that not always the case?
I think that it should be a separate patch if we're going to get rid of that assumption, as
it basically has that constant all over the place.

Quoted 2 lines

and uses unsigned instead of unsigned int (or uint64_t).

Oops, my bad

Quoted 101 lines
Quoted 23 lines
---
 tools/intel_gtt.c | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)
tools/intel_gtt.c +5 -0
index 311694ba..c0f3d16a 100644
@@ -96,6 +96,11 @@ static uint64_t get_phys(uint32_t pt_offset)
      return (phys | pae) & ~0xfff;
 }
 
+static int get_pte_size(void)
+{
+     return intel_gen(devid) < 8 ? 4 : 8;
+}
+
 static void pte_dump(int size, uint32_t offset) {
      int pte_size;
      int entries;
@@ -105,11 +110,7 @@ static void pte_dump(int size, uint32_t offset) {
      if (size % 16)
              size = (size + 16) & ~0xffff;

tools/intel_gtt.c static void pte_dump(int size, uint32_t offset) { · line 116

Quoted 10 lines
tools/intel_gtt.c +1 -5
 
-     if (intel_gen(devid) < 8)
-             pte_size = 4;
-     else
-             pte_size = 8;
-
+     pte_size = get_pte_size();
      entries = size / pte_size;
 
      printf("GTT offset   |                 %d PTEs (%d MB)\n",

entries,

Quoted 17 lines
tools/intel_gtt.c +2 -4
@@ -139,7 +140,8 @@ static void pte_dump(int size, uint32_t offset) {
 int main(int argc, char **argv)
 {
      struct pci_device *pci_dev;
-     unsigned int start, gtt_size;
+     unsigned gtt_size;
+     uint64_t start, gtt_max_addr;
      int flag[] = {
              PCI_DEV_MAP_FLAG_WRITE_COMBINE,
              PCI_DEV_MAP_FLAG_WRITABLE,
@@ -190,14 +192,15 @@ int main(int argc, char **argv)
              return 0;
      }
 
-     for (start = 0; start < gtt_size; start += KB(4)) {
-             uint64_t start_phys = get_phys(start);
-             uint32_t end;

tools/intel_gtt.c int main(int argc, char **argv) · line 203

Quoted 10 lines
tools/intel_gtt.c +5 -1
+     gtt_max_addr = (gtt_size / get_pte_size()) * KB(4ull);
+
+     for (start = 0; start < gtt_max_addr; start += KB(4)) {
+             uint64_t end, start_phys = get_phys(start);
              int constant_length = 0;
              int linear_length = 0;
 
              /* Check if it's a linear sequence */
-             for (end = start + KB(4); end < gtt_size; end += KB(4)) {
+             for (end = start + KB(4); end < gtt_max_addr; end +=

KB(4)) {

tools/intel_gtt.c int main(int argc, char **argv) · line 211

Quoted 9 lines
tools/intel_gtt.c +1 -1
                      uint64_t end_phys = get_phys(end);
                      if (end_phys == start_phys + (end - start))
                              linear_length++;
@@ -205,7 +208,7 @@ int main(int argc, char **argv)
                              break;
              }
              if (linear_length > 0) {
-                     printf("0x%08x - 0x%08x: linear from "
+                     printf("0x%08" PRIx64 "- 0x%08" PRIx64 ": linear

from "

tools/intel_gtt.c int main(int argc, char **argv)

Quoted 3 lines
tools/intel_gtt.c +0 -0
                             "0x%" PRIx64 " to 0x%" PRIx64 "\n",
                             start, end - KB(4),
                             start_phys, start_phys + (end - start) -

KB(4));

tools/intel_gtt.c int main(int argc, char **argv) · line 220

Quoted 6 lines
tools/intel_gtt.c +1 -1
@@ -214,7 +217,7 @@ int main(int argc, char **argv)
              }
 
              /* Check if it's a constant sequence */
-             for (end = start + KB(4); end < gtt_size; end += KB(4)) {
+             for (end = start + KB(4); end < gtt_max_addr; end +=

KB(4)) {

tools/intel_gtt.c int main(int argc, char **argv) · line 225

Quoted 8 lines
tools/intel_gtt.c +0 -1
                      uint64_t end_phys = get_phys(end);
                      if (end_phys == start_phys)
                              constant_length++;
@@ -222,13 +225,14 @@ int main(int argc, char **argv)
                              break;
              }
              if (constant_length > 0) {
-                     printf("0x%08x - 0x%08x: constant 0x%" PRIx64

"\n",

Quoted 7 lines
tools/intel_gtt.c +2 -0
+                     printf("0x%08" PRIx64 " - 0x%08" PRIx64
+                             ": constant 0x%" PRIx64 "\n",
                             start, end - KB(4), start_phys);
                      start = end - KB(4);
                      continue;
              }
 
Quoted 9 lines

tools/intel_gtt.c int main(int argc, char **argv) · line 235

Quoted 2 lines
tools/intel_gtt.c +1 -1
-             printf("0x%08x: 0x%" PRIx64 "\n", start, start_phys);
+             printf("0x%08" PRIx64 ": 0x%" PRIx64 "\n", start,

start_phys);

Quoted 6 lines
tools/intel_gtt.c +0 -1
      }
 
      return 0;
--

2.36.1.windows.1

Thanks!

#6 lore raw
In reply to Daniel Tatianin

Hi Daniil,

Quoted 17 lines · Daniel Tatianin
Quoted 14 lines · Kamil Konieczny

Hi Daniil,

Quoted 10 lines · Daniil Tatianin

The GTT iteration loop would erroneously check "< gtt_size" as an indicator for when it should stop, which would make it exit the loop right after dumping 2-8 mib of address space depending on the GPU generation.

Calculate the actual size of GTT in 'gtt_max_addr', and rewrite the iteration loop to use it. While at it, also make virtual addresses 64-bit so that they don't wrap around at the 4GiB mark.

Quoted 7 lines
Quoted 2 lines

There is only one concern - this programm assumes 4KB page size

Right, I think this entire utility assumes 4KB page size. Is that not always the case?
I think that it should be a separate patch if we're going to get rid of that assumption, as
it basically has that constant all over the place.

The safe way would be to introduce PAGE_SIZE 4096
and use it instead.

Quoted 5 lines
Quoted 4 lines

and uses unsigned instead of unsigned int (or uint64_t).

Oops, my bad

That was there before so it can go in follow up patch.

I already merged your change, thx for your work,

Kamil

Quoted 112 lines
Quoted 101 lines
Quoted 50 lines
---
 tools/intel_gtt.c | 32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)
tools/intel_gtt.c +8 -9
index 311694ba..c0f3d16a 100644
@@ -96,6 +96,11 @@ static uint64_t get_phys(uint32_t pt_offset)
      return (phys | pae) & ~0xfff;
 }
 
+static int get_pte_size(void)
+{
+     return intel_gen(devid) < 8 ? 4 : 8;
+}
+
 static void pte_dump(int size, uint32_t offset) {
      int pte_size;
      int entries;
@@ -105,11 +110,7 @@ static void pte_dump(int size, uint32_t offset) {
      if (size % 16)
              size = (size + 16) & ~0xffff;
 
-     if (intel_gen(devid) < 8)
-             pte_size = 4;
-     else
-             pte_size = 8;
-
+     pte_size = get_pte_size();
      entries = size / pte_size;
 
      printf("GTT offset   |                 %d PTEs (%d MB)\n", entries,
@@ -139,7 +140,8 @@ static void pte_dump(int size, uint32_t offset) {
 int main(int argc, char **argv)
 {
      struct pci_device *pci_dev;
-     unsigned int start, gtt_size;
+     unsigned gtt_size;
+     uint64_t start, gtt_max_addr;
      int flag[] = {
              PCI_DEV_MAP_FLAG_WRITE_COMBINE,
              PCI_DEV_MAP_FLAG_WRITABLE,
@@ -190,14 +192,15 @@ int main(int argc, char **argv)
              return 0;
      }
 
-     for (start = 0; start < gtt_size; start += KB(4)) {
-             uint64_t start_phys = get_phys(start);
-             uint32_t end;

tools/intel_gtt.c int main(int argc, char **argv) · line 203

Quoted 10 lines
tools/intel_gtt.c +5 -1
+     gtt_max_addr = (gtt_size / get_pte_size()) * KB(4ull);
+
+     for (start = 0; start < gtt_max_addr; start += KB(4)) {
+             uint64_t end, start_phys = get_phys(start);
              int constant_length = 0;
              int linear_length = 0;
 
              /* Check if it's a linear sequence */
-             for (end = start + KB(4); end < gtt_size; end += KB(4)) {
+             for (end = start + KB(4); end < gtt_max_addr; end +=

KB(4)) {

tools/intel_gtt.c int main(int argc, char **argv) · line 211

Quoted 9 lines
tools/intel_gtt.c +1 -1
                      uint64_t end_phys = get_phys(end);
                      if (end_phys == start_phys + (end - start))
                              linear_length++;
@@ -205,7 +208,7 @@ int main(int argc, char **argv)
                              break;
              }
              if (linear_length > 0) {
-                     printf("0x%08x - 0x%08x: linear from "
+                     printf("0x%08" PRIx64 "- 0x%08" PRIx64 ": linear

from "

tools/intel_gtt.c int main(int argc, char **argv)

Quoted 3 lines
tools/intel_gtt.c +0 -0
                             "0x%" PRIx64 " to 0x%" PRIx64 "\n",
                             start, end - KB(4),
                             start_phys, start_phys + (end - start) -

KB(4));

tools/intel_gtt.c int main(int argc, char **argv) · line 220

Quoted 6 lines
tools/intel_gtt.c +1 -1
@@ -214,7 +217,7 @@ int main(int argc, char **argv)
              }
 
              /* Check if it's a constant sequence */
-             for (end = start + KB(4); end < gtt_size; end += KB(4)) {
+             for (end = start + KB(4); end < gtt_max_addr; end +=

KB(4)) {

Quoted 15 lines
tools/intel_gtt.c +2 -1
                      uint64_t end_phys = get_phys(end);
                      if (end_phys == start_phys)
                              constant_length++;
@@ -222,13 +225,14 @@ int main(int argc, char **argv)
                              break;
              }
              if (constant_length > 0) {
-                     printf("0x%08x - 0x%08x: constant 0x%" PRIx64 "\n",
+                     printf("0x%08" PRIx64 " - 0x%08" PRIx64
+                             ": constant 0x%" PRIx64 "\n",
                             start, end - KB(4), start_phys);
                      start = end - KB(4);
                      continue;
              }
 
Quoted 9 lines

tools/intel_gtt.c int main(int argc, char **argv) · line 235

Quoted 2 lines
tools/intel_gtt.c +1 -1
-             printf("0x%08x: 0x%" PRIx64 "\n", start, start_phys);
+             printf("0x%08" PRIx64 ": 0x%" PRIx64 "\n", start,

start_phys);

Quoted 6 lines
tools/intel_gtt.c +0 -1
      }
 
      return 0;
--

2.36.1.windows.1

Thanks!