Skip to contentSkip to conversation

net/nfp: fix return path in TSO processing function

PATCH Applied Niklas Söderlund 2 participants 2 messages Nov 18, 2022 – Nov 22, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/nfp: fix return path in TSO processing function

From: Fei Qin <[email protected]>

When enable TSO, nfp_net_nfdk_tx_tso() fills segment information in Tx descriptor. However, the return path for TSO is lost and the LSO related fields of Tx descriptor is filled with zeros which prevents packets from being sent.

This patch fixes the return path in TSO processing function to make sure TSO works fine.

Fixes c73dced48c8c ("net/nfp: add NFDk Tx")
---
 drivers/net/nfp/nfp_rxtx.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/nfp/nfp_rxtx.c +2 -0
index 38377ca2182e..01cffdfde0b4 100644
@@ -1135,6 +1135,8 @@ nfp_net_nfdk_tx_tso(struct nfp_net_txq *txq, struct rte_mbuf *mb)
 	txd.lso_hdrlen = mb->l2_len + mb->l3_len + mb->l4_len;
 	txd.lso_totsegs = (mb->pkt_len + mb->tso_segsz) / mb->tso_segsz;
 
+	return txd.raw;
+
 clean_txd:
 	txd.l3_offset = 0;
 	txd.l4_offset = 0;
Signature · 1 line
2.38.1
Applied
#1 lore raw
Quoted 10 lines · Niklas Söderlund

From: Fei Qin <[email protected]>

When enable TSO, nfp_net_nfdk_tx_tso() fills segment information in Tx descriptor. However, the return path for TSO is lost and the LSO related fields of Tx descriptor is filled with zeros which prevents packets from being sent.

This patch fixes the return path in TSO processing function to make sure TSO works fine.

Quoted 7 lines
Fixes c73dced48c8c ("net/nfp: add NFDk Tx")

Applied to dpdk-next-net/main, thanks.