Skip to contentSkip to conversation

libs/light: Propagate libxl__arch_domain_create() return code

PATCH In review Anthony PERARD 3 participants 3 messages Nov 18, 2022 – Nov 19, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libs/light: Propagate libxl__arch_domain_create() return code

Commit 34990446ca91 started to overwrite the rc value from libxl__arch_domain_create(), thus error aren't propagated anymore.

Check rc value before doing the next thing.

Fixes 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy")
---
 tools/libs/light/libxl_dom.c | 2 ++
 1 file changed, 2 insertions(+)
tools/libs/light/libxl_dom.c +2 -0
index b59bbe00bb..fa5c79e4f6 100644
@@ -377,6 +377,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid,
     state->console_port = xc_evtchn_alloc_unbound(ctx->xch, domid, state->console_domid);
 
     rc = libxl__arch_domain_create(gc, d_config, state, domid);
+    if (rc) goto out;
 
     /* Construct a CPUID policy, but only for brand new domains.  Domains
      * being migrated-in/restored have CPUID handled during the
@@ -384,6 +385,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid,
     if (!state->restore)
         rc = libxl__cpuid_legacy(ctx, domid, false, info);
 
+out:
     return rc;
 }
 
Signature · 1 line
Anthony PERARD
#1 lore raw

Hi Anthony,

Quoted 8 lines

-----Original Message-----
From: Anthony PERARD <[email protected]>
Subject: [XEN PATCH for-4.17] libs/light: Propagate libxl__arch_domain_create() return code

Commit 34990446ca91 started to overwrite the rc value from libxl__arch_domain_create(), thus error aren't propagated anymore.

Quoted 6 lines

Check rc value before doing the next thing.

Fixes 34990446ca91 ("libxl: don't ignore the return value from

xc_cpuid_apply_policy")

Kind regards,
Henry

Reviewed-by on v1 1/1
#2 lore raw
In reply to Anthony PERARD
Quoted 9 lines · Anthony PERARD

Commit 34990446ca91 started to overwrite the rc value from libxl__arch_domain_create(), thus error aren't propagated anymore.

Check rc value before doing the next thing.

Fixes 34990446ca91 ("libxl: don't ignore the return value from xc_cpuid_apply_policy")

Was the issue that libxl__arch_domain_create() failed, but then libxl__cpuid_legacy() succeeded. rc was overwritten, so libxl__build_pre() returns success?

Thanks,
Jason