kbuild: add kbuild-file macro
Subsystems (2)
PATCH v2 1/2 kbuild: add kbuild-file macro
While building, installing, cleaning, Kbuild visits sub-directories and includes 'Kbuild' or 'Makefile' that exists there.
Add 'kbuild-file' macro, and reuse it from scripts/Makefie.*
---
Changes in v2:
- Change scripts/Makefile.modpost
scripts/Kbuild.include | 5 +++++ scripts/Makefile.asm-generic | 6 +++--- scripts/Makefile.build | 6 +----- scripts/Makefile.clean | 5 +---- scripts/Makefile.dtbinst | 2 +- scripts/Makefile.modpost | 2 +- 6 files changed, 12 insertions(+), 14 deletions(-)
scripts/Kbuild.include +5 -0
@@ -40,6 +40,11 @@ escsq = $(subst $(squote),'\$(squote)',$1) # Quote a string to pass it to C files. foo => '"foo"' stringify = $(squote)$(quote)$1$(quote)$(squote) +### +# The path to Kbuild or Makefile. Kbuild has precedence over Makefile. +kbuild-dir = $(if $(filter /%,$(src)),$(src),$(srctree)/$(src)) +kbuild-file = $(or $(wildcard $(kbuild-dir)/Kbuild),$(kbuild-dir)/Makefile) + ### # Easy method for doing a status message kecho := :
scripts/Makefile.asm-generic +3 -3
@@ -10,15 +10,15 @@ PHONY := all all: src := $(subst /generated,,$(obj)) --include $(src)/Kbuild + +include $(srctree)/scripts/Kbuild.include +-include $(kbuild-file) # $(generic)/Kbuild lists mandatory-y. Exclude um since it is a special case. ifneq ($(SRCARCH),um) include $(srctree)/$(generic)/Kbuild endif -include $(srctree)/scripts/Kbuild.include - redundant := $(filter $(mandatory-y) $(generated-y), $(generic-y)) redundant += $(foreach f, $(generic-y), $(if $(wildcard $(srctree)/$(src)/$(f)),$(f))) redundant := $(sort $(redundant))
scripts/Makefile.build +1 -5
@@ -38,11 +38,7 @@ subdir-ccflags-y := include $(srctree)/scripts/Kbuild.include include $(srctree)/scripts/Makefile.compiler - -# The filename Kbuild has precedence over Makefile -kbuild-dir := $(if $(filter /%,$(src)),$(src),$(srctree)/$(src)) -include $(or $(wildcard $(kbuild-dir)/Kbuild),$(kbuild-dir)/Makefile) - +include $(kbuild-file) include $(srctree)/scripts/Makefile.lib # Do not include hostprogs rules unless needed.
scripts/Makefile.clean +1 -4
@@ -9,10 +9,7 @@ PHONY := __clean __clean: include $(srctree)/scripts/Kbuild.include - -# The filename Kbuild has precedence over Makefile -kbuild-dir := $(if $(filter /%,$(src)),$(src),$(srctree)/$(src)) -include $(or $(wildcard $(kbuild-dir)/Kbuild),$(kbuild-dir)/Makefile) +include $(kbuild-file) # Figure out what we need to build from the various variables # ==========================================================================
scripts/Makefile.dtbinst +1 -1
@@ -15,7 +15,7 @@ __dtbs_install: include include/config/auto.conf include $(srctree)/scripts/Kbuild.include -include $(src)/Makefile +include $(kbuild-file) dtbs := $(addprefix $(dst)/, $(dtb-y) $(if $(CONFIG_OF_ALL_DTBS),$(dtb-))) subdirs := $(addprefix $(obj)/, $(subdir-y) $(subdir-m))
scripts/Makefile.modpost +1 -1
@@ -93,7 +93,7 @@ obj := $(KBUILD_EXTMOD) src := $(obj) # Include the module's Makefile to find KBUILD_EXTRA_SYMBOLS -include $(or $(wildcard $(src)/Kbuild), $(src)/Makefile) +include $(kbuild-file) module.symvers-if-present := $(wildcard Module.symvers) output-symdump := $(KBUILD_EXTMOD)/Module.symvers
Signature · 1 line
2.34.1
PATCH v2 2/2 kbuild: warn objects shared among multiple modules
If an object is shared among multiple modules, amd some of them are configured as 'm', but the others as 'y', the shared object is built as modular, then linked to the modules and vmlinux. This is a potential issue because the expected CFLAGS are different between modules and builtins.
Commit 637a642f5ca5 ("zstd: Fixing mixed module-builtin objects") reported that this could be even more fatal in some cases such as Clang LTO.
That commit fixed lib/zlib/zstd_{compress,decompress}, but there are still more instances of breakage.
This commit adds a W=1 warning for shared objects, so that the kbuild test robot, which provides build tests with W=1, will avoid a new breakage slipping in.
Quick compile tests on v6.1-rc4 detected the following:
scripts/Makefile.build:252: ./drivers/block/rnbd/Makefile: rnbd-common.o is added to multiple modules: rnbd-client rnbd-serverscripts/Makefile.build:252: ./drivers/crypto/marvell/octeontx2/Makefile: cn10k_cpt.o is added to multiple modules: rvu_cptpf rvu_cptvfscripts/Makefile.build:252: ./drivers/crypto/marvell/octeontx2/Makefile: otx2_cptlf.o is added to multiple modules: rvu_cptpf rvu_cptvfscripts/Makefile.build:252: ./drivers/crypto/marvell/octeontx2/Makefile: otx2_cpt_mbox_common.o is added to multiple modules: rvu_cptpf rvu_cptvfscripts/Makefile.build:252: ./drivers/edac/Makefile: skx_common.o is added to multiple modules: i10nm_edac skx_edacscripts/Makefile.build:252: ./drivers/gpu/drm/bridge/imx/Makefile: imx-ldb-helper.o is added to multiple modules: imx8qm-ldb imx8qxp-ldbscripts/Makefile.build:252: ./drivers/mfd/Makefile: rsmu_core.o is added to multiple modules: rsmu-i2c rsmu-spiscripts/Makefile.build:252: ./drivers/mtd/tests/Makefile: mtd_test.o is added to multiple modules: mtd_nandbiterrs mtd_oobtest mtd_pagetest mtd_readtest mtd_speedtest mtd_stresstest mtd_subpagetest mtd_torturetest scripts/Makefile.build:252: ./drivers/net/dsa/ocelot/Makefile: felix.o is added to multiple modules: mscc_felix mscc_sevillescripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: cn23xx_pf_device.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: cn23xx_vf_device.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: cn66xx_device.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: cn68xx_device.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: lio_core.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: lio_ethtool.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: octeon_device.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: octeon_droq.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: octeon_mailbox.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: octeon_mem_ops.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: octeon_nic.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: request_manager.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/cavium/liquidio/Makefile: response_manager.o is added to multiple modules: liquidio liquidio_vfscripts/Makefile.build:252: ./drivers/net/ethernet/freescale/dpaa2/Makefile: dpaa2-mac.o is added to multiple modules: fsl-dpaa2-eth fsl-dpaa2-switchscripts/Makefile.build:252: ./drivers/net/ethernet/freescale/dpaa2/Makefile: dpmac.o is added to multiple modules: fsl-dpaa2-eth fsl-dpaa2-switchscripts/Makefile.build:252: ./drivers/net/ethernet/freescale/enetc/Makefile: enetc_cbdr.o is added to multiple modules: fsl-enetc fsl-enetc-vfscripts/Makefile.build:252: ./drivers/net/ethernet/freescale/enetc/Makefile: enetc_ethtool.o is added to multiple modules: fsl-enetc fsl-enetc-vfscripts/Makefile.build:252: ./drivers/net/ethernet/freescale/enetc/Makefile: enetc.o is added to multiple modules: fsl-enetc fsl-enetc-vfscripts/Makefile.build:252: ./drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_cmd.o is added to multiple modules: hclge hclgevfscripts/Makefile.build:252: ./drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_rss.o is added to multiple modules: hclge hclgevfscripts/Makefile.build:252: ./drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_tqp_stats.o is added to multiple modules: hclge hclgevf scripts/Makefile.build:252: ./drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_dcbnl.o is added to multiple modules: rvu_nicpf rvu_nicvfscripts/Makefile.build:252: ./drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_devlink.o is added to multiple modules: rvu_nicpf rvu_nicvfscripts/Makefile.build:252: ./drivers/net/ethernet/ti/Makefile: cpsw_ale.o is added to multiple modules: keystone_netcp keystone_netcp_ethss ti_cpsw ti_cpsw_new scripts/Makefile.build:252: ./drivers/net/ethernet/ti/Makefile: cpsw_ethtool.o is added to multiple modules: ti_cpsw ti_cpsw_newscripts/Makefile.build:252: ./drivers/net/ethernet/ti/Makefile: cpsw_priv.o is added to multiple modules: ti_cpsw ti_cpsw_newscripts/Makefile.build:252: ./drivers/net/ethernet/ti/Makefile: cpsw_sl.o is added to multiple modules: ti_cpsw ti_cpsw_newscripts/Makefile.build:252: ./drivers/net/ethernet/ti/Makefile: davinci_cpdma.o is added to multiple modules: ti_cpsw ti_cpsw_new ti_davinci_emacscripts/Makefile.build:252: ./drivers/platform/x86/intel/int3472/Makefile: common.o is added to multiple modules: intel_skl_int3472_discrete intel_skl_int3472_tps68470 scripts/Makefile.build:252: ./sound/soc/codecs/Makefile: wcd-clsh-v2.o is added to multiple modules: snd-soc-wcd9335 snd-soc-wcd934x snd-soc-wcd938x
Once all the warnings are fixed, it can become an error irrespective of W= option.
---
Changes in v2:
- Add drivers/block/rnbd/Makefile for commit log
scripts/Makefile.build | 6 ++++++ 1 file changed, 6 insertions(+)
scripts/Makefile.build +6 -0
@@ -222,6 +222,10 @@ endif cmd_check_local_export = $(srctree)/scripts/check-local-export $@ +ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),) +cmd_warn_shared_object = $(if $(word 2, $(modname-multi)),$(warning $(kbuild-file): $*.o is added to multiple modules: $(modname-multi))) +endif + define rule_cc_o_c $(call cmd_and_fixdep,cc_o_c) $(call cmd,gen_ksymdeps)
@@ -231,6 +235,7 @@ define rule_cc_o_c $(call cmd,gen_objtooldep) $(call cmd,gen_symversions_c) $(call cmd,record_mcount) + $(call cmd,warn_shared_object) endef define rule_as_o_S
@@ -239,6 +244,7 @@ define rule_as_o_S $(call cmd,check_local_export) $(call cmd,gen_objtooldep) $(call cmd,gen_symversions_S) + $(call cmd,warn_shared_object) endef # Built-in and composite module parts
Signature · 1 line
2.34.1
Re: [PATCH v2 2/2] kbuild: warn objects shared among multiple modules
From: Masahiro Yamada <[email protected]>
Date: Sat, 19 Nov 2022 04:15:51 +0900
Quoted 10 lines
If an object is shared among multiple modules, amd some of them are configured as 'm', but the others as 'y', the shared object is built as modular, then linked to the modules and vmlinux. This is a potential issue because the expected CFLAGS are different between modules and builtins.
Commit
637a642f5ca5("zstd: Fixing mixed module-builtin objects") reported that this could be even more fatal in some cases such as Clang LTO.
Quoted 8 lines
That commit fixed
lib/zlib/zstd_{compress,decompress}, but there are still more instances of breakage.This commit adds a W=1 warning for shared objects, so that the kbuild test robot, which provides build tests with W=1, will avoid a new breakage slipping in.
Quick compile tests on v6.1-rc4 detected the following:
For the series:
[...]
Quoted 2 lines
Once all the warnings are fixed, it can become an error irrespective of W= option.
BTW I've fixed most of these (the ones that get build on typical x86_64 distroconfig) during my local tests, basing off your WIP tree. I could send a series if you wish.
Quoted 42 lines
Signed-off-by Masahiro Yamada <[email protected]>---
Changes in v2:
- Adddrivers/block/rnbd/Makefilefor commit logscripts/Makefile.build | 6 ++++++ 1 file changed, 6 insertions(+)scripts/Makefile.build +6
-1@@ -222,6 +222,10 @@ endif cmd_check_local_export = $(srctree)/scripts/check-local-export $@ +ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),) +cmd_warn_shared_object = $(if $(word 2, $(modname-multi)),$(warning $(kbuild-file): $*.o is added to multiple modules: $(modname-multi))) +endif + define rule_cc_o_c $(call cmd_and_fixdep,cc_o_c) $(call cmd,gen_ksymdeps)@@ -231,6 +235,7 @@ define rule_cc_o_c $(call cmd,gen_objtooldep) $(call cmd,gen_symversions_c) $(call cmd,record_mcount) + $(call cmd,warn_shared_object) endef define rule_as_o_S@@ -239,6 +244,7 @@ define rule_as_o_S $(call cmd,check_local_export) $(call cmd,gen_objtooldep) $(call cmd,gen_symversions_S) + $(call cmd,warn_shared_object) endef # Built-in and composite module parts --
Quoted 1 line
2.34.1
Thanks,
Olek
Re: [PATCH v2 2/2] kbuild: warn objects shared among multiple modules
Quoted 27 lines · Alexander Lobakin
From: Masahiro Yamada <[email protected]>
Date: Sat, 19 Nov 2022 04:15:51 +0900Quoted 10 lines
If an object is shared among multiple modules, amd some of them are configured as 'm', but the others as 'y', the shared object is built as modular, then linked to the modules and vmlinux. This is a potential issue because the expected CFLAGS are different between modules and builtins.
Commit
637a642f5ca5("zstd: Fixing mixed module-builtin objects") reported that this could be even more fatal in some cases such as Clang LTO.Quoted 8 lines
That commit fixed
lib/zlib/zstd_{compress,decompress}, but there are still more instances of breakage.This commit adds a W=1 warning for shared objects, so that the kbuild test robot, which provides build tests with W=1, will avoid a new breakage slipping in.
Quick compile tests on v6.1-rc4 detected the following:
For the series:
Reviewed-and-tested-by Alexander Lobakin <[email protected]>
Quoted 8 lines
[...]
Quoted 2 lines
Once all the warnings are fixed, it can become an error irrespective of W= option.
BTW I've fixed most of these (the ones that get build on typical
x86_64distroconfig) during my local tests, basing off your WIP tree. I could send a series if you wish.
Yes, thanks for the help.
Quoted 48 lines
Quoted 43 lines
Signed-off-by Masahiro Yamada <[email protected]>---
Changes in v2:
- Adddrivers/block/rnbd/Makefilefor commit logscripts/Makefile.build | 6 ++++++ 1 file changed, 6 insertions(+)scripts/Makefile.build +6
-1@@ -222,6 +222,10 @@ endif cmd_check_local_export = $(srctree)/scripts/check-local-export $@ +ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),) +cmd_warn_shared_object = $(if $(word 2, $(modname-multi)),$(warning $(kbuild-file): $*.o is added to multiple modules: $(modname-multi))) +endif + define rule_cc_o_c $(call cmd_and_fixdep,cc_o_c) $(call cmd,gen_ksymdeps)@@ -231,6 +235,7 @@ define rule_cc_o_c $(call cmd,gen_objtooldep) $(call cmd,gen_symversions_c) $(call cmd,record_mcount) + $(call cmd,warn_shared_object) endef define rule_as_o_S@@ -239,6 +244,7 @@ define rule_as_o_S $(call cmd,check_local_export) $(call cmd,gen_objtooldep) $(call cmd,gen_symversions_S) + $(call cmd,warn_shared_object) endef # Built-in and composite module parts --Quoted 1 line
2.34.1
Thanks,
Olek
Signature · 2 lines
Best Regards Masahiro Yamada
Re: [PATCH v2 2/2] kbuild: warn objects shared among multiple modules
In reply to Masahiro YamadaQuoted 1 line · Masahiro Yamada
If an object is shared among multiple modules, amd some of them are
amd -> and
Quoted 103 lines
configured as 'm', but the others as 'y', the shared object is built as modular, then linked to the modules and vmlinux. This is a potential issue because the expected CFLAGS are different between modules and builtins.
Commit
637a642f5ca5("zstd: Fixing mixed module-builtin objects") reported that this could be even more fatal in some cases such as Clang LTO.That commit fixed
lib/zlib/zstd_{compress,decompress}, but there are still more instances of breakage.This commit adds a W=1 warning for shared objects, so that the kbuild test robot, which provides build tests with W=1, will avoid a new breakage slipping in.
Quick compile tests on v6.1-rc4 detected the following:
scripts/Makefile.build:252:./drivers/block/rnbd/Makefile: rnbd-common.o is added to multiple modules: rnbd-client rnbd-serverscripts/Makefile.build:252:./drivers/crypto/marvell/octeontx2/Makefile: cn10k_cpt.o is added to multiple modules:rvu_cptpfrvu_cptvfscripts/Makefile.build:252:./drivers/crypto/marvell/octeontx2/Makefile: otx2_cptlf.o is added to multiple modules:rvu_cptpfrvu_cptvfscripts/Makefile.build:252:./drivers/crypto/marvell/octeontx2/Makefile: otx2_cpt_mbox_common.o is added to multiple modules:rvu_cptpfrvu_cptvfscripts/Makefile.build:252:./drivers/edac/Makefile: skx_common.o is added to multiple modules:i10nm_edacskx_edacscripts/Makefile.build:252:./drivers/gpu/drm/bridge/imx/Makefile: imx-ldb-helper.o is added to multiple modules: imx8qm-ldb imx8qxp-ldbscripts/Makefile.build:252:./drivers/mfd/Makefile: rsmu_core.o is added to multiple modules: rsmu-i2c rsmu-spiscripts/Makefile.build:252:./drivers/mtd/tests/Makefile: mtd_test.o is added to multiple modules:mtd_nandbiterrsmtd_oobtestmtd_pagetestmtd_readtestmtd_speedtestmtd_stresstestmtd_subpagetestmtd_torturetestscripts/Makefile.build:252:./drivers/net/dsa/ocelot/Makefile: felix.o is added to multiple modules:mscc_felixmscc_sevillescripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: cn23xx_pf_device.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: cn23xx_vf_device.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: cn66xx_device.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: cn68xx_device.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: lio_core.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: lio_ethtool.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: octeon_device.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: octeon_droq.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: octeon_mailbox.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: octeon_mem_ops.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: octeon_nic.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: request_manager.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/cavium/liquidio/Makefile: response_manager.o is added to multiple modules: liquidioliquidio_vfscripts/Makefile.build:252:./drivers/net/ethernet/freescale/dpaa2/Makefile: dpaa2-mac.o is added to multiple modules: fsl-dpaa2-eth fsl-dpaa2-switchscripts/Makefile.build:252:./drivers/net/ethernet/freescale/dpaa2/Makefile: dpmac.o is added to multiple modules: fsl-dpaa2-eth fsl-dpaa2-switchscripts/Makefile.build:252:./drivers/net/ethernet/freescale/enetc/Makefile: enetc_cbdr.o is added to multiple modules: fsl-enetc fsl-enetc-vfscripts/Makefile.build:252:./drivers/net/ethernet/freescale/enetc/Makefile: enetc_ethtool.o is added to multiple modules: fsl-enetc fsl-enetc-vfscripts/Makefile.build:252:./drivers/net/ethernet/freescale/enetc/Makefile: enetc.o is added to multiple modules: fsl-enetc fsl-enetc-vfscripts/Makefile.build:252:./drivers/net/ethernet/hisilicon/hns3/Makefile:hns3_common/hclge_comm_cmd.ois added to multiple modules: hclge hclgevfscripts/Makefile.build:252:./drivers/net/ethernet/hisilicon/hns3/Makefile:hns3_common/hclge_comm_rss.ois added to multiple modules: hclge hclgevfscripts/Makefile.build:252:./drivers/net/ethernet/hisilicon/hns3/Makefile:hns3_common/hclge_comm_tqp_stats.ois added to multiple modules: hclge hclgevfscripts/Makefile.build:252:./drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_dcbnl.o is added to multiple modules:rvu_nicpfrvu_nicvfscripts/Makefile.build:252:./drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_devlink.o is added to multiple modules:rvu_nicpfrvu_nicvfscripts/Makefile.build:252:./drivers/net/ethernet/ti/Makefile: cpsw_ale.o is added to multiple modules:keystone_netcpkeystone_netcp_ethssti_cpswti_cpsw_newscripts/Makefile.build:252:./drivers/net/ethernet/ti/Makefile: cpsw_ethtool.o is added to multiple modules:ti_cpswti_cpsw_newscripts/Makefile.build:252:./drivers/net/ethernet/ti/Makefile: cpsw_priv.o is added to multiple modules:ti_cpswti_cpsw_newscripts/Makefile.build:252:./drivers/net/ethernet/ti/Makefile: cpsw_sl.o is added to multiple modules:ti_cpswti_cpsw_newscripts/Makefile.build:252:./drivers/net/ethernet/ti/Makefile: davinci_cpdma.o is added to multiple modules:ti_cpswti_cpsw_newti_davinci_emacscripts/Makefile.build:252:./drivers/platform/x86/intel/int3472/Makefile: common.o is added to multiple modules:intel_skl_int3472_discreteintel_skl_int3472_tps68470scripts/Makefile.build:252:./sound/soc/codecs/Makefile: wcd-clsh-v2.o is added to multiple modules: snd-soc-wcd9335 snd-soc-wcd934x snd-soc-wcd938xOnce all the warnings are fixed, it can become an error irrespective of W= option.
Signed-off-by Masahiro Yamada <[email protected]>---
Changes in v2:
- Adddrivers/block/rnbd/Makefilefor commit logscripts/Makefile.build | 6 ++++++ 1 file changed, 6 insertions(+)scripts/Makefile.build +6
-0@@ -222,6 +222,10 @@ endif cmd_check_local_export = $(srctree)/scripts/check-local-export $@ +ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),) +cmd_warn_shared_object = $(if $(word 2, $(modname-multi)),$(warning $(kbuild-file): $*.o is added to multiple modules: $(modname-multi))) +endif + define rule_cc_o_c $(call cmd_and_fixdep,cc_o_c) $(call cmd,gen_ksymdeps)@@ -231,6 +235,7 @@ define rule_cc_o_c $(call cmd,gen_objtooldep) $(call cmd,gen_symversions_c) $(call cmd,record_mcount) + $(call cmd,warn_shared_object) endef define rule_as_o_S@@ -239,6 +244,7 @@ define rule_as_o_S $(call cmd,check_local_export) $(call cmd,gen_objtooldep) $(call cmd,gen_symversions_S) + $(call cmd,warn_shared_object) endef # Built-in and composite module partsSignature · 1 line
2.34.1
Signature · 3 lines
epost|xmpp: [email protected] irc://oftc.net/nsc ↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f -- frykten for herren er opphav til kunnskap --