Skip to contentSkip to conversation

dt-bindings: input: gpio-beeper: Convert to yaml schema

PATCH Applied Fabio Estevam 4 participants 4 messages Nov 20, 2022 – Dec 2, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: input: gpio-beeper: Convert to yaml schema

From: Fabio Estevam <[email protected]>

Convert the bindings from plain text to yaml schema.

---
 .../devicetree/bindings/input/gpio-beeper.txt | 13 --------
 .../bindings/input/gpio-beeper.yaml           | 33 +++++++++++++++++++
 2 files changed, 33 insertions(+), 13 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/gpio-beeper.txt
 create mode 100644 Documentation/devicetree/bindings/input/gpio-beeper.yaml
Documentation/devicetree/bindings/input/gpio-beeper.txt deleted +0 -13
deleted file mode 100644
index a5086e37fce6..000000000000
@@ -1,13 +0,0 @@
-* GPIO beeper device tree bindings
-
-Register a beeper connected to GPIO pin.
-
-Required properties:
-- compatible:	Should be "gpio-beeper".
-- gpios:	From common gpio binding; gpio connection to beeper enable pin.
-
-Example:
-	beeper: beeper {
-		compatible = "gpio-beeper";
-		gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
-	};
Documentation/devicetree/bindings/input/gpio-beeper.yaml new file +33 -0
new file mode 100644
index 000000000000..5fd57a8940df
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/gpio-beeper.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: GPIO controlled beeper
+
+maintainers:
+  - Fabio Estevam <[email protected]>
+
+properties:
+  compatible:
+    const: gpio-beeper
+
+  gpios:
+    maxItems: 1
+    description:
+      GPIO that drives the beeper.
+
+required:
+  - compatible
+  - gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    beeper {
+        compatible = "gpio-beeper";
+        gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
+    };
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Convert the bindings from plain text to yaml schema.

Small nit below, but I don't think it matters, so:

Quoted 41 lines
---
 .../devicetree/bindings/input/gpio-beeper.txt | 13 --------
 .../bindings/input/gpio-beeper.yaml           | 33 +++++++++++++++++++
 2 files changed, 33 insertions(+), 13 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/gpio-beeper.txt
 create mode 100644 Documentation/devicetree/bindings/input/gpio-beeper.yaml
Documentation/devicetree/bindings/input/gpio-beeper.txt deleted +0 -13
deleted file mode 100644
index a5086e37fce6..000000000000
@@ -1,13 +0,0 @@
-* GPIO beeper device tree bindings
-
-Register a beeper connected to GPIO pin.
-
-Required properties:
-- compatible:	Should be "gpio-beeper".
-- gpios:	From common gpio binding; gpio connection to beeper enable pin.
-
-Example:
-	beeper: beeper {
-		compatible = "gpio-beeper";
-		gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
-	};
Documentation/devicetree/bindings/input/gpio-beeper.yaml new file +9 -0
new file mode 100644
index 000000000000..5fd57a8940df
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/gpio-beeper.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: GPIO controlled beeper
+
+maintainers:

Documentation/devicetree/bindings/input/gpio-beeper.yaml line 19

Quoted 10 lines
Documentation/devicetree/bindings/input/gpio-beeper.yaml new file +10 -0
+  - Fabio Estevam <[email protected]>
+
+properties:
+  compatible:
+    const: gpio-beeper
+
+  gpios:
+    maxItems: 1
+    description:
+      GPIO that drives the beeper.

We can join these lines:

description: GPIO that drives the beeper.

Quoted 16 lines
Documentation/devicetree/bindings/input/gpio-beeper.yaml new file +14 -0
+
+required:
+  - compatible
+  - gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    beeper {
+        compatible = "gpio-beeper";
+        gpios = <&gpio3 23 GPIO_ACTIVE_HIGH>;
+    };
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#2 lore raw
In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Convert the bindings from plain text to yaml schema.

---
 .../devicetree/bindings/input/gpio-beeper.txt | 13 --------
 .../bindings/input/gpio-beeper.yaml           | 33 +++++++++++++++++++
 2 files changed, 33 insertions(+), 13 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/input/gpio-beeper.txt

Somehow I missed this. Apologies for late reply.

Best regards,
Krzysztof