Subsystems (2)
Date: Mon, 21 Nov 2022 13:29:03 +0300
Subject: [PATCH] scsi:bfa: Eliminated buffer overflow
Buffer 'cmd->adapter_hwpath' of size 32 accessed at bfad_bsg.c:101:103 can overflow, since its index 'i' can have value 32 that is out of range.
Signed-off-by Denis Arefev <[email protected]>
--- drivers/scsi/bfa/bfad_bsg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/bfa/bfad_bsg.c +2 -2
@@ -98,9 +98,9 @@ bfad_iocmd_ioc_get_info(struct bfad_s *bfad, void *cmd)/* set adapter hw path */ strcpy (iocmd->adapter_hwpath, bfad->pci_name); -for (i =0 ; iocmd->adapter_hwpath[i] !=':' && i <BFA_STRING_32 ; i++) +for (i =0 ; iocmd->adapter_hwpath[i] !=':' && i <BFA_STRING_32 -2 ; i++) ; -for (; iocmd->adapter_hwpath[++i] !=':' && i <BFA_STRING_32 ; ) +for (; iocmd->adapter_hwpath[++i] !=':' && i <BFA_STRING_32 -1 ; ) ; iocmd->adapter_hwpath[i] ='\0' ; iocmd->status =BFA_STATUS_OK ;
Signature · 1 line
2.25.1
You may need a real subject, not a subject text in the email.
type "git help send-email" if you don't know how to use it.
Quoted 29 lines · Denis Arefev
Date: Mon, 21 Nov 2022 13:29:03 +0300
Subject: [PATCH] scsi:bfa: Eliminated buffer overflowBuffer '
cmd->adapter_hwpath' of size 32 accessed at bfad_bsg.c:101:103 can overflow, since its index 'i' can have value 32 that is out of range.Signed-off-by Denis Arefev <[email protected]>--- drivers/scsi/bfa/bfad_bsg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/scsi/bfa/bfad_bsg.c +2
-2@@ -98,9 +98,9 @@ bfad_iocmd_ioc_get_info(struct bfad_s *bfad, void *cmd)/* set adapter hw path */ strcpy (iocmd->adapter_hwpath, bfad->pci_name); -for (i =0 ; iocmd->adapter_hwpath[i] !=':' && i <BFA_STRING_32 ; i++) +for (i =0 ; iocmd->adapter_hwpath[i] !=':' && i <BFA_STRING_32 -2 ; i++) ; -for (; iocmd->adapter_hwpath[++i] !=':' && i <BFA_STRING_32 ; ) +for (; iocmd->adapter_hwpath[++i] !=':' && i <BFA_STRING_32 -1 ; ) ; iocmd->adapter_hwpath[i] ='\0' ; iocmd->status =BFA_STATUS_OK ;