Input: stmpe-ts - drop obsolete dependency on COMPILE_TEST
Subsystems (2)
PATCH 1/1 Input: stmpe-ts - drop obsolete dependency on COMPILE_TEST
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed.
It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues.
--- drivers/input/touchscreen/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/Kconfig +1 -1
@@ -1241,7 +1241,7 @@ config TOUCHSCREEN_STMFTS config TOUCHSCREEN_STMPE tristate "STMicroelectronics STMPE touchscreens" depends on MFD_STMPE - depends on (OF || COMPILE_TEST) + depends on OF help Say Y here if you want support for STMicroelectronics STMPE touchscreen controllers.
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 13 lines · Jean Delvare
Since commit
0166dc11be91("of: makeCONFIG_OFuser selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending onCOMPILE_TESTas an alternative is no longer needed.It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping
COMPILE_TESThere improves the quality of our testing and avoids wasting time on non-existent issues.
Quoted 2 lines
Signed-off-by Jean Delvare <[email protected]>Cc Dmitry Torokhov <[email protected]>
Applied, thank you.
Signature · 1 line
Dmitry