Skip to contentSkip to conversation

ov08x40: remove() now returns void

PATCH In review Sakari Ailus 2 participants 3 messages Nov 21, 2022

Subsystems (3)
lore
Share & tools
lore

Sakari Ailus

author maintainer
#0 lore raw

PATCH 1/1 ov08x40: remove() now returns void

The return type of the driver's remove() callback is now void. This driver got merged while the return type got changed tree-wide. Fix this.

Fixes 38fc5136ac16 ("media: i2c: Add ov08x40 image sensor driver")
---
 drivers/media/i2c/ov08x40.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/media/i2c/ov08x40.c +1 -3
index b4ade17a83f5e..72ae7fba94eb0 100644
@@ -3281,7 +3281,7 @@ static int ov08x40_probe(struct i2c_client *client)
 	return ret;
 }
 
-static int ov08x40_remove(struct i2c_client *client)
+static void ov08x40_remove(struct i2c_client *client)
 {
 	struct v4l2_subdev *sd = i2c_get_clientdata(client);
 	struct ov08x40 *ov08x = to_ov08x40(sd);
@@ -3292,8 +3292,6 @@ static int ov08x40_remove(struct i2c_client *client)
 
 	pm_runtime_disable(&client->dev);
 	pm_runtime_set_suspended(&client->dev);
-
-	return 0;
 }
 
 static const struct dev_pm_ops ov08x40_pm_ops = {
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw

Hi Sakari,

Quoting Sakari Ailus (2022-11-21 17:34:53)

Quoted 6 lines

The return type of the driver's remove() callback is now void. This driver got merged while the return type got changed tree-wide. Fix this.

Fixes 38fc5136ac16 ("media: i2c: Add ov08x40 image sensor driver")

Kieran: Mon, 21 Nov 2022 17:34:47 +0000
Sakari: Mon, 21 Nov 2022 19:34:53 +0200

Aha, so I got my v1 out 6 seconds before you ;-) Quite the tense race
...

But I'll not worry - yours is probably already in your tree, so:

Quoted 29 lines
---
 drivers/media/i2c/ov08x40.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/media/i2c/ov08x40.c +1 -3
index b4ade17a83f5e..72ae7fba94eb0 100644
@@ -3281,7 +3281,7 @@ static int ov08x40_probe(struct i2c_client *client)
        return ret;
 }
 
-static int ov08x40_remove(struct i2c_client *client)
+static void ov08x40_remove(struct i2c_client *client)
 {
        struct v4l2_subdev *sd = i2c_get_clientdata(client);
        struct ov08x40 *ov08x = to_ov08x40(sd);
@@ -3292,8 +3292,6 @@ static int ov08x40_remove(struct i2c_client *client)
 
        pm_runtime_disable(&client->dev);
        pm_runtime_set_suspended(&client->dev);
-
-       return 0;
 }
 
 static const struct dev_pm_ops ov08x40_pm_ops = {
Signature · 1 line
2.30.2
author maintainer
#2 lore raw

Hi Kieran,

Quoted 13 lines · Kieran Bingham

Hi Sakari,

Quoting Sakari Ailus (2022-11-21 17:34:53)

Quoted 6 lines

The return type of the driver's remove() callback is now void. This driver got merged while the return type got changed tree-wide. Fix this.

Fixes 38fc5136ac16 ("media: i2c: Add ov08x40 image sensor driver")

Kieran: Mon, 21 Nov 2022 17:34:47 +0000
Sakari: Mon, 21 Nov 2022 19:34:53 +0200

Quoted 6 lines

Aha, so I got my v1 out 6 seconds before you ;-) Quite the tense race
...

But I'll not worry - yours is probably already in your tree, so:

Thanks!

The SMTP standard does not define what time the Date: header signifies, it could have been set by the sender or another server later on... but in this case git send-email probably set it in both cases.

I haven't pushed my tree to linuxtv.org yet and yours has a better commit message so I'll take it instead.

Signature · 1 line
Sakari Ailus