Skip to contentSkip to conversation

virtio: disable error for out of spec queue-enable

PATCH New Michael S. Tsirkin 1 participant 1 message Nov 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio: disable error for out of spec queue-enable

Virtio 1.0 is pretty clear that features have to be negotiated before enabling VQs. Unfortunately Seabios ignored this ever since gaining 1.0 support (UEFI is ok). Comment the error out for now, and add a TODO.

Fixes 3c37f8b8d1 ("virtio: introduce virtio_queue_enable()")
Cc "Kangjie Xu" <[email protected]>
---
 hw/virtio/virtio.c | 7 +++++++
 1 file changed, 7 insertions(+)
hw/virtio/virtio.c +7 -0
index 9683b2e158..eb6347ab5d 100644
@@ -2499,10 +2499,17 @@ void virtio_queue_enable(VirtIODevice *vdev, uint32_t queue_index)
 {
     VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev);
 
+    /*
+     * TODO: Seabios is currently out of spec and triggering this error.
+     * So this needs to be fixed in Seabios, then this can
+     * be re-enabled for new machine types only, and also after
+     * being converted to LOG_GUEST_ERROR.
+     *
     if (!virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) {
         error_report("queue_enable is only suppported in devices of virtio "
                      "1.0 or later.");
     }
+    */
 
     if (k->queue_enable) {
         k->queue_enable(vdev, queue_index);
Signature · 1 line
MST