Skip to contentSkip to conversation

SPI: GD SPI, enable GIGADEVICE in the config file

PATCH In review Victor Lim 3 participants 3 messages Nov 22, 2022 Arm/Zynq architecture

lore
Share & tools
lore

Victor Lim

author
#0 lore raw

PATCH 1/1 SPI: GD SPI, enable GIGADEVICE in the config file

Added GIGADEVICE=y in the defconfig files

---
 configs/xilinx_zynqmp_mini_qspi_defconfig | 1 +
 configs/zynq_cse_qspi_defconfig           | 1 +
 2 files changed, 2 insertions(+)
configs/xilinx_zynqmp_mini_qspi_defconfig +1 -0
index c6401c2a54..75014117f1 100644
@@ -78,3 +78,4 @@ CONFIG_ZYNQMP_GQSPI=y
 CONFIG_PANIC_HANG=y
 # CONFIG_GZIP is not set
 # CONFIG_LMB is not set
+CONFIG_SPI_FLASH_GIGADEVICE=y
configs/zynq_cse_qspi_defconfig +1 -0
index 60f0d7cac4..cd245906ab 100644
@@ -76,3 +76,4 @@ CONFIG_ARM_DCC=y
 CONFIG_ZYNQ_QSPI=y
 # CONFIG_GZIP is not set
 # CONFIG_LMB is not set
+CONFIG_SPI_FLASH_GIGADEVICE=y
Signature · 1 line
2.25.1
#1 lore raw

Hi, Michal,

With this patch, I have only changed the defconfig files. Please see if this is ok.

Regards,

Victor

________________________________
From: Victor Lim <[email protected]>
Sent: Monday, November 21, 2022 13:58
To: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Vlim <[email protected]>
Subject: [PATCH] SPI: GD SPI, enable GIGADEVICE in the config file

此为外部邮件,谨防钓鱼邮件,请注意邮件是否涉及敏感信息

This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information

Added GIGADEVICE=y in the defconfig files

---
 configs/xilinx_zynqmp_mini_qspi_defconfig | 1 +
 configs/zynq_cse_qspi_defconfig           | 1 +
 2 files changed, 2 insertions(+)
configs/xilinx_zynqmp_mini_qspi_defconfig +1 -0
index c6401c2a54..75014117f1 100644
@@ -78,3 +78,4 @@ CONFIG_ZYNQMP_GQSPI=y
 CONFIG_PANIC_HANG=y
 # CONFIG_GZIP is not set
 # CONFIG_LMB is not set
+CONFIG_SPI_FLASH_GIGADEVICE=y
configs/zynq_cse_qspi_defconfig +1 -0
index 60f0d7cac4..cd245906ab 100644
@@ -76,3 +76,4 @@ CONFIG_ARM_DCC=y
 CONFIG_ZYNQ_QSPI=y
 # CONFIG_GZIP is not set
 # CONFIG_LMB is not set
+CONFIG_SPI_FLASH_GIGADEVICE=y

--
2.25.1

#2 lore raw

Hi Victor,
One small suggestion, kindly follow the linux kernel guidelines on sending emails,

Quoted 1 line

It’s also strongly recommended that you use plain text in your email body, for patches and other emails alike. https://useplaintext.email may be useful for information on how to configure your preferred email client, as well as listing recommended email clients should you not already have a preference

source:
https://www.kernel.org/doc/html/latest/process/email-clients.html

Quoted 7 lines · Vlim

Hi, Michal,

With this patch, I have only changed the defconfig files. Please see if this is ok.

Regards,

Quoted 7 lines

Victor

________________________________
From: Victor Lim <[email protected]>
Sent: Monday, November 21, 2022 13:58
To: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Vlim <[email protected]>
Subject: [PATCH] SPI: GD SPI, enable GIGADEVICE in the config file

Also, it is my opinion that
"xilinx: zynqmp: enable GIGADEVICE in the config file" would be a better suited title in this case.

Quoted 2 lines

此为外部邮件,谨防钓鱼邮件,请注意邮件是否涉及敏感信息

This does not seem to be plaintext, kindly remove these lines.

Quoted 2 lines

This is an external email, beware of phishing emails. Please pay close attention to whether the email contains sensitive information

This also should be removed as far as possible while sending to public mailing lists.

[...]

Signature · 2 lines
Thanks and Regards,
Dhruva Gole