powerpc/ps3: mark ps3_system_bus_type static
Subsystems (2)
PATCH 1/1 powerpc/ps3: mark ps3_system_bus_type static
ps3_system_bus_type is only used inside of system-bus.c, so remove the external declaration and the very outdated comment next to it.
Signed-off-by Christoph Hellwig <[email protected]>
--- arch/powerpc/include/asm/ps3.h | 4 ---- arch/powerpc/platforms/ps3/system-bus.c | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-)
arch/powerpc/include/asm/ps3.h +0 -4
@@ -425,10 +425,6 @@ static inline void *ps3_system_bus_get_drvdata(return dev_get_drvdata (&dev->core); } -/* These two need global scope for get_arch_dma_ops(). */ - -extern struct bus_type ps3_system_bus_type; -/* system manager */ struct ps3_sys_manager_ops {
arch/powerpc/platforms/ps3/system-bus.c +1 -1
@@ -466,7 +466,7 @@ static struct attribute *ps3_system_bus_dev_attrs[] = { };ATTRIBUTE_GROUPS (ps3_system_bus_dev); -struct bus_type ps3_system_bus_type = { +static struct bus_type ps3_system_bus_type = { .name ="ps3_system_bus" , .match = ps3_system_bus_match, .uevent = ps3_system_bus_uevent,
Signature · 1 line
2.30.2
Hi Christoph,
Quoted 8 lines · Christoph Hellwig
ps3_system_bus_typeis only used inside ofsystem-bus.c, so remove the external declaration and the very outdated comment next to it.Signed-off-by Christoph Hellwig <[email protected]>--- arch/powerpc/include/asm/ps3.h | 4 ---- arch/powerpc/platforms/ps3/system-bus.c | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-)
I tested this applied to v6.1-rc6 and it seems to be OK. Thanks for submitting.
Acked-by Geoff Levand <[email protected]>
Michael Ellerman
AppliedQuoted 4 lines · Christoph Hellwig
ps3_system_bus_typeis only used inside ofsystem-bus.c, so remove the external declaration and the very outdated comment next to it.
Applied to powerpc/next.
[1/1] powerpc/ps3: mark ps3_system_bus_type static
https://git.kernel.org/powerpc/c/dea681c91d3cd5326f87d0a3c93079573e22ce9a
cheers