Skip to contentSkip to conversation

powerpc/ps3: mark ps3_system_bus_type static

PATCH Applied Christoph Hellwig 3 participants 3 messages Nov 22, 2022 – Dec 8, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/ps3: mark ps3_system_bus_type static

ps3_system_bus_type is only used inside of system-bus.c, so remove the external declaration and the very outdated comment next to it.

---
 arch/powerpc/include/asm/ps3.h          | 4 ----
 arch/powerpc/platforms/ps3/system-bus.c | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)
arch/powerpc/include/asm/ps3.h +0 -4
index 8a0d8fb3532863..d503dbd7856cb8 100644
@@ -425,10 +425,6 @@ static inline void *ps3_system_bus_get_drvdata(
 	return dev_get_drvdata(&dev->core);
 }
 
-/* These two need global scope for get_arch_dma_ops(). */
-
-extern struct bus_type ps3_system_bus_type;
-
 /* system manager */
 
 struct ps3_sys_manager_ops {
arch/powerpc/platforms/ps3/system-bus.c +1 -1
index 2502e9b17df4ab..38a7e02295c8f2 100644
@@ -466,7 +466,7 @@ static struct attribute *ps3_system_bus_dev_attrs[] = {
 };
 ATTRIBUTE_GROUPS(ps3_system_bus_dev);
 
-struct bus_type ps3_system_bus_type = {
+static struct bus_type ps3_system_bus_type = {
 	.name = "ps3_system_bus",
 	.match = ps3_system_bus_match,
 	.uevent = ps3_system_bus_uevent,
Signature · 1 line
2.30.2
maintainer Acked-by on v1 1/1
#1 lore raw

Hi Christoph,

Quoted 8 lines · Christoph Hellwig

ps3_system_bus_type is only used inside of system-bus.c, so remove the external declaration and the very outdated comment next to it.

---
 arch/powerpc/include/asm/ps3.h          | 4 ----
 arch/powerpc/platforms/ps3/system-bus.c | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

I tested this applied to v6.1-rc6 and it seems to be OK. Thanks for submitting.