Skip to contentSkip to conversation

drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec

PATCH Applied Frieder Schrempf 4 participants 4 messages Nov 22, 2022 – Nov 24, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec

From: Frieder Schrempf <[email protected]>

The datasheet specifies a delay of 10 milliseconds, but the current driver only waits for 1 ms. Fix this to make sure the initialization sequence meets the spec.

Fixes ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver")
---
 drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/bridge/ti-sn65dsi83.c +1 -1
index 7ba9467fff12..047c14ddbbf1 100644
@@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge,
 
 	/* Deassert reset */
 	gpiod_set_value_cansleep(ctx->enable_gpio, 1);
-	usleep_range(1000, 1100);
+	usleep_range(10000, 11000);
 
 	/* Get the LVDS format from the bridge state. */
 	bridge_state = drm_atomic_get_new_bridge_state(state, bridge);
Signature · 1 line
2.38.1
Reviewed-by on v1 1/1
#1 lore raw

Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf:

Quoted 27 lines

From: Frieder Schrempf <[email protected]>

The datasheet specifies a delay of 10 milliseconds, but the current driver only waits for 1 ms. Fix this to make sure the initialization sequence meets the spec.

Fixes ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and

SN65DSI84 driver") Signed-off-by: Frieder Schrempf <[email protected]>

---
 drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1 100644

drivers/gpu/drm/bridge/ti-sn65dsi83.c +1 -1
@@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge
 *bridge,
 
 	/* Deassert reset */
 	gpiod_set_value_cansleep(ctx->enable_gpio, 1);
-	usleep_range(1000, 1100);
+	usleep_range(10000, 11000);
 
 	/* Get the LVDS format from the bridge state. */
Quoted 1 line

bridge_state = drm_atomic_get_new_bridge_state(state, bridge);

How about using fsleep?

Either way:

#2 lore raw
Quoted 27 lines · Alexander Stein

Am Dienstag, 22. November 2022, 09:12:18 CET schrieb Frieder Schrempf:

Quoted 26 lines

From: Frieder Schrempf <[email protected]>

The datasheet specifies a delay of 10 milliseconds, but the current driver only waits for 1 ms. Fix this to make sure the initialization sequence meets the spec.

Fixes ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and

SN65DSI84 driver") Signed-off-by: Frieder Schrempf <[email protected]>

---
 drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1 100644

drivers/gpu/drm/bridge/ti-sn65dsi83.c +1 -1
@@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge
 *bridge,
 
 	/* Deassert reset */
 	gpiod_set_value_cansleep(ctx->enable_gpio, 1);
-	usleep_range(1000, 1100);
+	usleep_range(10000, 11000);
 
Quoted 7 lines
Quoted 2 lines
drivers/gpu/drm/bridge/ti-sn65dsi83.c +0 -0
 	/* Get the LVDS format from the bridge state. */

bridge_state = drm_atomic_get_new_bridge_state(state, bridge);

How about using fsleep?

Either way:

Thanks for the review! I didn't know about fsleep. Anyway this would probably be a separate change as the driver currently uses usleep everywhere else. But I will keep it in mind for the future.