Skip to contentSkip to conversation

imx8qm-rom7720: fix broken boot caused by missing CONFIG_EVENT

PATCH In review Oliver Graute 3 participants 3 messages Nov 22, 2022 – Dec 2, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx8qm-rom7720: fix broken boot caused by missing CONFIG_EVENT

since commit c5ef2025579e91f132cd3cead8ebe8b4cd5dd2b6
its necessary to set CONFIG_EVENT for a successful boot of this board again

---
 configs/imx8qm_rom7720_a1_4G_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/imx8qm_rom7720_a1_4G_defconfig +1 -0
index afec319640..002babeff2 100644
@@ -90,6 +90,7 @@ CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
 CONFIG_SPL_DM_REGULATOR_GPIO=y
 CONFIG_DM_SERIAL=y
+CONFIG_EVENT=y
 CONFIG_FSL_LPUART=y
 CONFIG_SPL_TINY_MEMSET=y
 # CONFIG_EFI_LOADER is not set
Signature · 1 line
2.17.1
reviewer
#1 lore raw

Hi Heinrich,

Quoted 15 lines · Oliver Graute

since commit c5ef2025579e91f132cd3cead8ebe8b4cd5dd2b6
its necessary to set CONFIG_EVENT for a successful boot of this board again

---
 configs/imx8qm_rom7720_a1_4G_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/imx8qm_rom7720_a1_4G_defconfig +0 -0
index afec319640..002babeff2 100644

configs/imx8qm_rom7720_a1_4G_defconfig CONFIG_DM_REGULATOR_FIXED=y · line 93

Quoted 4 lines
configs/imx8qm_rom7720_a1_4G_defconfig +1 -0
@@ -90,6 +90,7 @@ CONFIG_DM_REGULATOR_FIXED=y
 CONFIG_DM_REGULATOR_GPIO=y
 CONFIG_SPL_DM_REGULATOR_GPIO=y
 CONFIG_DM_SERIAL=y
+CONFIG_EVENT=y

Could you please take a look? What is the proper fix for this issue?

Thanks

#2 lore raw
Quoted 26 lines · Fabio Estevam

Hi Heinrich,

Quoted 15 lines · Oliver Graute

since commit c5ef2025579e91f132cd3cead8ebe8b4cd5dd2b6
its necessary to set CONFIG_EVENT for a successful boot of this board again

---
  configs/imx8qm_rom7720_a1_4G_defconfig | 1 +
  1 file changed, 1 insertion(+)
configs/imx8qm_rom7720_a1_4G_defconfig +0 -0
index afec319640..002babeff2 100644

configs/imx8qm_rom7720_a1_4G_defconfig CONFIG_DM_REGULATOR_FIXED=y · line 93

Quoted 4 lines
configs/imx8qm_rom7720_a1_4G_defconfig +1 -0
@@ -90,6 +90,7 @@ CONFIG_DM_REGULATOR_FIXED=y
  CONFIG_DM_REGULATOR_GPIO=y
  CONFIG_SPL_DM_REGULATOR_GPIO=y
  CONFIG_DM_SERIAL=y
+CONFIG_EVENT=y

Could you please take a look? What is the proper fix for this issue?

Quoted 1 line

Thanks

Hello Simon,

in lots of places we have 'imply DM_EVENT' which of course has no effect if CONFIG_EVENT=n.

We always have CONFIG_DM=y. Why do we need separate symbols CONFIG_EVENT and CONFIG_DM_EVENT?

Can we drop CONFIG_DM_EVENT? This should resolve the problem booting boards with CONFIG_EFI_LOADER=n that Fabio reported.

Best regards

Heinrich