Skip to contentSkip to conversation

bus: imx-weim: use devm_platform_get_and_ioremap_resource()

PATCH Applied [email protected] 3 participants 3 messages Nov 22, 2022 – Dec 31, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 bus: imx-weim: use devm_platform_get_and_ioremap_resource()

From: Minghao Chi <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

Signed-off-by Minghao Chi <[email protected]>
Signed-off-by ye xingchen <[email protected]>
---
 drivers/bus/imx-weim.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/bus/imx-weim.c +1 -3
index 828c66bbaa67..2a6b4f676458 100644
@@ -263,7 +263,6 @@ static int weim_parse_dt(struct platform_device *pdev)
 static int weim_probe(struct platform_device *pdev)
 {
 	struct weim_priv *priv;
-	struct resource *res;
 	struct clk *clk;
 	void __iomem *base;
 	int ret;

@@ -273,8 +272,7 @@ static int weim_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	/* get the resource */
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	base = devm_ioremap_resource(&pdev->dev, res);
+	base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(base))
 		return PTR_ERR(base);
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw

Hi Chi,

thanks for your patch.

Quoted 8 lines · On 22-11-22, [email protected] wrote:

From: Minghao Chi <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

Signed-off-by Minghao Chi <[email protected]>
Signed-off-by ye xingchen <[email protected]>

LGTM, feel free to add my

Reviewed-by Marco Felsch <[email protected]>
Quoted 30 lines
---
 drivers/bus/imx-weim.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/bus/imx-weim.c +1 -3
index 828c66bbaa67..2a6b4f676458 100644
@@ -263,7 +263,6 @@ static int weim_parse_dt(struct platform_device *pdev)
 static int weim_probe(struct platform_device *pdev)
 {
 	struct weim_priv *priv;
-	struct resource *res;
 	struct clk *clk;
 	void __iomem *base;
 	int ret;

@@ -273,8 +272,7 @@ static int weim_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	/* get the resource */
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	base = devm_ioremap_resource(&pdev->dev, res);
+	base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 	if (IS_ERR(base))
 		return PTR_ERR(base);
Signature · 1 line
2.25.1