Skip to contentSkip to conversation

mtd: rawnand: orion: use devm_platform_get_and_ioremap_resource()

PATCH Superseded [email protected] 2 participants 2 messages Nov 22, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: rawnand: orion: use devm_platform_get_and_ioremap_resource()

From: Minghao Chi <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

---
 drivers/mtd/nand/raw/orion_nand.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/mtd/nand/raw/orion_nand.c +1 -3
index 1bfecf502216..00bd7be76e07 100644
@@ -102,7 +102,6 @@ static int __init orion_nand_probe(struct platform_device *pdev)
 	struct mtd_info *mtd;
 	struct nand_chip *nc;
 	struct orion_nand_data *board;
-	struct resource *res;
 	void __iomem *io_base;
 	int ret = 0;
 	u32 val = 0;
@@ -119,8 +118,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
 	info->controller.ops = &orion_nand_ops;
 	nc->controller = &info->controller;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	io_base = devm_ioremap_resource(&pdev->dev, res);
+	io_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
 
 	if (IS_ERR(io_base))
 		return PTR_ERR(io_base);
Signature · 1 line
2.25.1
maintainer
#1 lore raw

Hello,

[email protected] wrote on Tue, 22 Nov 2022 09:33:27 +0800 (CST):

Quoted 2 lines

From: Minghao Chi <[email protected]>

Double space in the subject

Quoted 22 lines

Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.

---
 drivers/mtd/nand/raw/orion_nand.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/mtd/nand/raw/orion_nand.c +0 -1
index 1bfecf502216..00bd7be76e07 100644
@@ -102,7 +102,6 @@ static int __init orion_nand_probe(struct platform_device *pdev)
 	struct mtd_info *mtd;
 	struct nand_chip *nc;
 	struct orion_nand_data *board;
-	struct resource *res;
 	void __iomem *io_base;
 	int ret = 0;
 	u32 val = 0;

drivers/mtd/nand/raw/orion_nand.c static int __init orion_nand_probe(struct platform_device *pdev) · line 121

Quoted 6 lines
drivers/mtd/nand/raw/orion_nand.c +1 -2
@@ -119,8 +118,7 @@ static int __init orion_nand_probe(struct platform_device *pdev)
 	info->controller.ops = &orion_nand_ops;
 	nc->controller = &info->controller;
 
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	io_base = devm_ioremap_resource(&pdev->dev, res);
+	io_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

If we no longer use res, why not just devm_platform_ioremap_resource() ?

drivers/mtd/nand/raw/orion_nand.c static int __init orion_nand_probe(struct platform_device *pdev) · line 124

Quoted 3 lines
drivers/mtd/nand/raw/orion_nand.c +0 -0
 	if (IS_ERR(io_base))
 		return PTR_ERR(io_base);

Thanks,
Miquèl