Skip to contentSkip to conversation

generic/614: Run test only for filesystems supporting delalloc

PATCH In review Jan Kara 2 participants 2 messages Nov 22, 2022

lore
Share & tools
lore

Jan Kara

author
#0 lore raw

PATCH 1/1 generic/614: Run test only for filesystems supporting delalloc

Simple filesystems such as ext2 or udf do not support delayed allocation. Thus they allocate data blocks for mmap writes only during writeback. This makes test generic/614 fail because it checks exactly whether the blocks for the write are reserved before writeback happens. Make the test depend on delayed allocation support.

---
 tests/generic/614 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/614 +1 -0
index 06630f2249c7..3e2a587c8f90 100755
@@ -16,6 +16,7 @@ _begin_fstest auto quick rw
 # real QA test starts here
 _supported_fs generic
 _require_scratch
+_require_scratch_delalloc
 
 _scratch_mkfs >>$seqres.full 2>&1
 _scratch_mount
Signature · 1 line
2.35.3
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Jan Kara

Simple filesystems such as ext2 or udf do not support delayed allocation. Thus they allocate data blocks for mmap writes only during writeback. This makes test generic/614 fail because it checks exactly whether the blocks for the write are reserved before writeback happens. Make the test depend on delayed allocation support.

Looks good. I wasn't aware that a _require_scratch_delalloc helper existed already.

Thanks.

Quoted 19 lines
---
 tests/generic/614 | 1 +
 1 file changed, 1 insertion(+)
tests/generic/614 +1 -1
index 06630f2249c7..3e2a587c8f90 100755
@@ -16,6 +16,7 @@ _begin_fstest auto quick rw
 # real QA test starts here
 _supported_fs generic
 _require_scratch
+_require_scratch_delalloc
 
 _scratch_mkfs >>$seqres.full 2>&1
 _scratch_mount
--

2.35.3