net/tcp: Dynamically disable TCP-MD5 static key
Subsystems (4)
v5 cover net/tcp: Dynamically disable TCP-MD5 static key
Changes from v4:
- Used rcu_dereference_protected() for tp->md5sig_info in tcp_md5_do_add() and tcp_md5_key_copy() fail paths to make sure there won't be false-positives from sparse (Jakub)
- Added Acked-by: Jakub Kicinski
Changes from v3:
- Used atomic_try_cmpxchg() as suggested by Peter Zijlstra
- Renamed static_key_fast_inc() => static_key_fast_inc_not_negative() (addressing Peter Zijlstra's review)
- Based on linux-tip/master
- tcp_md5_key_copy() now does net_warn_ratelimited() (addressing Peter Zijlstra's review)
tcp_md5_do_add() does not as it returns -EUSERS from setsockopt() syscall back to the userspace
- Corrected WARN_ON_ONCE(!static_key_fast_inc(key)) (Spotted by Jason Baron)
- Moved declaration of static_key_fast_inc_not_negative() and its EXPORT_SYMBOL_GPL() to the patch 3 that uses it, "net/tcp: Disable TCP-MD5 static key on tcp_md5sig_info destruction" (addressing Peter Zijlstra's review)
- Added patch 4 that destroys the newly created request socket if md5 info allocation or static_key increment was unsuccessful. Instead of proceeding to add a socket without TCP-MD5 keys.
- Added patch 5 that separates helper tcp_time_wait_init() and converts BUG_ON() to WARN_ON_ONCE().
Changes from v2:
- Prevent key->enabled from turning negative by overflow from static_key_slow_inc() or static_key_fast_inc() (addressing Peter Zijlstra's review)
- Added checks if static_branch_inc() and static_key_fast_int() were successful to TCP-MD5 code.
Changes from v1:
- Add static_key_fast_inc() helper rather than open-coded atomic_inc() (as suggested by Eric Dumazet)
Version 4:
https://lore.kernel.org/all/[email protected]/T/#u
Version 3:
https://lore.kernel.org/all/[email protected]/T/#u
Version 2:
https://lore.kernel.org/all/[email protected]/T/#u
Version 1:
https://lore.kernel.org/all/[email protected]/T/#u
The static key introduced by commit 6015c71e656b ("tcp: md5: add tcp_md5_needed jump label") is a fast-path optimization aimed at avoiding a cache line miss.
Once an MD5 key is introduced in the system the static key is enabled and never disabled. Address this by disabling the static key when the last tcp_md5sig_info in system is destroyed.
Previously it was submitted as a part of TCP-AO patches set [1]. Now in attempt to split 36 patches submission, I send this independently.
[1]: https://lore.kernel.org/all/[email protected]/T/#u
Thanks,
Dmitry
Dmitry Safonov (5):
jump_label: Prevent key->enabled int overflow net/tcp: Separate tcp_md5sig_info allocation into
tcp_md5sig_info_add()
net/tcp: Disable TCP-MD5 static key on tcp_md5sig_info destruction net/tcp: Do cleanup on tcp_md5_key_copy() failure net/tcp: Separate initialization of twsk
include/linux/jump_label.h | 21 +++++++-- include/net/tcp.h | 10 ++-- kernel/jump_label.c | 55 +++++++++++++++++----- net/ipv4/tcp.c | 5 +- net/ipv4/tcp_ipv4.c | 96 +++++++++++++++++++++++++++++--------- net/ipv4/tcp_minisocks.c | 61 +++++++++++++++--------- net/ipv4/tcp_output.c | 4 +- net/ipv6/tcp_ipv6.c | 21 ++++----- 8 files changed, 193 insertions(+), 80 deletions(-)
base-commit: 771a207d1ee9f38da8c0cee1412228f18b900bac
Signature · 1 line
2.38.1
PATCH v5 1/5 jump_label: Prevent key->enabled int overflow
1. With CONFIG_JUMP_LABEL=n static_key_slow_inc() doesn't have any protection against key->enabled refcounter overflow.
2. With CONFIG_JUMP_LABEL=y static_key_slow_inc_cpuslocked() still may turn the refcounter negative as (v + 1) may overflow.
key->enabled is indeed a ref-counter as it's documented in multiple
places: top comment in jump_label.h, Documentation/staging/static-keys.rst, etc.
As -1 is reserved for static key that's in process of being enabled, functions would break with negative key->enabled refcount:
- for CONFIG_JUMP_LABEL=n negative return of static_key_count() breaks static_key_false(), static_key_true()
- the ref counter may become 0 from negative side by too many static_key_slow_inc() calls and lead to use-after-free issues.
These flaws result in that some users have to introduce an additional mutex and prevent the reference counter from overflowing themselves, see bpf_enable_runtime_stats() checking the counter against INT_MAX / 2.
Prevent the reference counter overflow by checking if (v + 1) > 0. Change functions API to return whether the increment was successful.
--- include/linux/jump_label.h | 19 +++++++++++--- kernel/jump_label.c | 54 +++++++++++++++++++++++++++++--------- 2 files changed, 57 insertions(+), 16 deletions(-)
include/linux/jump_label.h +15 -4
@@ -224,9 +224,9 @@ extern bool arch_jump_label_transform_queue(struct jump_entry *entry, enum jump_label_type type);extern void arch_jump_label_transform_apply (void );extern int jump_label_text_reserved (void *start,void *end); -extern void static_key_slow_inc (struct static_key *key); +extern bool static_key_slow_inc (struct static_key *key);extern void static_key_slow_dec (struct static_key *key); -extern void static_key_slow_inc_cpuslocked (struct static_key *key); +extern bool static_key_slow_inc_cpuslocked (struct static_key *key);extern void static_key_slow_dec_cpuslocked (struct static_key *key);extern int static_key_count (struct static_key *key);extern void static_key_enable (struct static_key *key);
@@ -278,10 +278,21 @@ static __always_inline bool static_key_true(struct static_key *key)return false; } -static inline void static_key_slow_inc (struct static_key *key) +static inline bool static_key_slow_inc (struct static_key *key) { +int v; +STATIC_KEY_CHECK_USE (key); -atomic_inc (&key->enabled); +/* +* Prevent key->enabled getting negative to follow the same semantics +* as for CONFIG_JUMP_LABEL=y, see kernel/jump_label.c comment. +*/ + v =atomic_read (&key->enabled); +do { +if (v <0 || (v +1 ) <0 ) +return false; + }while (!likely (atomic_try_cmpxchg (&key->enabled, &v, v +1 ))); +return true; }static inline void static_key_slow_dec (struct static_key *key)
kernel/jump_label.c +42 -12
82 lines not on this page · raw message
Signature · 1 line
2.38.1
Peter Zijlstra
maintainerRe: [PATCH v5 1/5] jump_label: Prevent key->enabled int overflow
Quoted 10 lines · Dmitry Safonov
+/***
+ *static_key_fast_inc_not_negative- adds a user for a static key
+ * @key: static key that must be already enabled
+ *
+ * The caller must make sure that the static key can't get disabled while
+ * in this function. It doesn't patch jump labels, only adds a user to
+ * an already enabled static key.
+ *
+ * Returns true if the increment was done.
+ */
I don't normally do kerneldoc style comments, and this is the first in the whole file. The moment I get a docs person complaining about some markup issue I just take the ** off.
Quoted 9 lines
kernel/jump_label.c +7
-0+static bool static_key_fast_inc_not_negative (struct static_key *key) { +int v; +STATIC_KEY_CHECK_USE (key); +/* +* Negative key->enabled has a special meaning: it sends +* static_key_slow_inc() down the slow path, and it is non-zero +* so it counts as "enabled" in jump_label_update(). Note that
kernel/jump_label.c int static_key_count(struct static_key *key) · line 144
Quoted 10 lines
kernel/jump_label.c +10
-0+* atomic_inc_unless_negative() checks >= 0, so roll our own. +*/ + v =atomic_read (&key->enabled); +do { +if (v <=0 || (v +1 ) <0 ) +return false; + }while (!likely (atomic_try_cmpxchg (&key->enabled, &v, v +1 ))); + +return true; +}
( vexing how this function and the JUMP_LABEL=n static_key_slow_inc() are
only a single character different )
So while strictly accurate, I dislike this name (and I see I was not quick enough responding to your earlier suggestion :/). The whole negative thing is an implementation detail that should not spread outside of jump_label.c.
Since you did not like the canonical _inc_not_zero(), how about inc_not_disabled() ?
Also, perhaps expose this function in this patch, instead of hiding that in patch 3?
Otherwise, things look good.
Thanks!
Re: [PATCH v5 1/5] jump_label: Prevent key->enabled int overflow
Quoted 13 lines · Peter Zijlstra
Quoted 10 lines · Dmitry Safonov
+/***
+ *static_key_fast_inc_not_negative- adds a user for a static key
+ * @key: static key that must be already enabled
+ *
+ * The caller must make sure that the static key can't get disabled while
+ * in this function. It doesn't patch jump labels, only adds a user to
+ * an already enabled static key.
+ *
+ * Returns true if the increment was done.
+ */
Quoted 3 lines
I don't normally do kerneldoc style comments, and this is the first in the whole file. The moment I get a docs person complaining about some markup issue I just take the ** off.
The only reason I used kerneldoc style is that otherwise usually someone would come and complain. I'll convert it to a regular comment.
Quoted 2 lines
One more thing; it might be useful to point out that unlike
refcount_tthis thing does not saturate but will fail to increment on overflow.
Will add it as well.
Quoted 15 lines
Quoted 15 lines
kernel/jump_label.c +12
-0+static bool static_key_fast_inc_not_negative (struct static_key *key) { +int v; +STATIC_KEY_CHECK_USE (key); +/* +* Negative key->enabled has a special meaning: it sends +* static_key_slow_inc() down the slow path, and it is non-zero +* so it counts as "enabled" in jump_label_update(). Note that +* atomic_inc_unless_negative() checks >= 0, so roll our own. +*/ + v =atomic_read (&key->enabled); + do { + if (v <= 0 || (v + 1) < 0)
Quoted 8 lines
kernel/jump_label.c int static_key_count(struct static_key *key) · line 144
Quoted 5 lines
kernel/jump_label.c +5
-0+return false; + }while (!likely (atomic_try_cmpxchg (&key->enabled, &v, v +1 ))); + +return true; +}( vexing how this function and the JUMP_LABEL=n
static_key_slow_inc()are
only a single character different )
Yeah, also another reason for it was that when JUMP_LABEL=y jump_label.h doesn't include <linux/atomic.h> and <linux/bug.h> because of the inclusion hell:
commit 1f69bf9c6137 ("jump_label: remove bug.h, atomic.h dependencies for HAVE_JUMP_LABEL")
and I can't move JUMP_LABEL=n version of static_key_slow_inc() to jump_label.c as it is not being built without the config set.
So, in result I was looking into macro-define for both cases, but that adds quite some ugliness and has no type checks for just reusing 10 lines, where 1 differs...
Quoted 7 lines
So while strictly accurate, I dislike this name (and I see I was not quick enough responding to your earlier suggestion :/). The whole negative thing is an implementation detail that should not spread outside of
jump_label.c.Since you did not like the canonical
_inc_not_zero(), how aboutinc_not_disabled()?
Ok, that sounds good, I'll rename in v6.
Quoted 2 lines
Also, perhaps expose this function in this patch, instead of hiding that in patch 3?
Will do.
Quoted 3 lines
Otherwise, things look good.
Thanks!
Thanks again for the review,
Dmitry
Peter Zijlstra
maintainerRe: [PATCH v5 1/5] jump_label: Prevent key->enabled int overflow
In reply to Dmitry SafonovQuoted 4 lines · Dmitry Safonov
key->enabledis indeed a ref-counter as it's documented in multiple
places: top comment injump_label.h,Documentation/staging/static-keys.rst, etc.
Quoted 10 lines
+/***
+ *static_key_fast_inc_not_negative- adds a user for a static key
+ * @key: static key that must be already enabled
+ *
+ * The caller must make sure that the static key can't get disabled while
+ * in this function. It doesn't patch jump labels, only adds a user to
+ * an already enabled static key.
+ *
+ * Returns true if the increment was done.
+ */
One more thing; it might be useful to point out that unlike refcount_t this thing does not saturate but will fail to increment on overflow.
PATCH v5 2/5 net/tcp: Separate tcp_md5sig_info allocation into tcp_md5sig_info_add()
In reply to Dmitry SafonovAdd a helper to allocate tcp_md5sig_info, that will help later to do/allocate things when info allocated, once per socket.
--- net/ipv4/tcp_ipv4.c | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-)
net/ipv4/tcp_ipv4.c +21 -9
@@ -1172,6 +1172,24 @@ struct tcp_md5sig_key *tcp_v4_md5_lookup(const struct sock *sk, }EXPORT_SYMBOL (tcp_v4_md5_lookup); +static int tcp_md5sig_info_add (struct sock *sk,gfp_t gfp) +{ +struct tcp_sock *tp =tcp_sk (sk); +struct tcp_md5sig_info *md5sig; + +if (rcu_dereference_protected (tp->md5sig_info,lockdep_sock_is_held (sk))) +return 0 ; + + md5sig =kmalloc (sizeof (*md5sig), gfp); +if (!md5sig) +return -ENOMEM ; + +sk_gso_disable (sk); +INIT_HLIST_HEAD (&md5sig->head); +rcu_assign_pointer (tp->md5sig_info, md5sig); +return 0 ; +} +/* This can be called on a newly created socket, from other files */ int tcp_md5_do_add(struct sock *sk, const union tcp_md5_addr *addr, int family, u8 prefixlen, int l3index, u8 flags,
@@ -1202,17 +1220,11 @@ int tcp_md5_do_add(struct sock *sk, const union tcp_md5_addr *addr,return 0 ; } +if (tcp_md5sig_info_add (sk, gfp)) +return -ENOMEM ; + md5sig =rcu_dereference_protected (tp->md5sig_info,lockdep_sock_is_held (sk)); -if (!md5sig) { - md5sig =kmalloc (sizeof (*md5sig), gfp); -if (!md5sig) -return -ENOMEM ; - -sk_gso_disable (sk); -INIT_HLIST_HEAD (&md5sig->head); -rcu_assign_pointer (tp->md5sig_info, md5sig); - } key =sock_kmalloc (sk,sizeof (*key), gfp | __GFP_ZERO);if (!key)
Signature · 1 line
2.38.1
PATCH v5 3/5 net/tcp: Disable TCP-MD5 static key on tcp_md5sig_info destruction
In reply to Dmitry SafonovTo do that, separate two scenarios:
- where it's the first MD5 key on the system, which means that enabling of the static key may need to sleep;
- copying of an existing key from a listening socket to the request socket upon receiving a signed TCP segment, where static key was already enabled (when the key was added to the listening socket).
Now the life-time of the static branch for TCP-MD5 is until:
- last tcp_md5sig_info is destroyed
- last socket in time-wait state with MD5 key is closed.
Which means that after all sockets with TCP-MD5 keys are gone, the system gets back the performance of disabled md5-key static branch.
While at here, provide static_key_fast_inc() helper that does ref counter increment in atomic fashion (without grabbing cpus_read_lock() on CONFIG_JUMP_LABEL=y). This is needed to add a new user for a static_key when the caller controls the lifetime of another user.
--- include/linux/jump_label.h | 4 ++- include/net/tcp.h | 10 ++++-- kernel/jump_label.c | 3 +- net/ipv4/tcp.c | 5 +-- net/ipv4/tcp_ipv4.c | 71 +++++++++++++++++++++++++++++++------- net/ipv4/tcp_minisocks.c | 16 ++++++--- net/ipv4/tcp_output.c | 4 +-- net/ipv6/tcp_ipv6.c | 10 +++--- 8 files changed, 89 insertions(+), 34 deletions(-)
include/linux/jump_label.h +3 -1
@@ -225,6 +225,7 @@ extern bool arch_jump_label_transform_queue(struct jump_entry *entry,extern void arch_jump_label_transform_apply (void );extern int jump_label_text_reserved (void *start,void *end);extern bool static_key_slow_inc (struct static_key *key); +extern bool static_key_fast_inc_not_negative (struct static_key *key);extern void static_key_slow_dec (struct static_key *key);extern bool static_key_slow_inc_cpuslocked (struct static_key *key);extern void static_key_slow_dec_cpuslocked (struct static_key *key);
@@ -278,7 +279,7 @@ static __always_inline bool static_key_true(struct static_key *key)return false; } -static inline bool static_key_slow_inc (struct static_key *key) +static inline bool static_key_fast_inc_not_negative (struct static_key *key) {int v;
@@ -294,6 +295,7 @@ static inline bool static_key_slow_inc(struct static_key *key) }while (!likely (atomic_try_cmpxchg (&key->enabled, &v, v +1 )));return true; } +#define static_key_slow_inc (key) static_key_fast_inc_not_negative(key)static inline void static_key_slow_dec (struct static_key *key) {
include/net/tcp.h +7 -3
@@ -1675,7 +1675,11 @@ int tcp_v4_md5_hash_skb(char *md5_hash, const struct tcp_md5sig_key *key, const struct sock *sk, const struct sk_buff *skb);int tcp_md5_do_add (struct sock *sk,const union tcp_md5_addr *addr,int family,u8 prefixlen,int l3index,u8 flags, -const u8 *newkey,u8 newkeylen,gfp_t gfp); +const u8 *newkey,u8 newkeylen); +int tcp_md5_key_copy (struct sock *sk,const union tcp_md5_addr *addr, +int family,u8 prefixlen,int l3index, +struct tcp_md5sig_key *key); +int tcp_md5_do_del (struct sock *sk,const union tcp_md5_addr *addr,int family,u8 prefixlen,int l3index,u8 flags); struct tcp_md5sig_key *tcp_v4_md5_lookup(const struct sock *sk,
@@ -1683,7 +1687,7 @@ struct tcp_md5sig_key *tcp_v4_md5_lookup(const struct sock *sk,#ifdef CONFIG_TCP_MD5SIG #include <linux/jump_label.h> -extern struct static_key_false tcp_md5_needed; +extern struct static_key_false_deferred tcp_md5_needed;struct tcp_md5sig_key *__tcp_md5_do_lookup (const struct sock *sk,int l3index,const union tcp_md5_addr *addr,int family);
@@ -1691,7 +1695,7 @@ static inline struct tcp_md5sig_key * tcp_md5_do_lookup(const struct sock *sk, int l3index, const union tcp_md5_addr *addr, int family) { - if (!static_branch_unlikely(&tcp_md5_needed)) + if (!static_branch_unlikely(&tcp_md5_needed.key)) return NULL;return __tcp_md5_do_lookup (sk, l3index, addr, family); }
kernel/jump_label.c +2 -1
@@ -123,7 +123,7 @@ EXPORT_SYMBOL_GPL(static_key_count);* * Returns true if the increment was done. */ -static bool static_key_fast_inc_not_negative (struct static_key *key) +bool static_key_fast_inc_not_negative (struct static_key *key) {int v;
@@ -142,6 +142,7 @@ static bool static_key_fast_inc_not_negative(struct static_key *key)return true; } +EXPORT_SYMBOL_GPL (static_key_fast_inc_not_negative);bool static_key_slow_inc_cpuslocked (struct static_key *key) {
net/ipv4/tcp.c +1 -4
@@ -4465,11 +4465,8 @@ bool tcp_alloc_md5sig_pool(void)if (unlikely (!READ_ONCE (tcp_md5sig_pool_populated))) {mutex_lock (&tcp_md5sig_mutex); -if (!tcp_md5sig_pool_populated) { +if (!tcp_md5sig_pool_populated)__tcp_alloc_md5sig_pool (); -if (tcp_md5sig_pool_populated) -static_branch_inc (&tcp_md5_needed); - }mutex_unlock (&tcp_md5sig_mutex); }
net/ipv4/tcp_ipv4.c +58 -13
121 lines not on this page · raw message
net/ipv4/tcp_minisocks.c +12 -4
@@ -291,13 +291,19 @@ void tcp_time_wait(struct sock *sk, int state, int timeo)*/ do { tcptw->tw_md5_key =NULL ; -if (static_branch_unlikely (&tcp_md5_needed)) { +if (static_branch_unlikely (&tcp_md5_needed.key)) {struct tcp_md5sig_key *key; key = tp->af_specific->md5_lookup (sk, sk);if (key) { tcptw->tw_md5_key =kmemdup (key,sizeof (*key),GFP_ATOMIC ); -BUG_ON (tcptw->tw_md5_key && !tcp_alloc_md5sig_pool ()); +if (!tcptw->tw_md5_key) +break ; +BUG_ON (!tcp_alloc_md5sig_pool ()); +if (!static_key_fast_inc_not_negative (&tcp_md5_needed.key.key)) { +kfree (tcptw->tw_md5_key); + tcptw->tw_md5_key =NULL ; + } } } }while (0 );
@@ -337,11 +343,13 @@ EXPORT_SYMBOL(tcp_time_wait);void tcp_twsk_destructor (struct sock *sk) {#ifdef CONFIG_TCP_MD5SIG -if (static_branch_unlikely (&tcp_md5_needed)) { +if (static_branch_unlikely (&tcp_md5_needed.key)) {struct tcp_timewait_sock *twsk =tcp_twsk (sk); -if (twsk->tw_md5_key) +if (twsk->tw_md5_key) {kfree_rcu (twsk->tw_md5_key, rcu); +static_branch_slow_dec_deferred (&tcp_md5_needed); + } }#endif }
net/ipv4/tcp_output.c +2 -2
@@ -766,7 +766,7 @@ static unsigned int tcp_syn_options(struct sock *sk, struct sk_buff *skb, *md5 =NULL ;#ifdef CONFIG_TCP_MD5SIG -if (static_branch_unlikely (&tcp_md5_needed) && +if (static_branch_unlikely (&tcp_md5_needed.key) &&rcu_access_pointer (tp->md5sig_info)) { *md5 = tp->af_specific->md5_lookup (sk, sk);if (*md5) {
@@ -922,7 +922,7 @@ static unsigned int tcp_established_options(struct sock *sk, struct sk_buff *skb *md5 =NULL ;#ifdef CONFIG_TCP_MD5SIG -if (static_branch_unlikely (&tcp_md5_needed) && +if (static_branch_unlikely (&tcp_md5_needed.key) &&rcu_access_pointer (tp->md5sig_info)) { *md5 = tp->af_specific->md5_lookup (sk, sk);if (*md5) {
net/ipv6/tcp_ipv6.c +4 -6
@@ -677,12 +677,11 @@ static int tcp_v6_parse_md5_keys(struct sock *sk, int optname,if (ipv6_addr_v4mapped (&sin6->sin6_addr))return tcp_md5_do_add (sk, (union tcp_md5_addr *)&sin6->sin6_addr.s6_addr32[3 ],AF_INET , prefixlen, l3index, flags, - cmd.tcpm_key, cmd.tcpm_keylen, -GFP_KERNEL ); + cmd.tcpm_key, cmd.tcpm_keylen);return tcp_md5_do_add (sk, (union tcp_md5_addr *)&sin6->sin6_addr,AF_INET6 , prefixlen, l3index, flags, - cmd.tcpm_key, cmd.tcpm_keylen,GFP_KERNEL ); + cmd.tcpm_key, cmd.tcpm_keylen); } static int tcp_v6_md5_hash_headers(struct tcp_md5sig_pool *hp,
@@ -1382,9 +1381,8 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff ** memory, then we end up not copying the key * across. Shucks. */ -tcp_md5_do_add (newsk, (union tcp_md5_addr *)&newsk->sk_v6_daddr, -AF_INET6 ,128 , l3index, key->flags, key->key, key->keylen, - sk_gfp_mask(sk, GFP_ATOMIC)); +tcp_md5_key_copy (newsk, (union tcp_md5_addr *)&newsk->sk_v6_daddr, + AF_INET6, 128, l3index, key); }#endif
Signature · 1 line
2.38.1
PATCH v5 4/5 net/tcp: Do cleanup on tcp_md5_key_copy() failure
In reply to Dmitry SafonovIf the kernel was short on (atomic) memory and failed to allocate it - don't proceed to creation of request socket. Otherwise the socket would be unsigned and userspace likely doesn't expect that the TCP is not MD5-signed anymore.
--- net/ipv4/tcp_ipv4.c | 9 ++------- net/ipv6/tcp_ipv6.c | 15 ++++++++------- 2 files changed, 10 insertions(+), 14 deletions(-)
net/ipv4/tcp_ipv4.c +2 -7
@@ -1630,13 +1630,8 @@ struct sock *tcp_v4_syn_recv_sock(const struct sock *sk, struct sk_buff *skb, addr = (union tcp_md5_addr *)&newinet->inet_daddr; key =tcp_md5_do_lookup (sk, l3index, addr,AF_INET );if (key) { -/* -* We're using one, so create a matching key -* on the newsk structure. If we fail to get -* memory, then we end up not copying the key -* across. Shucks. -*/ -tcp_md5_key_copy (newsk, addr,AF_INET ,32 , l3index, key); +if (tcp_md5_key_copy (newsk, addr,AF_INET ,32 , l3index, key)) + goto put_and_exit;sk_gso_disable (newsk); }#endif
net/ipv6/tcp_ipv6.c +8 -7
@@ -1376,13 +1376,14 @@ static struct sock *tcp_v6_syn_recv_sock(const struct sock *sk, struct sk_buff */* Copy over the MD5 key from the original socket */ key =tcp_v6_md5_do_lookup (sk, &newsk->sk_v6_daddr, l3index);if (key) { -/* We're using one, so create a matching key -* on the newsk structure. If we fail to get -* memory, then we end up not copying the key -* across. Shucks. -*/ -tcp_md5_key_copy (newsk, (union tcp_md5_addr *)&newsk->sk_v6_daddr, -AF_INET6 ,128 , l3index, key); +const union tcp_md5_addr *addr; + + addr = (union tcp_md5_addr *)&newsk->sk_v6_daddr; +if (tcp_md5_key_copy (newsk, addr,AF_INET6 ,128 , l3index, key)) { +inet_csk_prepare_forced_close (newsk); +tcp_done (newsk); + goto out; + } }#endif
Signature · 1 line
2.38.1
PATCH v5 5/5 net/tcp: Separate initialization of twsk
In reply to Dmitry SafonovConvert BUG_ON() to WARN_ON_ONCE() and warn as well for unlikely static key int overflow error-path.
--- net/ipv4/tcp_minisocks.c | 61 +++++++++++++++++++++++----------------- 1 file changed, 35 insertions(+), 26 deletions(-)
net/ipv4/tcp_minisocks.c +35 -26
@@ -240,6 +240,40 @@ tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb, }EXPORT_SYMBOL (tcp_timewait_state_process); +static void tcp_time_wait_init (struct sock *sk,struct tcp_timewait_sock *tcptw) +{ +#ifdef CONFIG_TCP_MD5SIG +const struct tcp_sock *tp =tcp_sk (sk); +struct tcp_md5sig_key *key; + +/* +* The timewait bucket does not have the key DB from the +* sock structure. We just make a quick copy of the +* md5 key being used (if indeed we are using one) +* so the timewait ack generating code has the key. +*/ + tcptw->tw_md5_key =NULL ; +if (!static_branch_unlikely (&tcp_md5_needed.key)) +return ; + + key = tp->af_specific->md5_lookup (sk, sk); +if (key) { + tcptw->tw_md5_key =kmemdup (key,sizeof (*key),GFP_ATOMIC ); +if (!tcptw->tw_md5_key) +return ; +if (!tcp_alloc_md5sig_pool ()) + goto out_free; +if (!static_key_fast_inc_not_negative (&tcp_md5_needed.key.key)) + goto out_free; + } +return ; +out_free: +WARN_ON_ONCE (1 ); +kfree (tcptw->tw_md5_key); + tcptw->tw_md5_key =NULL ; +#endif +} +/* * Move a socket to time-wait or dead fin-wait-2 state. */
@@ -282,32 +316,7 @@ void tcp_time_wait(struct sock *sk, int state, int timeo) }#endif -#ifdef CONFIG_TCP_MD5SIG -/* -* The timewait bucket does not have the key DB from the -* sock structure. We just make a quick copy of the -* md5 key being used (if indeed we are using one) -* so the timewait ack generating code has the key. -*/ -do { - tcptw->tw_md5_key =NULL ; -if (static_branch_unlikely (&tcp_md5_needed.key)) { -struct tcp_md5sig_key *key; - - key = tp->af_specific->md5_lookup (sk, sk); -if (key) { - tcptw->tw_md5_key =kmemdup (key,sizeof (*key),GFP_ATOMIC ); -if (!tcptw->tw_md5_key) -break ; -BUG_ON (!tcp_alloc_md5sig_pool ()); -if (!static_key_fast_inc_not_negative (&tcp_md5_needed.key.key)) { -kfree (tcptw->tw_md5_key); - tcptw->tw_md5_key =NULL ; - } - } - } - }while (0 ); -#endif +tcp_time_wait_init (sk, tcptw);/* Get the TIME_WAIT timeout firing. */ if (timeo < rto)
Signature · 1 line
2.38.1