Skip to contentSkip to conversation

arm64: arch_k3: Removed ti mailbox and sci select

PATCH In review Nicolas Frayer 3 participants 7 messages Nov 22, 2022 – Nov 25, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover arm64: arch_k3: Removed ti mailbox and sci select

Removing the automatic selection of the TI message manager and the TI sci protocol drivers from ARCH_K3 to allow module build support. Set these 2 drivers as ARCH_K3 for the default selection. Tested on a TI AM62x SK board.

Nicolas Frayer (3):
arm64: arch_k3: Removed ti mailbox and sci select
mailbox: config: ti-msgmgr: Default set to ARCH_K3 for TI msg manager
firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver

 arch/arm64/Kconfig.platforms | 2 --
 drivers/firmware/Kconfig     | 1 +
 drivers/mailbox/Kconfig      | 1 +
 3 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/3 arm64: arch_k3: Removed ti mailbox and sci select

In order to build ti mailbox and ti sci as modules, remove their automatic selection by ARCH_K3

---
 arch/arm64/Kconfig.platforms | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/Kconfig.platforms +0 -2
index 912529ac58b3..5f16eb498dbf 100644
@@ -126,8 +126,6 @@ config ARCH_K3
 	select PM_GENERIC_DOMAINS if PM
 	select MAILBOX
 	select SOC_TI
-	select TI_MESSAGE_MANAGER
-	select TI_SCI_PROTOCOL
 	select TI_SCI_INTR_IRQCHIP
 	select TI_SCI_INTA_IRQCHIP
 	help
Signature · 1 line
2.25.1
#2 lore raw
Quoted 3 lines · Nicolas Frayer

In order to build ti mailbox and ti sci as modules, remove their automatic selection by ARCH_K3

$Subject: s/Removed/Remove,
s/ti/TI
s/sci/SCI

Quoted 10 lines
---
 arch/arm64/Kconfig.platforms | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/Kconfig.platforms +0 -0
index 912529ac58b3..5f16eb498dbf 100644

arch/arm64/Kconfig.platforms config ARCH_K3 · line 131

Quoted 8 lines
arch/arm64/Kconfig.platforms +0 -2
@@ -126,8 +126,6 @@ config ARCH_K3
 	select PM_GENERIC_DOMAINS if PM
 	select MAILBOX
 	select SOC_TI
-	select TI_MESSAGE_MANAGER
-	select TI_SCI_PROTOCOL
 	select TI_SCI_INTR_IRQCHIP
 	select TI_SCI_INTA_IRQCHIP
 	help

Why not use "imply" instead of "select". This should allow TI_SCI* drivers to be built as modules if required. Would make 2/3 and 3/3 redundant.

Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees, so not a great idea to post as a single series.

Regards
Vignesh

#3 lore raw
Quoted 36 lines · Vignesh Raghavendra
Quoted 3 lines · Nicolas Frayer

In order to build ti mailbox and ti sci as modules, remove their automatic selection by ARCH_K3

$Subject: s/Removed/Remove,
s/ti/TI
s/sci/SCI

Quoted 10 lines
---
 arch/arm64/Kconfig.platforms | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/Kconfig.platforms +0 -0
index 912529ac58b3..5f16eb498dbf 100644

arch/arm64/Kconfig.platforms config ARCH_K3 · line 131

Quoted 8 lines
arch/arm64/Kconfig.platforms +0 -2
@@ -126,8 +126,6 @@ config ARCH_K3
      select PM_GENERIC_DOMAINS if PM
      select MAILBOX
      select SOC_TI
-     select TI_MESSAGE_MANAGER
-     select TI_SCI_PROTOCOL
      select TI_SCI_INTR_IRQCHIP
      select TI_SCI_INTA_IRQCHIP
      help

Why not use "imply" instead of "select". This should allow TI_SCI* drivers to be built as modules if required. Would make 2/3 and 3/3 redundant.

Quoted 5 lines

Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees, so not a great idea to post as a single series.

Regards
Vignesh

Thanks Vignesh, I'll send a v2 using imply and drop 2/3 and 3/3

#4 lore raw

PATCH 2/3 mailbox: config: ti-msgmgr: Default set to ARCH_K3 for TI msg manager

In reply to Nicolas Frayer

Defaulting the build to ARCH_K3 for the TI message manager driver.

---
 drivers/mailbox/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/mailbox/Kconfig +1 -0
index d7af896cbd7b..04c442532b70 100644
@@ -136,6 +136,7 @@ config STI_MBOX
 config TI_MESSAGE_MANAGER
 	tristate "Texas Instruments Message Manager Driver"
 	depends on ARCH_KEYSTONE || ARCH_K3
+	default ARCH_K3
 	help
 	  An implementation of Message Manager slave driver for Keystone
 	  and K3 architecture SoCs from Texas Instruments. Message Manager
Signature · 1 line
2.25.1
#5 lore raw

PATCH 3/3 firmware: config: ti-sci: Default set to ARCH_K3 for the ti sci driver

In reply to Nicolas Frayer

Defaulting the build to ARCH_K3 for the TI SCI driver.

---
 drivers/firmware/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/firmware/Kconfig +1 -0
index b59e3041fd62..9e29055f62ba 100644
@@ -261,6 +261,7 @@ config SYSFB_SIMPLEFB
 config TI_SCI_PROTOCOL
 	tristate "TI System Control Interface (TISCI) Message Protocol"
 	depends on TI_MESSAGE_MANAGER
+	default ARCH_K3
 	help
 	  TI System Control Interface (TISCI) Message Protocol is used to manage
 	  compute systems such as ARM, DSP etc with the system controller in
Signature · 1 line
2.25.1
Reviewed-by on the v1 series
#6 lore raw
In reply to Nicolas Frayer
Quoted 4 lines · Nicolas Frayer

Removing the automatic selection of the TI message manager and the TI sci protocol drivers from ARCH_K3 to allow module build support. Set these 2 drivers as ARCH_K3 for the default selection. Tested on a TI AM62x SK board.

In the future, please include [email protected] list, which is where more developers for these K3 platforms hang out and you might get more review & testing.

Thanks,

Kevin