package/iwd: add dbus compile time dependency
PATCH v3 1/1 package/iwd: add dbus compile time dependency
In 5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4 we dropped dbus as a build dependency, however we still need it when building with systemd so that the service directory is available via pkg-config.
In addition we can drop --with-dbus-datadir by unconditionally requiring dbus as the datadir will then be fetched from pkg-config.
Fixes:
checking D-Bus bus services directory... configure: error: D-Bus bus services directory is required
---
Changes v2 -> v3:
- always depend on dbus
Changes v1 -> v2:
- depend on dbus when depending on systemd
--- package/iwd/iwd.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
package/iwd/iwd.mk +2 -3
@@ -16,9 +16,8 @@ IWD_SELINUX_MODULES = networkmanager IWD_CONF_OPTS = \ --disable-manual-pages \ --enable-external-ell \ - --enable-dbus-policy \ - --with-dbus-datadir=/usr/share -IWD_DEPENDENCIES = ell + --enable-dbus-policy +IWD_DEPENDENCIES = dbus ell ifeq ($(BR2_PACKAGE_READLINE),y) # iwd client depends on readline (GPL-3.0+)
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH v3 1/1 package/iwd: add dbus compile time dependency
Hi James,
Quoted 3 lines
In
5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4we dropped dbus as a build dependency, however we still need it when building with systemd so that the service directory is available via pkg-config.
Sorry for getting this whole mess started.
I only did a compile test without systemd before submitting the patch.
I guess the comment in package/iwd/Config.in:8 should be removed then, since that's what got me started.
Quoted 31 lines
In addition we can drop --with-dbus-datadir by unconditionally requiring dbus as the datadir will then be fetched from pkg-config.
Fixes:
checking D-Bus bus services directory... configure: error: D-Bus bus services directory is requiredSigned-off-by James Hilliard <[email protected]>---
Changes v2 -> v3:
- always depend on dbus
Changes v1 -> v2:
- depend on dbus when depending on systemd
---
package/iwd/iwd.mk | 5 ++---1 file changed, 2 insertions(+), 3 deletions(-)package/iwd/iwd.mk +2
-3@@ -16,9 +16,8 @@ IWD_SELINUX_MODULES = networkmanager IWD_CONF_OPTS = \ --disable-manual-pages \ --enable-external-ell \ - --enable-dbus-policy \ - --with-dbus-datadir=/usr/share -IWD_DEPENDENCIES = ell + --enable-dbus-policy +IWD_DEPENDENCIES = dbus ell
ifeq ($(BR2_PACKAGE_READLINE),y)
Quoted 3 lines
# iwd client depends on readline (GPL-3.0+)Signature · 1 line
2.34.1
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 7 lines · Lang Daniel
Hi James,
Quoted 3 lines
In
5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4we dropped dbus as a build dependency, however we still need it when building with systemd so that the service directory is available via pkg-config.
Quoted 5 lines
Sorry for getting this whole mess started.
I only did a compile test without systemd before submitting the patch.I guess the comment in package/iwd/Config.in:8 should be removed then, since that's what got me started.
It's not entirely wrong as dbus isn't strictly needed as a build dependency, see discussion in my original v1 fix patch which leaves it as runtime only:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
Quoted 31 lines
Quoted 31 lines
In addition we can drop --with-dbus-datadir by unconditionally requiring dbus as the datadir will then be fetched from pkg-config.
Fixes:
checking D-Bus bus services directory... configure: error: D-Bus bus services directory is requiredSigned-off-by James Hilliard <[email protected]>---
Changes v2 -> v3:
- always depend on dbus
Changes v1 -> v2:
- depend on dbus when depending on systemd--- package/iwd/iwd.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)package/iwd/iwd.mk +2
-3@@ -16,9 +16,8 @@ IWD_SELINUX_MODULES = networkmanager IWD_CONF_OPTS = \ --disable-manual-pages \ --enable-external-ell \ - --enable-dbus-policy \ - --with-dbus-datadir=/usr/share -IWD_DEPENDENCIES = ell + --enable-dbus-policy +IWD_DEPENDENCIES = dbus ell
Quoted 4 lines
Quoted 4 lines
package/iwd/iwd.mk +0
-1ifeq ($(BR2_PACKAGE_READLINE),y) # iwd client depends on readline (GPL-3.0+) --2.34.1
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 11 lines · On Mon, 31 Oct 2022 11:49:59 -0600 James Hilliard <[email protected]>…
In
5b3b2d80f4cf586d360ff696c3dacbd4cb48fdc4we dropped dbus as a build dependency, however we still need it when building with systemd so that the service directory is available via pkg-config.In addition we can drop --with-dbus-datadir by unconditionally requiring dbus as the datadir will then be fetched from pkg-config.
Fixes:
checking D-Bus bus services directory... configure: error: D-Bus bus services directory is requiredSigned-off-by James Hilliard <[email protected]>
Quoted 8 lines
---
Changes v2 -> v3:
- always depend on dbus
Changes v1 -> v2:
- depend on dbus when depending on systemd--- package/iwd/iwd.mk | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Applied to master after adding a reference to the autobuilder failure. Thanks!
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot