Skip to contentSkip to conversation

usb: fotg210: Fix build error when CONFIG_USB_FOTG210_UDC=y && CONFIG_USB_GADGET=m

PATCH In review Xia Fukun 2 participants 2 messages Nov 23, 2022

Subsystems (2)
lore
Share & tools
lore

Xia Fukun

author
#0 lore raw

PATCH 1/1 usb: fotg210: Fix build error when CONFIG_USB_FOTG210_UDC=y && CONFIG_USB_GADGET=m

The combination of CONFIG_USB_FOTG210_UDC=y and CONFIG_USB_GADGET=m results in the following error:

drivers/usb/fotg210/fotg210-udc.o: In function `fotg210_done':
fotg210-udc.c:(.text+0x75b): undefined reference to usb_gadget_giveback_request' drivers/usb/fotg210/fotg210-udc.o: In function fotg210_irq':
fotg210-udc.c:(.text+0x1586): undefined reference to usb_gadget_udc_reset' drivers/usb/fotg210/fotg210-udc.o: In function fotg210_udc_remove':
fotg210-udc.c:(.text+0x179a): undefined reference to usb_del_gadget_udc' drivers/usb/fotg210/fotg210-udc.o: In function fotg210_udc_probe':
fotg210-udc.c:(.text+0x19ed): undefined reference to `usb_ep_set_maxpacket_limit'
fotg210-udc.c:(.text+0x1a11): undefined reference to `usb_ep_set_maxpacket_limit'
fotg210-udc.c:(.text+0x1ace): undefined reference to usb_add_gadget_udc' fotg210-udc.c:(.text+0x1b74): undefined reference to usb_ep_set_maxpacket_limit'
make[1]: *** [vmlinux] Error 1
make: *** [vmlinux] Error 2
make: *** Waiting for unfinished jobs....

Make USB_FOTG210_UDC depends on USB_GADGET=y to fix this.

Fixes 1dd33a9f1b95 ("usb: fotg210: Collect pieces of dual mode controller")
---
 drivers/usb/fotg210/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/fotg210/Kconfig +1 -1
index 534206ee0d1d..bc07c7fc8998 100644
@@ -24,7 +24,7 @@ config USB_FOTG210_HCD
 	  module will be called fotg210-hcd.
 
 config USB_FOTG210_UDC
-	depends on USB_GADGET
+	depends on USB_GADGET = y
 	bool "Faraday FOTG210 USB Peripheral Controller support"
 	help
 	   Faraday USB2.0 OTG controller which can be configured as
Signature · 1 line
2.17.1
#1 lore raw

Hi Xia,

thanks for your patch!

Quoted 2 lines · Xia Fukun

The combination of CONFIG_USB_FOTG210_UDC=y and CONFIG_USB_GADGET=m results in the following error:

(...)

Quoted 4 lines

Make USB_FOTG210_UDC depends on USB_GADGET=y to fix this.

Fixes 1dd33a9f1b95 ("usb: fotg210: Collect pieces of dual mode controller")

Isn't this patch that Greg already merged fixing this issue more thoroughly?
https://lore.kernel.org/linux-usb/[email protected]/

Please have a look & test!

Yours,
Linus Walleij