Skip to contentSkip to conversation

net: use %pS for kfree_skb tracing event location

PATCH Applied Stanislav Fomichev 2 participants 2 messages Nov 23, 2022 – Nov 24, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: use %pS for kfree_skb tracing event location

For the cases where 'reason' doesn't give any clue, it's still nice to be able to track the kfree_skb caller location. %p doesn't help much so let's use %pS which prints the symbol+offset.

---
 include/trace/events/skb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/events/skb.h +1 -1
index 50a974f7dfb4..25ab1ff9423d 100644
@@ -42,7 +42,7 @@ TRACE_EVENT(kfree_skb,
 		__entry->reason = reason;
 	),
 
-	TP_printk("skbaddr=%p protocol=%u location=%p reason: %s",
+	TP_printk("skbaddr=%p protocol=%u location=%pS reason: %s",
 		  __entry->skbaddr, __entry->protocol, __entry->location,
 		  __print_symbolic(__entry->reason,
 				   DEFINE_DROP_REASON(FN, FNe)))
Signature · 1 line
2.38.1.584.g0f3c55d4c2-goog
#1 lore raw
This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by Paolo Abeni <[email protected]>:

Quoted 8 lines · On Tue, 22 Nov 2022 20:09:47 -0800 you wrote:

For the cases where 'reason' doesn't give any clue, it's still nice to be able to track the kfree_skb caller location. %p doesn't help much so let's use %pS which prints the symbol+offset.

---
 include/trace/events/skb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [net-next] net: use %pS for kfree_skb tracing event location

    https://git.kernel.org/netdev/net-next/c/14e5f71e31ff

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html