Skip to contentSkip to conversation

btrfs: avoid use-after-free when return the error code

PATCH In review void0red 2 participants 2 messages Nov 23, 2022 Btrfs file system

lore
Share & tools
lore

void0red

author
#0 lore raw

PATCH 1/1 btrfs: avoid use-after-free when return the error code

free_extent_map(em) will free em->map_lookup, so it is wrong to use it when return.

---
 fs/btrfs/volumes.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/btrfs/volumes.c +2 -1
index 635f45f1a2ef..dba087ad40ea 100644
@@ -7241,8 +7241,9 @@ static int read_one_chunk(struct btrfs_key *key, struct extent_buffer *leaf,
 			map->stripes[i].dev = handle_missing_device(fs_info,
 								    devid, uuid);
 			if (IS_ERR(map->stripes[i].dev)) {
+				ret = PTR_ERR(map->stripes[i].dev);
 				free_extent_map(em);
-				return PTR_ERR(map->stripes[i].dev);
+				return ret;
 			}
 		}
 
Signature · 1 line
2.34.1