btrfs: avoid use-after-free when return the error code
PATCH 1/1 btrfs: avoid use-after-free when return the error code
free_extent_map(em) will free em->map_lookup, so it is wrong to use it when return.
Signed-off-by void0red <[email protected]>
Reported-by eriri <[email protected]>
--- fs/btrfs/volumes.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/btrfs/volumes.c +2 -1
@@ -7241,8 +7241,9 @@ static int read_one_chunk(struct btrfs_key *key, struct extent_buffer *leaf, map->stripes[i].dev =handle_missing_device (fs_info, devid, uuid);if (IS_ERR (map->stripes[i].dev)) { + ret =PTR_ERR (map->stripes[i].dev);free_extent_map (em); -return PTR_ERR (map->stripes[i].dev); +return ret; } }
Signature · 1 line
2.34.1
Quoted 6 lines · On Wed, Nov 23, 2022 at 10:39:45PM +0800, void0red wrote:
free_extent_map(em)will freeem->map_lookup, so it is wrong to use it when return.Signed-off-by void0red <[email protected]>Reported-by eriri <[email protected]>
Added to misc-next with updated changelog, thanks.