ASoC: mediatek: mt8186: Correct I2S shared clocks
Subsystems (3)
PATCH v2 1/1 ASoC: mediatek: mt8186: Correct I2S shared clocks
In mt8186 platform, I2S2 should be the main I2S port that provide the clock, on the contrary I2S3 should be the second I2S port that use this clock.
---
Change since v1: Add Fixes tag.
--- sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c | 2 +- sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c +1 -1
@@ -192,7 +192,7 @@ static int mt8186_mt6366_da7219_max98357_hdmi_init(struct snd_soc_pcm_runtime *rstruct mt8186_mt6366_da7219_max98357_priv *priv = soc_card_data->mach_priv;int ret; - ret =mt8186_dai_i2s_set_share (afe,"I2S3" ,"I2S2" ); + ret =mt8186_dai_i2s_set_share (afe,"I2S2" ,"I2S3" );if (ret) {dev_err (rtd->dev,"Failed to set up shared clocks\n" );return ret;
sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c +1 -1
@@ -260,7 +260,7 @@ static int mt8186_mt6366_rt1019_rt5682s_hdmi_init(struct snd_soc_pcm_runtime *rtstruct mt8186_mt6366_rt1019_rt5682s_priv *priv = soc_card_data->mach_priv;int ret; - ret =mt8186_dai_i2s_set_share (afe,"I2S3" ,"I2S2" ); + ret =mt8186_dai_i2s_set_share (afe,"I2S2" ,"I2S3" );if (ret) {dev_err (rtd->dev,"Failed to set up shared clocks\n" );return ret;
Signature · 1 line
2.25.1
Il 24/11/22 03:30, Jiaxin Yu ha scritto:
Quoted 6 lines
In mt8186 platform, I2S2 should be the main I2S port that provide the clock, on the contrary I2S3 should be the second I2S port that use this clock.
Fixes 9986bdaee477 ("ASoC: mediatek: mt8186: Configure shared clocks")Signed-off-by Jiaxin Yu <[email protected]>
Sorry, had both versions open and I've sent the R-b tag to the wrong one. I meant to send that only to v2.
Mark Brown
maintainerQuoted 5 lines · Jiaxin Yu
In mt8186 platform, I2S2 should be the main I2S port that provide the clock, on the contrary I2S3 should be the second I2S port that use this clock.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: mediatek: mt8186: Correct I2S shared clocks
commit: 248579fc9a4f3bf36e7cfe9f6a354cee0f9848dc
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark