Skip to contentSkip to conversation

net: wwan: iosm: fix crash in peek throughput test

PATCH Applied [email protected] 1 participant 1 message Nov 24, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH v2 3/4 net: wwan: iosm: fix crash in peek throughput test

From: M Chetan Kumar <[email protected]>

Peek throughput UL test is resulting in crash. If the UL transfer block free list is exhaust, the peeked skb is freed. In the next transfer freed skb is referred from UL list which results in crash.

Don't free the skb if UL transfer blocks are unavailable. The pending skb will be picked for transfer on UL transfer block available.

Fixes 1f52d7b62285 ("net: wwan: iosm: Enable M.2 7360 WWAN card support")

--
v2: No Change.

---
 drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/wwan/iosm/iosm_ipc_mux_codec.c +2 -3
index c16365123660..738420bd14af 100644
@@ -1207,10 +1207,9 @@ static int mux_ul_dg_update_tbl_index(struct iosm_mux *ipc_mux,
 				 qlth_n_ql_size, ul_list);
 	ipc_mux_ul_adb_finish(ipc_mux);
 	if (ipc_mux_ul_adb_allocate(ipc_mux, adb, &ipc_mux->size_needed,
-				    IOSM_AGGR_MUX_SIG_ADBH)) {
-		dev_kfree_skb(src_skb);
+				    IOSM_AGGR_MUX_SIG_ADBH))
 		return -ENOMEM;
-	}
+
 	ipc_mux->size_needed = le32_to_cpu(adb->adbh->block_length);
 
 	ipc_mux->size_needed += offsetof(struct mux_adth, dg);
Signature · 1 line
2.34.1