can: ctucanfd: Drop obsolete dependency on COMPILE_TEST
Subsystems (2)
PATCH 1/1 can: ctucanfd: Drop obsolete dependency on COMPILE_TEST
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed.
It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues.
--- drivers/net/can/ctucanfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/can/ctucanfd/Kconfig +1 -1
@@ -23,7 +23,7 @@ config CAN_CTUCANFD_PCI config CAN_CTUCANFD_PLATFORM tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver" - depends on HAS_IOMEM && (OF || COMPILE_TEST) + depends on HAS_IOMEM && OF select CAN_CTUCANFD help The core has been tested together with OpenCores SJA1000
Signature · 2 lines
Jean Delvare SUSE L3 Support
Pavel Pisa
maintainerThanks for the care. I cannot judge change on my personal opinion. But if that is general direction even for other drivers then I confirm the change.
Quoted 31 lines · On Thursday 24 of November 2022 14:16:04 Jean Delvare wrote:
Since commit
0166dc11be91("of: makeCONFIG_OFuser selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending onCOMPILE_TESTas an alternative is no longer needed.It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping
COMPILE_TESThere improves the quality of our testing and avoids wasting time on non-existent issues.Signed-off-by Jean Delvare <[email protected]>Cc Pavel Pisa <[email protected]>Cc Ondrej Ille <[email protected]>--- drivers/net/can/ctucanfd/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/can/ctucanfd/Kconfig +1
-1@@ -23,7 +23,7 @@ config CAN_CTUCANFD_PCI config CAN_CTUCANFD_PLATFORM tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver" - depends on HAS_IOMEM && (OF || COMPILE_TEST) + depends on HAS_IOMEM && OF select CAN_CTUCANFD help The core has been tested together with OpenCores SJA1000
Marc Kleine-Budde
maintainerQuoted 3 lines · Pavel Pisa
Thanks for the care. I cannot judge change on my personal opinion. But if that is general direction even for other drivers then I confirm the change.
Should I convert this into a formal Acked-by: :)
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 6 lines · On Friday 25 of November 2022 16:57:58 Marc Kleine-Budde wrote:
Quoted 3 lines · Pavel Pisa
Thanks for the care. I cannot judge change on my personal opinion. But if that is general direction even for other drivers then I confirm the change.
Should I convert this into a formal Acked-by: :)
I you prefer formal one and agree with the change then yes.
Marc Kleine-Budde
maintainerQuoted 11 lines · Pavel Pisa
Quoted 6 lines · On Friday 25 of November 2022 16:57:58 Marc Kleine-Budde wrote:
Quoted 3 lines · Pavel Pisa
Thanks for the care. I cannot judge change on my personal opinion. But if that is general direction even for other drivers then I confirm the change.
Should I convert this into a formal Acked-by: :)
I you prefer formal one and agree with the change then yes.
Acked-by Pavel Pisa <[email protected]>
Thanks, the 'b4' tool picks up the Acked-by automatically.
regards,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 13 lines · Jean Delvare
Since commit
0166dc11be91("of: makeCONFIG_OFuser selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending onCOMPILE_TESTas an alternative is no longer needed.It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping
COMPILE_TESThere improves the quality of our testing and avoids wasting time on non-existent issues.
Quoted 3 lines
Signed-off-by Jean Delvare <[email protected]>Cc Pavel Pisa <[email protected]>Cc Ondrej Ille <[email protected]>
Applied to linux-can.
Thanks,
Marc
Signature · 4 lines
Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |