remoteproc: qcom: q6v5: Fix potential null-ptr-deref in q6v5_wcss_init_mmio()
Subsystems (2)
PATCH 1/1 remoteproc: qcom: q6v5: Fix potential null-ptr-deref in q6v5_wcss_init_mmio()
q6v5_wcss_init_mmio() will call platform_get_resource_byname() that may fail and return NULL. devm_ioremap() will use res->start as input, which may causes null-ptr-deref. Check the ret value of platform_get_resource_byname() to avoid the null-ptr-deref.
Fixes 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
Signed-off-by Shang XiaoJing <[email protected]>
--- drivers/remoteproc/qcom_q6v5_wcss.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/remoteproc/qcom_q6v5_wcss.c +3 -0
@@ -827,6 +827,9 @@ static int q6v5_wcss_init_mmio(struct q6v5_wcss *wcss,int ret; res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"qdsp6" ); +if (!res) +return -EINVAL ; + wcss->reg_base =devm_ioremap (&pdev->dev, res->start,resource_size (res));if (!wcss->reg_base)
Signature · 1 line
2.17.1
Quoted 6 lines · Shang XiaoJing
q6v5_wcss_init_mmio()will callplatform_get_resource_byname()that may fail and return NULL.devm_ioremap()will useres->startas input, which may causes null-ptr-deref. Check the ret value ofplatform_get_resource_byname()to avoid the null-ptr-deref.
Applied, thanks!
[1/1] remoteproc: qcom: q6v5: Fix potential null-ptr-deref in q6v5_wcss_init_mmio()
commit: f360e2b275efbb745ba0af8b47d9ef44221be586
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>