media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam
PATCH v2 1/1 media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam
If the host is powered off, there will be many warning log:
[ 335.526279] aspeed-video 1e700000.video: Timed out; first mode detect [ 335.544172] aspeed-video 1e700000.video: No signal; don't start frame [ 337.165555] aspeed-video 1e700000.video: Timed out; first mode detect [ 337.186214] aspeed-video 1e700000.video: No signal; don't start frame [ 338.815501] aspeed-video 1e700000.video: Timed out; first mode detect [ 338.834008] aspeed-video 1e700000.video: No signal; don't start frame
To avoid the log spam in this condition, replace v4l2_warn with v4l2_dbg.
Link https://lore.kernel.org/openbmc/Y1dX9r9ybGjBrW0k at hatter.bewilderbeest.net/
Reported by: Zev Weiss <[email protected]>
Signed-off-by Jammy Huang <[email protected]>
---
v2:
- update commit message
--- drivers/media/platform/aspeed/aspeed-video.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
drivers/media/platform/aspeed/aspeed-video.c +8 -8
@@ -586,13 +586,13 @@ static int aspeed_video_start_frame(struct aspeed_video *video)bool bcd_buf_need = (video->format !=VIDEO_FMT_STANDARD );if (video->v4l2_input_status) { -v4l2_warn (&video->v4l2_dev,"No signal; don't start frame\n" ); +v4l2_dbg (1 , debug, &video->v4l2_dev,"No signal; don't start frame\n" );return 0 ; }if (!(seq_ctrl &VE_SEQ_CTRL_COMP_BUSY ) || !(seq_ctrl &VE_SEQ_CTRL_CAP_BUSY )) { -v4l2_warn (&video->v4l2_dev,"Engine busy; don't start frame\n" ); +v4l2_dbg (1 , debug, &video->v4l2_dev,"Engine busy; don't start frame\n" );return -EBUSY ; }
@@ -615,7 +615,7 @@ static int aspeed_video_start_frame(struct aspeed_video *video) struct aspeed_video_buffer, link);if (!buf) {spin_unlock_irqrestore (&video->lock, flags); -v4l2_warn (&video->v4l2_dev,"No buffers; don't start frame\n" ); +v4l2_dbg (1 , debug, &video->v4l2_dev,"No buffers; don't start frame\n" );return -EPROTO ; }
@@ -796,7 +796,7 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg)if (video->format ==VIDEO_FMT_STANDARD &&list_is_last (&buf->link, &video->buffers)) { empty = false; -v4l2_warn (&video->v4l2_dev,"skip to keep last frame updated\n" ); +v4l2_dbg (1 , debug, &video->v4l2_dev,"skip to keep last frame updated\n" ); }else { buf->vb.vb2_buf.timestamp =ktime_get_ns (); buf->vb.sequence = video->sequence++;
@@ -1060,7 +1060,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)res_check (video), MODE_DETECT_TIMEOUT);if (!rc) { -v4l2_warn (&video->v4l2_dev,"Timed out; first mode detect\n" ); +v4l2_dbg (1 , debug, &video->v4l2_dev,"Timed out; first mode detect\n" );clear_bit (VIDEO_RES_DETECT , &video->flags);return ; }
@@ -1081,7 +1081,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) MODE_DETECT_TIMEOUT);clear_bit (VIDEO_RES_DETECT , &video->flags);if (!rc) { -v4l2_warn (&video->v4l2_dev,"Timed out; second mode detect\n" ); +v4l2_dbg (1 , debug, &video->v4l2_dev,"Timed out; second mode detect\n" );return ; }
@@ -1104,7 +1104,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) }while (invalid_resolution && (tries++ <INVALID_RESOLUTION_RETRIES ));if (invalid_resolution) { -v4l2_warn (&video->v4l2_dev,"Invalid resolution detected\n" ); +v4l2_dbg (1 , debug, &video->v4l2_dev,"Invalid resolution detected\n" );return ; }
@@ -1856,7 +1856,7 @@ static void aspeed_video_stop_streaming(struct vb2_queue *q) !test_bit (VIDEO_FRAME_INPRG , &video->flags), STOP_TIMEOUT);if (!rc) { -v4l2_warn (&video->v4l2_dev,"Timed out when stopping streaming\n" ); +v4l2_dbg (1 , debug, &video->v4l2_dev,"Timed out when stopping streaming\n" );/* * Need to force stop any DMA and try and get HW into a good
base-commit: 08ad43d554bacb9769c6a69d5f771f02f5ba411c
prerequisite-patch-id: bf47e8ab2998acfbc32be5a4b7b5ae8a3ae4218b
prerequisite-patch-id: bf82715983e08f2e810ff1a82ce644f5f9006cd9
prerequisite-patch-id: 28a2040ef0235e5765f05d2fc5529bce2a0f4c6f
prerequisite-patch-id: 7e761c779730536db8baf50db5fc8caf058e95af
prerequisite-patch-id: c48ea20973fa35938a7d33a0e20d2900df48755f
Signature · 1 line
2.25.1