Skip to contentSkip to conversation

usb: gadget: udc: drop obsolete dependencies on COMPILE_TEST

PATCH In review Jean Delvare 2 participants 2 messages Nov 25, 2022 – Nov 28, 2022 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: gadget: udc: drop obsolete dependencies on COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues.

Cc Greg Kroah-Hartman <[email protected]>
Cc Nicolas Ferre <[email protected]>
Cc Alexandre Belloni <[email protected]>
Cc Claudiu Beznea <[email protected]>
Cc Michal Simek <[email protected]>
---
 drivers/usb/gadget/udc/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/gadget/udc/Kconfig +2 -2
@@ -33,7 +33,7 @@ menu "USB Peripheral Controller"
 config USB_AT91
 	tristate "Atmel AT91 USB Device Port"
 	depends on ARCH_AT91
-	depends on OF || COMPILE_TEST
+	depends on OF
 	help
 	   Many Atmel AT91 processors (such as the AT91RM2000) have a
 	   full speed USB Device Port with support for five configurable
@@ -430,7 +430,7 @@ config USB_EG20T
 config USB_GADGET_XILINX
 	tristate "Xilinx USB Driver"
 	depends on HAS_DMA
-	depends on OF || COMPILE_TEST
+	depends on OF
 	help
 	  USB peripheral controller driver for Xilinx USB2 device.
 	  Xilinx USB2 device is a soft IP which supports both full
Signature · 2 lines
Jean Delvare
SUSE L3 Support
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Jean Delvare

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it is possible to test-build any driver which depends on OF on any architecture by explicitly selecting OF. Therefore depending on COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled, so that the test builds are closer to how each driver will actually be built on its intended target. Building them without OF may not test much as the compiler will optimize out potentially large parts of the code. In the worst case, this could even pop false positive warnings. Dropping COMPILE_TEST here improves the quality of our testing and avoids wasting time on non-existent issues.

Quoted 3 lines
Cc Greg Kroah-Hartman <[email protected]>
Cc Nicolas Ferre <[email protected]>

Fine with me:

Thanks Jean. Best regards,
Nicolas

Quoted 32 lines
Cc Alexandre Belloni <[email protected]>
Cc Claudiu Beznea <[email protected]>
Cc Michal Simek <[email protected]>
---
  drivers/usb/gadget/udc/Kconfig |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/gadget/udc/Kconfig +2 -3
@@ -33,7 +33,7 @@ menu "USB Peripheral Controller"
  config USB_AT91
         tristate "Atmel AT91 USB Device Port"
         depends on ARCH_AT91
-       depends on OF || COMPILE_TEST
+       depends on OF
         help
            Many Atmel AT91 processors (such as the AT91RM2000) have a
            full speed USB Device Port with support for five configurable
@@ -430,7 +430,7 @@ config USB_EG20T
  config USB_GADGET_XILINX
         tristate "Xilinx USB Driver"
         depends on HAS_DMA
-       depends on OF || COMPILE_TEST
+       depends on OF
         help
           USB peripheral controller driver for Xilinx USB2 device.
           Xilinx USB2 device is a soft IP which supports both full
 
 
--

Jean Delvare
SUSE L3 Support

Signature · 1 line
Nicolas Ferre