Skip to contentSkip to conversation

RDMA/nldev: Add checks for nla_nest_start() in fill_stat_counter_qps()

PATCH Applied Yuan Can 2 participants 2 messages Nov 26, 2022 – Nov 28, 2022 InfiniBand

lore
Share & tools
lore

Yuan Can

author
#0 lore raw

PATCH 1/1 RDMA/nldev: Add checks for nla_nest_start() in fill_stat_counter_qps()

As the nla_nest_start() may fail with NULL returned, the return value needs to be checked.

Fixes c4ffee7c9bdb ("RDMA/netlink: Implement counter dumpit calback")
---
 drivers/infiniband/core/nldev.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/infiniband/core/nldev.c +2 -0
index 12dc97067ed2..f3309f07e466 100644
@@ -894,6 +894,8 @@ static int fill_stat_counter_qps(struct sk_buff *msg,
 	int ret = 0;
 
 	table_attr = nla_nest_start(msg, RDMA_NLDEV_ATTR_RES_QP);
+	if (!table_attr)
+		return -EMSGSIZE;
 
 	rt = &counter->device->res[RDMA_RESTRACK_QP];
 	xa_lock(&rt->xa);
Signature · 1 line
2.17.1