Skip to contentSkip to conversation

gpio/rockchip: Add missing of_node_put() in rockchip_gpiolib_register()

PATCH New Shang XiaoJing 1 participant 1 message Nov 26, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio/rockchip: Add missing of_node_put() in rockchip_gpiolib_register()

rockchip_gpiolib_register() get the device_node by of_get_parent() with refcount incremented. Add of_node_put() on it before exitting rockchip_gpiolib_register(). So as rockchip_gpio_probe().

Fixes 936ee2675eee ("gpio/rockchip: add driver for rockchip gpio")
---
 drivers/gpio/gpio-rockchip.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpio/gpio-rockchip.c +2 -0
index 870910bb9dd3..3c1e303aaca8 100644
@@ -610,6 +610,7 @@ static int rockchip_gpiolib_register(struct rockchip_pin_bank *bank)
 			return -ENODATA;
 
 		pctldev = of_pinctrl_get(pctlnp);
+		of_node_put(pctlnp);
 		if (!pctldev)
 			return -ENODEV;
 
@@ -712,6 +713,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
 		return -ENODEV;
 
 	pctldev = of_pinctrl_get(pctlnp);
+	of_node_put(pctlnp);
 	if (!pctldev)
 		return -EPROBE_DEFER;
 
Signature · 1 line
2.17.1