Skip to contentSkip to conversation

hwmon: (hih6130) Modify mismatched function name

PATCH In review Jiapeng Chong 2 participants 2 messages Nov 27, 2022 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (hih6130) Modify mismatched function name

No functional modification involved.

drivers/hwmon/hih6130.c:185: warning: expecting prototype for hih6130_show_humidity(). Prototype was for hih6130_humidity_show() instead.

---
 drivers/hwmon/hih6130.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/hih6130.c +1 -1
index d9394e19fea8..764e6e185d98 100644
@@ -172,7 +172,7 @@ static ssize_t hih6130_temperature_show(struct device *dev,
 }
 
 /**
- * hih6130_show_humidity() - show humidity measurement value in sysfs
+ * hih6130_humidity_show() - show humidity measurement value in sysfs
  * @dev: device
  * @attr: device attribute
  * @buf: sysfs buffer (PAGE_SIZE) where measurement values are written to
Signature · 1 line
2.20.1.7.g153144c
maintainer
#1 lore raw
Quoted 7 lines · Jiapeng Chong

No functional modification involved.

drivers/hwmon/hih6130.c:185: warning: expecting prototype for hih6130_show_humidity(). Prototype was for hih6130_humidity_show() instead.

NACK. We don't start changing function names because some robot thinks we should. Please do not submit such patches against the hwmon or watchdog subsystems.

Guenter

Quoted 17 lines
---
  drivers/hwmon/hih6130.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/hih6130.c +1 -1
index d9394e19fea8..764e6e185d98 100644
@@ -172,7 +172,7 @@ static ssize_t hih6130_temperature_show(struct device *dev,
  }
 
  /**
- * hih6130_show_humidity() - show humidity measurement value in sysfs
+ * hih6130_humidity_show() - show humidity measurement value in sysfs
   * @dev: device
   * @attr: device attribute
   * @buf: sysfs buffer (PAGE_SIZE) where measurement values are written to