Skip to contentSkip to conversation

package/usbmount: select util-linux logger

PATCH In review Michael Nosthoff via buildroot 2 participants 2 messages Nov 28, 2022 – Nov 29, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/usbmount: select util-linux logger

usbmount has a runtime dependency on "logger" from util-linux. Else it will just fail when it tries to log.

---

I wasn't sure if it is neccessary to also add
select BR2_PACKAGE_UTIL_LINUX
or if this is done automatically.

So please adjust if neccessary.

---
 package/usbmount/Config.in | 1 +
 1 file changed, 1 insertion(+)
package/usbmount/Config.in +1 -0
index 7760356b7c..5145587b7c 100644
@@ -3,6 +3,7 @@ config BR2_PACKAGE_USBMOUNT
 	depends on BR2_USE_MMU # lockfile-progs -> liblockfile
 	depends on BR2_PACKAGE_HAS_UDEV
 	select BR2_PACKAGE_LOCKFILE_PROGS
+	select BR2_PACKAGE_UTIL_LINUX_LOGGER
 	help
 	  The usbmount package automatically mounts USB mass storage
 	  devices when they are plugged in, and unmounts them when
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 2 lines · Michael Nosthoff via buildroot

usbmount has a runtime dependency on "logger" from util-linux. Else it will just fail when it tries to log.

If it is just /bin/logger, that is usually provided by busybox (if
CONFIG_LOGGER=y). We don't normally add things for stuff provided by busybox, at least if it is enabled by our default configuration.

So, do you maybe have a custom busybox config?

I've marked the patch as Rejected, feel free to revert if you think this is
needed after all.

Quoted 8 lines

---

I wasn't sure if it is neccessary to also add
select BR2_PACKAGE_UTIL_LINUX
or if this is done automatically.

No it's not done automatically, you indeed have to add it.

Regards,
Arnout

Quoted 11 lines

So please adjust if neccessary.

---
  package/usbmount/Config.in | 1 +
  1 file changed, 1 insertion(+)
package/usbmount/Config.in +0 -0
index 7760356b7c..5145587b7c 100644

package/usbmount/Config.in config BR2_PACKAGE_USBMOUNT · line 9

Quoted 7 lines
package/usbmount/Config.in +1 -0
@@ -3,6 +3,7 @@ config BR2_PACKAGE_USBMOUNT
  	depends on BR2_USE_MMU # lockfile-progs -> liblockfile
  	depends on BR2_PACKAGE_HAS_UDEV
  	select BR2_PACKAGE_LOCKFILE_PROGS
+	select BR2_PACKAGE_UTIL_LINUX_LOGGER
  	help
  	  The usbmount package automatically mounts USB mass storage
  	  devices when they are plugged in, and unmounts them when

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot