usb: typec: tipd: Set mode of operation for USB Type-C connector
Subsystems (2)
PATCH 1/1 usb: typec: tipd: Set mode of operation for USB Type-C connector
Forward the mode of operation to the typec subsystem such that it can configure the mux correctly.
Signed-off-by Sven Peter <[email protected]>
--- drivers/usb/typec/tipd/core.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/usb/typec/tipd/core.c +3 -0
@@ -14,6 +14,7 @@#include <linux/regmap.h> #include <linux/interrupt.h> #include <linux/usb/typec.h> +#include <linux/usb/typec_altmode.h> #include <linux/usb/role.h> #include "tps6598x.h"
@@ -257,6 +258,7 @@ static int tps6598x_connect(struct tps6598x *tps, u32 status)typec_set_orientation (tps->port,TYPEC_ORIENTATION_REVERSE ); else typec_set_orientation(tps->port, TYPEC_ORIENTATION_NORMAL); +typec_set_mode (tps->port,TYPEC_STATE_USB );tps6598x_set_data_role (tps,TPS_STATUS_TO_TYPEC_DATAROLE (status), true); tps->partner =typec_register_partner (tps->port, &desc);
@@ -280,6 +282,7 @@ static void tps6598x_disconnect(struct tps6598x *tps, u32 status)typec_set_pwr_role (tps->port,TPS_STATUS_TO_TYPEC_PORTROLE (status));typec_set_vconn_role (tps->port,TPS_STATUS_TO_TYPEC_VCONN (status));typec_set_orientation (tps->port,TYPEC_ORIENTATION_NONE ); +typec_set_mode (tps->port,TYPEC_STATE_SAFE );tps6598x_set_data_role (tps,TPS_STATUS_TO_TYPEC_DATAROLE (status), false);power_supply_changed (tps->psy);
Signature · 1 line
2.25.1
Quoted 4 lines · Sven Peter
Forward the mode of operation to the typec subsystem such that it can configure the mux correctly.
Signed-off-by Sven Peter <[email protected]>
Looks OK to me.
Reviewed-by Heikki Krogerus <[email protected]>
Quoted 25 lines
--- drivers/usb/typec/tipd/core.c | 3 +++ 1 file changed, 3 insertions(+)drivers/usb/typec/tipd/core.c +2
-0@@ -14,6 +14,7 @@#include <linux/regmap.h> #include <linux/interrupt.h> #include <linux/usb/typec.h> +#include <linux/usb/typec_altmode.h> #include <linux/usb/role.h> #include "tps6598x.h" @@ -257,6 +258,7 @@ static int tps6598x_connect(struct tps6598x *tps, u32 status)typec_set_orientation (tps->port,TYPEC_ORIENTATION_REVERSE ); else typec_set_orientation(tps->port, TYPEC_ORIENTATION_NORMAL); +typec_set_mode (tps->port,TYPEC_STATE_USB );tps6598x_set_data_role (tps,TPS_STATUS_TO_TYPEC_DATAROLE (status), true); tps->partner =typec_register_partner (tps->port, &desc);
drivers/usb/typec/tipd/core.c static void tps6598x_disconnect(struct tps6598x *tps, u32 status) · line 288
Quoted 7 lines
drivers/usb/typec/tipd/core.c +1
-0@@ -280,6 +282,7 @@ static void tps6598x_disconnect(struct tps6598x *tps, u32 status)typec_set_pwr_role (tps->port,TPS_STATUS_TO_TYPEC_PORTROLE (status));typec_set_vconn_role (tps->port,TPS_STATUS_TO_TYPEC_VCONN (status));typec_set_orientation (tps->port,TYPEC_ORIENTATION_NONE ); +typec_set_mode (tps->port,TYPEC_STATE_SAFE );tps6598x_set_data_role (tps,TPS_STATUS_TO_TYPEC_DATAROLE (status), false);power_supply_changed (tps->psy);
thanks,
Signature · 1 line
heikki