Skip to contentSkip to conversation

HID: multitouch: fix Asus ExpertBook P2 P2451FA trackpoint

PATCH Applied José Expósito 2 participants 2 messages Nov 28, 2022 – Dec 20, 2022 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 HID: multitouch: fix Asus ExpertBook P2 P2451FA trackpoint

The HID descriptor of this device contains two mouse collections, one for mouse emulation and the other for the trackpoint.

Both collections get merged and, because the first one defines X and Y, the movemenent events reported by the trackpoint collection are ignored.

Set the MT_CLS_WIN_8_FORCE_MULTI_INPUT class for this device to be able to receive its reports.

This fix is similar to/based on commit 40d5bb87377a ("HID: multitouch:
enable multi-input as a quirk for some devices").

---
 drivers/hid/hid-multitouch.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/hid/hid-multitouch.c +4 -0
index 91a4d3fc30e0..372cbdd223e0 100644
@@ -1967,6 +1967,10 @@ static const struct hid_device_id mt_devices[] = {
 		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
 			USB_VENDOR_ID_ELAN, 0x313a) },
 
+	{ .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT,
+		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
+			USB_VENDOR_ID_ELAN, 0x3148) },
+
 	/* Elitegroup panel */
 	{ .driver_data = MT_CLS_SERIAL,
 		MT_USB_DEVICE(USB_VENDOR_ID_ELITEGROUP,
Signature · 1 line
2.38.1
maintainer Applied
#1 lore raw
Quoted 10 lines · José Expósito

The HID descriptor of this device contains two mouse collections, one for mouse emulation and the other for the trackpoint.

Both collections get merged and, because the first one defines X and Y, the movemenent events reported by the trackpoint collection are ignored.

Set the MT_CLS_WIN_8_FORCE_MULTI_INPUT class for this device to be able to receive its reports.

Quoted 7 lines

This fix is similar to/based on commit 40d5bb87377a ("HID: multitouch:
enable multi-input as a quirk for some devices").

Applied, thank you!

Signature · 2 lines
Jiri Kosina
SUSE Labs